Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0024799 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
feature request | [Openbravo ERP] A. Platform | minor | have not tried | 2013-09-19 16:58 | 2013-10-16 19:46 | |||
Reporter | adrianromero | View Status | public | |||||
Assigned To | AugustoMauch | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP29 | |||
Status | closed | Fix in branch | Fixed in SCM revision | f3b3ef52284b | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | AugustoMauch | |||||||
OBNetwork customer | No | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0024799: Extend SimpleCallout to provide utility methods with actions that can be executed in a callout | |||||||
Description | Callouts can execute actions to show a message, execute javascript code, etc. SimpleCallout class can be extended to make it easier to invoke this functionality. | |||||||
Steps To Reproduce | For example to show a message using Simple callout you have to execute the following code: addResult("MESSAGE", message); It will be more clear and less error prone to expose a method that executes this: showMessage(message); | |||||||
Proposed Solution | Attached a patch that implements several utility methods for SimpleCallout. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0061634) hgbot (developer) 2013-10-09 16:46 |
Repository: erp/devel/pi Changeset: 2302c22810c1832366a7ec438b9d5da5a9955d24 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Wed Oct 09 16:45:41 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/2302c22810c1832366a7ec438b9d5da5a9955d24 [^] Fixes issue 0024799: Extend SimpleCallout to provide utility methods with actions that can be executed in a callout This changeset adds several utility methods for messages and other actions in callouts --- M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java --- |
(0061635) AugustoMauch (administrator) 2013-10-09 16:50 |
Code reviewed and verified in pi@2302c22810c1 |
(0061647) hgbot (developer) 2013-10-10 10:59 |
Repository: erp/devel/pi Changeset: f3b3ef52284b324f227ddad2358e1af68dbc4349 Author: Adrián Romero <adrianromero <at> openbravo.com> Date: Thu Oct 10 10:59:20 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/f3b3ef52284b324f227ddad2358e1af68dbc4349 [^] Fixes issue 0024799: Extend SimpleCallout to provide utility methods with actions that can be executed in a callout Removing unused commands and changing visibility of new utility methods to protected --- M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java --- |
(0061674) AugustoMauch (administrator) 2013-10-15 10:24 |
Code reviewed and verified |
(0061738) hudsonbot (viewer) 2013-10-16 19:46 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^] Maturity status: Test |
(0061744) hudsonbot (viewer) 2013-10-16 19:46 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2013-09-19 16:58 | adrianromero | New Issue | |
2013-09-19 16:58 | adrianromero | Assigned To | => AugustoMauch |
2013-09-19 16:58 | adrianromero | File Added: SimpleCalloutImprovement.patch | |
2013-09-19 16:58 | adrianromero | Modules | => Core |
2013-09-19 16:58 | adrianromero | OBNetwork customer | => No |
2013-09-19 16:58 | adrianromero | Triggers an Emergency Pack | => No |
2013-09-19 17:13 | roklenardic | Issue Monitored: roklenardic | |
2013-10-09 16:46 | hgbot | Checkin | |
2013-10-09 16:46 | hgbot | Note Added: 0061634 | |
2013-10-09 16:46 | hgbot | Status | new => resolved |
2013-10-09 16:46 | hgbot | Resolution | open => fixed |
2013-10-09 16:46 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/2302c22810c1832366a7ec438b9d5da5a9955d24 [^] |
2013-10-09 16:50 | AugustoMauch | Review Assigned To | => AugustoMauch |
2013-10-09 16:50 | AugustoMauch | Note Added: 0061635 | |
2013-10-09 16:50 | AugustoMauch | Status | resolved => closed |
2013-10-09 16:50 | AugustoMauch | Fixed in Version | => 3.0MP29 |
2013-10-10 10:59 | hgbot | Checkin | |
2013-10-10 10:59 | hgbot | Note Added: 0061647 | |
2013-10-10 10:59 | hgbot | Status | closed => resolved |
2013-10-10 10:59 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/2302c22810c1832366a7ec438b9d5da5a9955d24 [^] => http://code.openbravo.com/erp/devel/pi/rev/f3b3ef52284b324f227ddad2358e1af68dbc4349 [^] |
2013-10-15 10:24 | AugustoMauch | Note Added: 0061674 | |
2013-10-15 10:24 | AugustoMauch | Status | resolved => closed |
2013-10-16 19:46 | hudsonbot | Checkin | |
2013-10-16 19:46 | hudsonbot | Note Added: 0061738 | |
2013-10-16 19:46 | hudsonbot | Checkin | |
2013-10-16 19:46 | hudsonbot | Note Added: 0061744 |
Copyright © 2000 - 2009 MantisBT Group |