Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024799Openbravo ERPA. Platformpublic2013-09-19 16:582013-10-16 19:46
Reporteradrianromero 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP29 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024799: Extend SimpleCallout to provide utility methods with actions that can be executed in a callout
DescriptionCallouts can execute actions to show a message, execute javascript code, etc. SimpleCallout class can be extended to make it easier to invoke this functionality.

Steps To ReproduceFor example to show a message using Simple callout you have to execute the following code:

   addResult("MESSAGE", message);

It will be more clear and less error prone to expose a method that executes this:

   showMessage(message);
Proposed SolutionAttached a patch that implements several utility methods for SimpleCallout.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch SimpleCalloutImprovement.patch (3,026) 2013-09-19 16:58
https://issues.openbravo.com/file_download.php?file_id=6419&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-09-19 16:58adrianromeroNew Issue
2013-09-19 16:58adrianromeroAssigned To => AugustoMauch
2013-09-19 16:58adrianromeroFile Added: SimpleCalloutImprovement.patch
2013-09-19 16:58adrianromeroModules => Core
2013-09-19 16:58adrianromeroOBNetwork customer => No
2013-09-19 16:58adrianromeroTriggers an Emergency Pack => No
2013-09-19 17:13roklenardicIssue Monitored: roklenardic
2013-10-09 16:46hgbotCheckin
2013-10-09 16:46hgbotNote Added: 0061634
2013-10-09 16:46hgbotStatusnew => resolved
2013-10-09 16:46hgbotResolutionopen => fixed
2013-10-09 16:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/2302c22810c1832366a7ec438b9d5da5a9955d24 [^]
2013-10-09 16:50AugustoMauchReview Assigned To => AugustoMauch
2013-10-09 16:50AugustoMauchNote Added: 0061635
2013-10-09 16:50AugustoMauchStatusresolved => closed
2013-10-09 16:50AugustoMauchFixed in Version => 3.0MP29
2013-10-10 10:59hgbotCheckin
2013-10-10 10:59hgbotNote Added: 0061647
2013-10-10 10:59hgbotStatusclosed => resolved
2013-10-10 10:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/2302c22810c1832366a7ec438b9d5da5a9955d24 [^] => http://code.openbravo.com/erp/devel/pi/rev/f3b3ef52284b324f227ddad2358e1af68dbc4349 [^]
2013-10-15 10:24AugustoMauchNote Added: 0061674
2013-10-15 10:24AugustoMauchStatusresolved => closed
2013-10-16 19:46hudsonbotCheckin
2013-10-16 19:46hudsonbotNote Added: 0061738
2013-10-16 19:46hudsonbotCheckin
2013-10-16 19:46hudsonbotNote Added: 0061744

Notes
(0061634)
hgbot   
2013-10-09 16:46   
Repository: erp/devel/pi
Changeset: 2302c22810c1832366a7ec438b9d5da5a9955d24
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Wed Oct 09 16:45:41 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2302c22810c1832366a7ec438b9d5da5a9955d24 [^]

Fixes issue 0024799: Extend SimpleCallout to provide utility methods with actions that can be executed in a callout
This changeset adds several utility methods for messages and other actions in callouts

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
---
(0061635)
AugustoMauch   
2013-10-09 16:50   
Code reviewed and verified in pi@2302c22810c1
(0061647)
hgbot   
2013-10-10 10:59   
Repository: erp/devel/pi
Changeset: f3b3ef52284b324f227ddad2358e1af68dbc4349
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Thu Oct 10 10:59:20 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f3b3ef52284b324f227ddad2358e1af68dbc4349 [^]

Fixes issue 0024799: Extend SimpleCallout to provide utility methods with actions that can be executed in a callout
Removing unused commands and changing visibility of new utility methods to protected

---
M src/org/openbravo/erpCommon/ad_callouts/SimpleCallout.java
---
(0061674)
AugustoMauch   
2013-10-15 10:24   
Code reviewed and verified
(0061738)
hudsonbot   
2013-10-16 19:46   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^]

Maturity status: Test
(0061744)
hudsonbot   
2013-10-16 19:46   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/51315988909a [^]

Maturity status: Test