Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024789
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminorhave not tried2013-09-17 13:282013-09-18 18:53
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version3.0MP28
StatusclosedFix in branchFixed in SCM revisionc8cdf57a7c81
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Todbaz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024789: Change the way the local string filtering is done to avoid overwriting Smartclient code

DescriptionIn this changeset [1] the function that evaluates the contains condition while filtering was rewritten to make it work with adaptive filtering. This has poor maintenability and would have to be update each time this function changes in smartclient.

[1] https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0061200)
hgbot (developer)
2013-09-17 18:20

 Repository: erp/devel/pi
Changeset: c8cdf57a7c8160a9a9e9f1111a5a8b9c436706bd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Sep 17 18:19:28 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c8cdf57a7c8160a9a9e9f1111a5a8b9c436706bd [^]

Fixes issue 24789: Change the way smartclient contains method is overriden

Avoids rewriting the whole smartclient contains function. If it was called from stringComparison, then it executes the containsNoBlanks function. In all the ot
her cases it executes the smartclients original contains function.

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0061264)
dbaz (viewer)
2013-09-17 20:46

 Reviewed @ changeset: 21154 - 8c4c0a929010
(0061280)
hudsonbot (viewer)
2013-09-18 18:53

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/03baede6c83a [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-09-17 13:28 AugustoMauch New Issue
2013-09-17 13:28 AugustoMauch Assigned To => AugustoMauch
2013-09-17 13:28 AugustoMauch Modules => Core
2013-09-17 13:28 AugustoMauch OBNetwork customer => No
2013-09-17 13:28 AugustoMauch Triggers an Emergency Pack => No
2013-09-17 13:36 AugustoMauch Issue Monitored: dbaz
2013-09-17 13:36 AugustoMauch Review Assigned To => dbaz
2013-09-17 18:20 hgbot Checkin
2013-09-17 18:20 hgbot Note Added: 0061200
2013-09-17 18:20 hgbot Status new => resolved
2013-09-17 18:20 hgbot Resolution open => fixed
2013-09-17 18:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c8cdf57a7c8160a9a9e9f1111a5a8b9c436706bd [^]
2013-09-17 20:46 dbaz Note Added: 0061264
2013-09-17 20:46 dbaz Status resolved => closed
2013-09-17 20:46 dbaz Fixed in Version => 3.0MP28
2013-09-18 18:53 hudsonbot Checkin
2013-09-18 18:53 hudsonbot Note Added: 0061280

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker