Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024789Openbravo ERPA. Platformpublic2013-09-17 13:282013-09-18 18:53
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP28 
Merge Request Status
Review Assigned Todbaz
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024789: Change the way the local string filtering is done to avoid overwriting Smartclient code
DescriptionIn this changeset [1] the function that evaluates the contains condition while filtering was rewritten to make it work with adaptive filtering. This has poor maintenability and would have to be update each time this function changes in smartclient.

[1] https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-09-17 13:28AugustoMauchNew Issue
2013-09-17 13:28AugustoMauchAssigned To => AugustoMauch
2013-09-17 13:28AugustoMauchModules => Core
2013-09-17 13:28AugustoMauchOBNetwork customer => No
2013-09-17 13:28AugustoMauchTriggers an Emergency Pack => No
2013-09-17 13:36AugustoMauchIssue Monitored: dbaz
2013-09-17 13:36AugustoMauchReview Assigned To => dbaz
2013-09-17 18:20hgbotCheckin
2013-09-17 18:20hgbotNote Added: 0061200
2013-09-17 18:20hgbotStatusnew => resolved
2013-09-17 18:20hgbotResolutionopen => fixed
2013-09-17 18:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c8cdf57a7c8160a9a9e9f1111a5a8b9c436706bd [^]
2013-09-17 20:46dbazNote Added: 0061264
2013-09-17 20:46dbazStatusresolved => closed
2013-09-17 20:46dbazFixed in Version => 3.0MP28
2013-09-18 18:53hudsonbotCheckin
2013-09-18 18:53hudsonbotNote Added: 0061280

Notes
(0061200)
hgbot   
2013-09-17 18:20   
Repository: erp/devel/pi
Changeset: c8cdf57a7c8160a9a9e9f1111a5a8b9c436706bd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Sep 17 18:19:28 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c8cdf57a7c8160a9a9e9f1111a5a8b9c436706bd [^]

Fixes issue 24789: Change the way smartclient contains method is overriden

Avoids rewriting the whole smartclient contains function. If it was called from stringComparison, then it executes the containsNoBlanks function. In all the ot
her cases it executes the smartclients original contains function.

---
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0061264)
dbaz   
2013-09-17 20:46   
Reviewed @ changeset: 21154 - 8c4c0a929010
(0061280)
hudsonbot   
2013-09-18 18:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/03baede6c83a [^]

Maturity status: Test