Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0024770
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2013-09-14 09:062013-09-19 10:40
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionec5db1dfd224
ProjectionnoneETAnoneTarget Version3.0MP28
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todmiguelez
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024770: Some views are exported differently on postgresql9.3

DescriptionWhen running a dbconsistency test on postgresql9.3 some views are exported slightly different.

If a view is doing joins and is using the same alias in the joins more then once then postgres does change this on export of views to have more unique aliases.

  
Steps To ReproduceOn postgresql9.3
run install.source
put modules into development (type <> 'T')
run export.database
hg diff
Proposed SolutionReview and commit the slight view changes as they should work on every version and are also imo more readable. Maybe adjust the auto-generated alias names if that is preferred.

TagsNo tags attached.
Attached Filesdiff file icon 24770.diff [^] (32,411 bytes) 2013-09-14 09:07 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0061285)
hgbot (developer)
2013-09-18 20:24

Repository: erp/devel/pi
Changeset: ec5db1dfd22454dfce754a4cadb2c7af293505ab
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Sep 18 20:23:48 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ec5db1dfd22454dfce754a4cadb2c7af293505ab [^]

Fixed 24770: Fix inconsistency in view syntax for postgresql 9.3
When exporting those 3 views on postgres 9.3 they are exported slightly
different as postgres avoids some duplicate (implicit) join table aliases
by adding missing aliases to make those unique.
Those are purely formal changes not doing any functional change.
As after this change duplicate alias name in different subqueries of the views
are avoided the resulting sql is even slightly easier to read.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/views/APRM_RECONCILIATION_V.xml
M src-db/database/model/views/C_INVOICE_CANDIDATE_V.xml
M src-db/database/model/views/M_RESERVATION_PICK_EDIT.xml
---
(0061288)
hudsonbot (developer)
2013-09-19 04:13

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ccc2155870d8 [^]

Maturity status: Test
(0061290)
dmiguelez (developer)
2013-09-19 10:40

Code Review + Testing Ok

- Issue History
Date Modified Username Field Change
2013-09-14 09:06 shuehner New Issue
2013-09-14 09:06 shuehner Assigned To => dmiguelez
2013-09-14 09:06 shuehner Modules => Core
2013-09-14 09:06 shuehner Triggers an Emergency Pack => No
2013-09-14 09:07 shuehner File Added: 24770.diff
2013-09-18 20:22 shuehner Review Assigned To => dmiguelez
2013-09-18 20:22 shuehner Assigned To dmiguelez => shuehner
2013-09-18 20:24 hgbot Checkin
2013-09-18 20:24 hgbot Note Added: 0061285
2013-09-18 20:24 hgbot Status new => resolved
2013-09-18 20:24 hgbot Resolution open => fixed
2013-09-18 20:24 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ec5db1dfd22454dfce754a4cadb2c7af293505ab [^]
2013-09-19 04:13 hudsonbot Checkin
2013-09-19 04:13 hudsonbot Note Added: 0061288
2013-09-19 10:40 dmiguelez Note Added: 0061290
2013-09-19 10:40 dmiguelez Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker