Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024770Openbravo ERPA. Platformpublic2013-09-14 09:062013-09-19 10:40
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP28Fixed in Version 
Merge Request Status
Review Assigned Todmiguelez
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024770: Some views are exported differently on postgresql9.3
DescriptionWhen running a dbconsistency test on postgresql9.3 some views are exported slightly different.

If a view is doing joins and is using the same alias in the joins more then once then postgres does change this on export of views to have more unique aliases.

  
Steps To ReproduceOn postgresql9.3
run install.source
put modules into development (type <> 'T')
run export.database
hg diff
Proposed SolutionReview and commit the slight view changes as they should work on every version and are also imo more readable. Maybe adjust the auto-generated alias names if that is preferred.

Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 24770.diff (32,411) 2013-09-14 09:07
https://issues.openbravo.com/file_download.php?file_id=6406&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-09-14 09:06shuehnerNew Issue
2013-09-14 09:06shuehnerAssigned To => dmiguelez
2013-09-14 09:06shuehnerModules => Core
2013-09-14 09:06shuehnerOBNetwork customer => No
2013-09-14 09:06shuehnerTriggers an Emergency Pack => No
2013-09-14 09:07shuehnerFile Added: 24770.diff
2013-09-18 20:22shuehnerReview Assigned To => dmiguelez
2013-09-18 20:22shuehnerAssigned Todmiguelez => shuehner
2013-09-18 20:24hgbotCheckin
2013-09-18 20:24hgbotNote Added: 0061285
2013-09-18 20:24hgbotStatusnew => resolved
2013-09-18 20:24hgbotResolutionopen => fixed
2013-09-18 20:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ec5db1dfd22454dfce754a4cadb2c7af293505ab [^]
2013-09-19 04:13hudsonbotCheckin
2013-09-19 04:13hudsonbotNote Added: 0061288
2013-09-19 10:40dmiguelezNote Added: 0061290
2013-09-19 10:40dmiguelezStatusresolved => closed

Notes
(0061285)
hgbot   
2013-09-18 20:24   
Repository: erp/devel/pi
Changeset: ec5db1dfd22454dfce754a4cadb2c7af293505ab
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Wed Sep 18 20:23:48 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ec5db1dfd22454dfce754a4cadb2c7af293505ab [^]

Fixed 24770: Fix inconsistency in view syntax for postgresql 9.3
When exporting those 3 views on postgres 9.3 they are exported slightly
different as postgres avoids some duplicate (implicit) join table aliases
by adding missing aliases to make those unique.
Those are purely formal changes not doing any functional change.
As after this change duplicate alias name in different subqueries of the views
are avoided the resulting sql is even slightly easier to read.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/views/APRM_RECONCILIATION_V.xml
M src-db/database/model/views/C_INVOICE_CANDIDATE_V.xml
M src-db/database/model/views/M_RESERVATION_PICK_EDIT.xml
---
(0061288)
hudsonbot   
2013-09-19 04:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/ccc2155870d8 [^]

Maturity status: Test
(0061290)
dmiguelez   
2013-09-19 10:40   
Code Review + Testing Ok