0024545: Impossible to lock a user

Description

Impossible to lock a user

Steps To Reproduce

-Go to file Openbravo.properties and configure the parameter "login.trial.user.lock" with value 2 for example.

Verify that the user never is locked.

Checking the code, you need to configure also the parameter "login.trial.delay.increment" if you want to lock the user.

Proposed Solution

The following code is worn, because when delayInc (login.trial.delay.increment) is 0 the method execute return command and the method never check if it is necessary to lock the user

if (delayInc == 0) {
      // No need to check number of fails as login security is not enabled
      delay = 0;
      numberOfFails = 0;
      return;
    }
src/org/openbravo/base/secureApp/UserLock.java

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

design defect

0024962

3.0MP31

closed

shankarb

It should be possible to lock a user only with parameter "login.trial.user.lock"

Notes
(0060674) AugustoMauch (administrator) 2013-08-20 12:32	The current behaviour is the expected. Users are only locked if the login security is enable, that is, if the login.trial.delay.increment parameter is higher than 0. This was not stated in the documentation, though. It has been updated here [1] and here [2]. [1] http://wiki.openbravo.com/wiki/ERP_2.50:Functional_Documentation/General_Setup#Locking_Users [^] [2] http://wiki.openbravo.com/wiki/Openbravo.properties#Log_in_security [^]

Issue History
Date Modified	Username	Field	Change
2013-08-20 11:06	jecharri	New Issue
2013-08-20 11:06	jecharri	Assigned To	=> AugustoMauch
2013-08-20 11:06	jecharri	Web browser	=> Google Chrome
2013-08-20 11:06	jecharri	Modules	=> Core
2013-08-20 11:06	jecharri	Resolution time	=> 1379887200
2013-08-20 11:06	jecharri	Triggers an Emergency Pack	=> No
2013-08-20 12:29	AugustoMauch	Status	new => scheduled
2013-08-20 12:29	AugustoMauch	fix_in_branch	=> pi
2013-08-20 12:31	AugustoMauch	Issue Monitored: dbaz
2013-08-20 12:31	AugustoMauch	Review Assigned To	=> dbaz
2013-08-20 12:31	AugustoMauch	Web browser	Google Chrome => Google Chrome
2013-08-20 12:31	AugustoMauch	fix_in_branch	pi =>
2013-08-20 12:32	AugustoMauch	Note Added: 0060674
2013-08-20 12:32	AugustoMauch	Status	scheduled => closed
2013-08-20 12:32	AugustoMauch	Resolution	open => no change required
2013-10-17 10:05	jecharri	Relationship added	related to 0024962