Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024545Openbravo ERPA. Platformpublic2013-08-20 11:062013-08-20 12:32
Reporterjecharri 
Assigned ToAugustoMauch 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target Version3.0MP27Fixed in Version 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024545: Impossible to lock a user
DescriptionImpossible to lock a user
Steps To Reproduce-Go to file Openbravo.properties and configure the parameter "login.trial.user.lock" with value 2 for example.

Verify that the user never is locked.

Checking the code, you need to configure also the parameter "login.trial.delay.increment" if you want to lock the user.


Proposed SolutionThe following code is worn, because when delayInc (login.trial.delay.increment) is 0 the method execute return command and the method never check if it is necessary to lock the user

if (delayInc == 0) {
      // No need to check number of fails as login security is not enabled
      delay = 0;
      numberOfFails = 0;
      return;
    }
src/org/openbravo/base/secureApp/UserLock.java
Additional Information
TagsNo tags attached.
Relationships
related to design defect 00249623.0MP31 closed shankarb It should be possible to lock a user only with parameter "login.trial.user.lock" 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-08-20 11:06jecharriNew Issue
2013-08-20 11:06jecharriAssigned To => AugustoMauch
2013-08-20 11:06jecharriWeb browser => Google Chrome
2013-08-20 11:06jecharriModules => Core
2013-08-20 11:06jecharriResolution time => 1379887200
2013-08-20 11:06jecharriTriggers an Emergency Pack => No
2013-08-20 12:29AugustoMauchStatusnew => scheduled
2013-08-20 12:29AugustoMauchfix_in_branch => pi
2013-08-20 12:31AugustoMauchIssue Monitored: dbaz
2013-08-20 12:31AugustoMauchReview Assigned To => dbaz
2013-08-20 12:31AugustoMauchWeb browserGoogle Chrome => Google Chrome
2013-08-20 12:31AugustoMauchfix_in_branchpi =>
2013-08-20 12:32AugustoMauchNote Added: 0060674
2013-08-20 12:32AugustoMauchStatusscheduled => closed
2013-08-20 12:32AugustoMauchResolutionopen => no change required
2013-10-17 10:05jecharriRelationship addedrelated to 0024962

Notes
(0060674)
AugustoMauch   
2013-08-20 12:32   
The current behaviour is the expected. Users are only locked if the login security is enable, that is, if the login.trial.delay.increment parameter is higher than 0.

This was not stated in the documentation, though. It has been updated here [1] and here [2].

[1] http://wiki.openbravo.com/wiki/ERP_2.50:Functional_Documentation/General_Setup#Locking_Users [^]
[2] http://wiki.openbravo.com/wiki/Openbravo.properties#Log_in_security [^]