Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024533
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2013-08-16 14:092013-08-27 08:53
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0MP27
StatusclosedFix in branchFixed in SCM revision94a0603a19cc
ProjectionnoneETAnoneTarget Version3.0MP27
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024533: Improve performance of translation import

DescriptionThe translation import code does spend a huge amount of time in the ad_process_trl_trg.

I.e. importing the spanish core translation one ec2 inside the int-modules job this take around 50s just import the ad_process_trl.xml file.

Secondary that output of the apply.modules ant task doing the trl import has very long lines per file imported which make it very hard to see the important info The path part of every imported file is redundant and should be skipped.

Old example:
     [java] 220956 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationManager - importTrl - Updated=307 - from file /srv/hudson/workspace/try-modules-pgsql/modules/org.openbravo.localization.spain.referencedata.translation.esES/referencedata/translation/es_ES//AD_PROCESS_TRL_es_ES.xml

Proposal:
     [java] 114144 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationManager - importTrl - Updated=307 - from file AD_PROCESS_TRL_es_ES.xml

Instead the path will be printed once per module imported.
Steps To ReproduceInstall spanish core translation module and observe time taking to import the ad_process_trl.xml file.

TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0024680 closedshuehner Improve performance of translation import - part2 

-  Notes
(0060661)
hgbot (developer)
2013-08-19 18:11

 Repository: erp/devel/pi
Changeset: 94fb69776ef0251b50fcde14390978499834a0f0
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 14:12:21 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/94fb69776ef0251b50fcde14390978499834a0f0 [^]

Fixed 24533. Improve performance of import translation process
- Add ad_process_id index to ad_column
- Rewrite ad_process_trl_trg using exists instead of in clause
  and pull up one restriction from subselect to main clause
- Shorting logging output per xml file imported by not repeating
  path of every file imported but just printing it once per module.
- Make order in which files are imported stable by adding a order
  by tablename clause to sql retrieving list of _trl tables.

---
M src-db/database/model/tables/AD_COLUMN.xml
M src-db/database/model/triggers/AD_PROCESS_TRL_TRG.xml
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
M src/org/openbravo/erpCommon/ad_forms/Translation_data.xsql
M src/org/openbravo/erpCommon/modules/ApplyModule.java
---
(0060662)
hgbot (developer)
2013-08-19 18:11

 Repository: erp/devel/pi
Changeset: 94a0603a19cca0bc4c89daea75d16f1eff1559d8
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 15:21:58 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/94a0603a19cca0bc4c89daea75d16f1eff1559d8 [^]

Fixed 24533: Fix dbconsistency

---
M src-db/database/model/tables/AD_COLUMN.xml
---
(0060666)
hudsonbot (viewer)
2013-08-20 01:26

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/28c60a43e596 [^]

Maturity status: Test
(0060667)
hudsonbot (viewer)
2013-08-20 01:26

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/28c60a43e596 [^]

Maturity status: Test
(0060777)
AugustoMauch (administrator)
2013-08-27 08:53

 Code reviewed and verified in pi@327ce5aac264

- Issue History
Date Modified Username Field Change
2013-08-16 14:09 shuehner New Issue
2013-08-16 14:09 shuehner Assigned To => shuehner
2013-08-16 14:09 shuehner Modules => Core
2013-08-16 14:09 shuehner OBNetwork customer => No
2013-08-16 14:09 shuehner Triggers an Emergency Pack => No
2013-08-16 16:23 shuehner Tag Attached: Performance
2013-08-19 18:11 hgbot Checkin
2013-08-19 18:11 hgbot Note Added: 0060661
2013-08-19 18:11 hgbot Status new => resolved
2013-08-19 18:11 hgbot Resolution open => fixed
2013-08-19 18:11 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/94fb69776ef0251b50fcde14390978499834a0f0 [^]
2013-08-19 18:11 hgbot Checkin
2013-08-19 18:11 hgbot Note Added: 0060662
2013-08-19 18:11 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/94fb69776ef0251b50fcde14390978499834a0f0 [^] => http://code.openbravo.com/erp/devel/pi/rev/94a0603a19cca0bc4c89daea75d16f1eff1559d8 [^]
2013-08-19 18:14 shuehner Review Assigned To => AugustoMauch
2013-08-20 01:26 hudsonbot Checkin
2013-08-20 01:26 hudsonbot Note Added: 0060666
2013-08-20 01:26 hudsonbot Checkin
2013-08-20 01:26 hudsonbot Note Added: 0060667
2013-08-27 08:53 AugustoMauch Note Added: 0060777
2013-08-27 08:53 AugustoMauch Status resolved => closed
2013-08-27 08:53 AugustoMauch Fixed in Version => 3.0MP27
2013-09-03 14:54 shuehner Relationship added related to 0024680

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker