Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024533Openbravo ERPA. Platformpublic2013-08-16 14:092013-08-27 08:53
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP27Fixed in Version3.0MP27 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024533: Improve performance of translation import
DescriptionThe translation import code does spend a huge amount of time in the ad_process_trl_trg.

I.e. importing the spanish core translation one ec2 inside the int-modules job this take around 50s just import the ad_process_trl.xml file.

Secondary that output of the apply.modules ant task doing the trl import has very long lines per file imported which make it very hard to see the important info The path part of every imported file is redundant and should be skipped.

Old example:
     [java] 220956 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationManager - importTrl - Updated=307 - from file /srv/hudson/workspace/try-modules-pgsql/modules/org.openbravo.localization.spain.referencedata.translation.esES/referencedata/translation/es_ES//AD_PROCESS_TRL_es_ES.xml

Proposal:
     [java] 114144 [main] INFO org.openbravo.erpCommon.ad_forms.TranslationManager - importTrl - Updated=307 - from file AD_PROCESS_TRL_es_ES.xml

Instead the path will be printed once per module imported.
Steps To ReproduceInstall spanish core translation module and observe time taking to import the ad_process_trl.xml file.

Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0024680 closed shuehner Improve performance of translation import - part2 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-08-16 14:09shuehnerNew Issue
2013-08-16 14:09shuehnerAssigned To => shuehner
2013-08-16 14:09shuehnerModules => Core
2013-08-16 14:09shuehnerOBNetwork customer => No
2013-08-16 14:09shuehnerTriggers an Emergency Pack => No
2013-08-16 16:23shuehnerTag Attached: Performance
2013-08-19 18:11hgbotCheckin
2013-08-19 18:11hgbotNote Added: 0060661
2013-08-19 18:11hgbotStatusnew => resolved
2013-08-19 18:11hgbotResolutionopen => fixed
2013-08-19 18:11hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/94fb69776ef0251b50fcde14390978499834a0f0 [^]
2013-08-19 18:11hgbotCheckin
2013-08-19 18:11hgbotNote Added: 0060662
2013-08-19 18:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/94fb69776ef0251b50fcde14390978499834a0f0 [^] => http://code.openbravo.com/erp/devel/pi/rev/94a0603a19cca0bc4c89daea75d16f1eff1559d8 [^]
2013-08-19 18:14shuehnerReview Assigned To => AugustoMauch
2013-08-20 01:26hudsonbotCheckin
2013-08-20 01:26hudsonbotNote Added: 0060666
2013-08-20 01:26hudsonbotCheckin
2013-08-20 01:26hudsonbotNote Added: 0060667
2013-08-27 08:53AugustoMauchNote Added: 0060777
2013-08-27 08:53AugustoMauchStatusresolved => closed
2013-08-27 08:53AugustoMauchFixed in Version => 3.0MP27
2013-09-03 14:54shuehnerRelationship addedrelated to 0024680

Notes
(0060661)
hgbot   
2013-08-19 18:11   
Repository: erp/devel/pi
Changeset: 94fb69776ef0251b50fcde14390978499834a0f0
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 14:12:21 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/94fb69776ef0251b50fcde14390978499834a0f0 [^]

Fixed 24533. Improve performance of import translation process
- Add ad_process_id index to ad_column
- Rewrite ad_process_trl_trg using exists instead of in clause
  and pull up one restriction from subselect to main clause
- Shorting logging output per xml file imported by not repeating
  path of every file imported but just printing it once per module.
- Make order in which files are imported stable by adding a order
  by tablename clause to sql retrieving list of _trl tables.

---
M src-db/database/model/tables/AD_COLUMN.xml
M src-db/database/model/triggers/AD_PROCESS_TRL_TRG.xml
M src/org/openbravo/erpCommon/ad_forms/TranslationManager.java
M src/org/openbravo/erpCommon/ad_forms/Translation_data.xsql
M src/org/openbravo/erpCommon/modules/ApplyModule.java
---
(0060662)
hgbot   
2013-08-19 18:11   
Repository: erp/devel/pi
Changeset: 94a0603a19cca0bc4c89daea75d16f1eff1559d8
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Aug 16 15:21:58 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/94a0603a19cca0bc4c89daea75d16f1eff1559d8 [^]

Fixed 24533: Fix dbconsistency

---
M src-db/database/model/tables/AD_COLUMN.xml
---
(0060666)
hudsonbot   
2013-08-20 01:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/28c60a43e596 [^]

Maturity status: Test
(0060667)
hudsonbot   
2013-08-20 01:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/28c60a43e596 [^]

Maturity status: Test
(0060777)
AugustoMauch   
2013-08-27 08:53   
Code reviewed and verified in pi@327ce5aac264