Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0024388
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2013-07-22 10:222013-10-18 13:06
ReporteregoitzView Statuspublic 
Assigned Toalostale 
PriorityurgentResolutionfixedFixed in Version3.0MP29
StatusclosedFix in branchFixed in SCM revision4ee0b6443c3a
ProjectionnoneETAnoneTarget Version3.0MP29
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024388: Having two different propery fields for the same column cause a problem showing both on form view

DescriptionAdding two property fields that refer to the same ad_column_id cause a problem showing one of them on form view.
Also cause a problem when updating the record.

invoiceAddress.locationAddress.country
Steps To Reproduce-Define a new module
-Add a new propery field on the sales order window on header window.
The propery is: invoiceAddress.locationAddress.country

After logout and loging the field is properly shown

Then a new property field:

The property is:
partnerAddress.locationAddress.country

After logout and login again you will see that only the second property field is shown with value on form view. ON grid both are properly shown.
Try to update an existing record changing any value. You will get an error.
TagsNo tags attached.
Attached Filesdiff file icon 24388.diff [^] (2,690 bytes) 2013-09-30 11:58 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0061473)
alostale (manager)
2013-09-30 11:57

The problem appears when the are more than one property column that is a foreign key to the same entity (in the case explained in the issue description, both properties link to Country).

In this case FIC generates code for column values having the 2 fields the same column name which causes the problem.

The solution is to generate different column name for property fields.

Executed test cases:
-Following steps to reproduce check visualization and edition both in grid and form views work correctly
(0061474)
alostale (manager)
2013-09-30 11:59

Attached patch to solve this issue, to be pushed in pi for mp29
(0061719)
hgbot (developer)
2013-10-16 17:38

Repository: erp/devel/pi
Changeset: 4ee0b6443c3a27bbeb96c334646bb10d00147b65
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Sep 30 11:54:06 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ee0b6443c3a27bbeb96c334646bb10d00147b65 [^]

fixed bug 24388: 2 property columns referencing same entity do not work

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0061776)
hudsonbot (developer)
2013-10-17 18:21

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/121b38a3673a [^]

Maturity status: Test
(0061803)
AugustoMauch (manager)
2013-10-18 13:06

Code reviewed and verified in pi@eb0f3ecbdae4

- Issue History
Date Modified Username Field Change
2013-07-22 10:22 egoitz New Issue
2013-07-22 10:22 egoitz Assigned To => AugustoMauch
2013-07-22 10:22 egoitz Modules => Core
2013-07-22 10:22 egoitz Resolution time => 1376085600
2013-07-22 10:22 egoitz Triggers an Emergency Pack => No
2013-08-20 12:11 AugustoMauch Assigned To AugustoMauch => mtaal
2013-09-02 09:48 AugustoMauch Target Version 3.0MP27 => 3.0MP28
2013-09-30 09:39 alostale Assigned To mtaal => alostale
2013-09-30 11:54 alostale Review Assigned To => shankarb
2013-09-30 11:54 alostale Status new => scheduled
2013-09-30 11:54 alostale Target Version 3.0MP28 => 3.0MP29
2013-09-30 11:57 alostale Note Added: 0061473
2013-09-30 11:58 alostale File Added: 24388.diff
2013-09-30 11:59 alostale Note Added: 0061474
2013-10-16 17:36 shankarb Review Assigned To shankarb => AugustoMauch
2013-10-16 17:36 shankarb Issue Monitored: AugustoMauch
2013-10-16 17:38 hgbot Checkin
2013-10-16 17:38 hgbot Note Added: 0061719
2013-10-16 17:38 hgbot Status scheduled => resolved
2013-10-16 17:38 hgbot Resolution open => fixed
2013-10-16 17:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4ee0b6443c3a27bbeb96c334646bb10d00147b65 [^]
2013-10-17 18:21 hudsonbot Checkin
2013-10-17 18:21 hudsonbot Note Added: 0061776
2013-10-18 13:06 AugustoMauch Note Added: 0061803
2013-10-18 13:06 AugustoMauch Status resolved => closed
2013-10-18 13:06 AugustoMauch Fixed in Version => 3.0MP29


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker