Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0024388 | Openbravo ERP | A. Platform | public | 2013-07-22 10:22 | 2013-10-18 13:06 |
|
| Reporter | egoitz | |
| Assigned To | alostale | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 3.0MP29 | Fixed in Version | 3.0MP29 | |
| Merge Request Status | |
| Review Assigned To | AugustoMauch |
| OBNetwork customer | OBPS |
| Web browser | |
| Modules | Core |
| Support ticket | 22272 |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0024388: Having two different propery fields for the same column cause a problem showing both on form view |
| Description | Adding two property fields that refer to the same ad_column_id cause a problem showing one of them on form view.
Also cause a problem when updating the record.
invoiceAddress.locationAddress.country |
| Steps To Reproduce | -Define a new module
-Add a new propery field on the sales order window on header window.
The propery is: invoiceAddress.locationAddress.country
After logout and loging the field is properly shown
Then a new property field:
The property is:
partnerAddress.locationAddress.country
After logout and login again you will see that only the second property field is shown with value on form view. ON grid both are properly shown.
Try to update an existing record changing any value. You will get an error.
|
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  24388.diff (2,690) 2013-09-30 11:58
https://issues.openbravo.com/file_download.php?file_id=6433&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-07-22 10:22 | egoitz | New Issue | |
| 2013-07-22 10:22 | egoitz | Assigned To | => AugustoMauch |
| 2013-07-22 10:22 | egoitz | Modules | => Core |
| 2013-07-22 10:22 | egoitz | OBNetwork customer | => Yes |
| 2013-07-22 10:22 | egoitz | Support ticket | => 22272 |
| 2013-07-22 10:22 | egoitz | Resolution time | => 1376085600 |
| 2013-07-22 10:22 | egoitz | Triggers an Emergency Pack | => No |
| 2013-08-20 12:11 | AugustoMauch | Assigned To | AugustoMauch => mtaal |
| 2013-09-02 09:48 | AugustoMauch | Target Version | 3.0MP27 => 3.0MP28 |
| 2013-09-30 09:39 | alostale | Assigned To | mtaal => alostale |
| 2013-09-30 11:54 | alostale | Review Assigned To | => shankarb |
| 2013-09-30 11:54 | alostale | Status | new => scheduled |
| 2013-09-30 11:54 | alostale | Target Version | 3.0MP28 => 3.0MP29 |
| 2013-09-30 11:57 | alostale | Note Added: 0061473 | |
| 2013-09-30 11:58 | alostale | File Added: 24388.diff | |
| 2013-09-30 11:59 | alostale | Note Added: 0061474 | |
| 2013-10-16 17:36 | shankarb | Review Assigned To | shankarb => AugustoMauch |
| 2013-10-16 17:36 | shankarb | Issue Monitored: AugustoMauch | |
| 2013-10-16 17:38 | hgbot | Checkin | |
| 2013-10-16 17:38 | hgbot | Note Added: 0061719 | |
| 2013-10-16 17:38 | hgbot | Status | scheduled => resolved |
| 2013-10-16 17:38 | hgbot | Resolution | open => fixed |
| 2013-10-16 17:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/4ee0b6443c3a27bbeb96c334646bb10d00147b65 [^] |
| 2013-10-17 18:21 | hudsonbot | Checkin | |
| 2013-10-17 18:21 | hudsonbot | Note Added: 0061776 | |
| 2013-10-18 13:06 | AugustoMauch | Note Added: 0061803 | |
| 2013-10-18 13:06 | AugustoMauch | Status | resolved => closed |
| 2013-10-18 13:06 | AugustoMauch | Fixed in Version | => 3.0MP29 |
|
Notes |
|
|
|
The problem appears when the are more than one property column that is a foreign key to the same entity (in the case explained in the issue description, both properties link to Country).
In this case FIC generates code for column values having the 2 fields the same column name which causes the problem.
The solution is to generate different column name for property fields.
Executed test cases:
-Following steps to reproduce check visualization and edition both in grid and form views work correctly |
|
|
|
|
|
Attached patch to solve this issue, to be pushed in pi for mp29 |
|
|
|
(0061719)
|
|
hgbot
|
|
2013-10-16 17:38
|
|
Repository: erp/devel/pi
Changeset: 4ee0b6443c3a27bbeb96c334646bb10d00147b65
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Sep 30 11:54:06 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4ee0b6443c3a27bbeb96c334646bb10d00147b65 [^]
fixed bug 24388: 2 property columns referencing same entity do not work
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
|
|
|
|
|
|
|
|
|
|
Code reviewed and verified in pi@eb0f3ecbdae4 |
|