Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0024385
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2013-07-19 13:362013-08-26 10:04
ReportergorkaionView Statuspublic 
Assigned Topramakrishnan 
PrioritynormalResolutionfixedFixed in Version3.0MP27
StatusclosedFix in branchpiFixed in SCM revisionee3b2cbc5d3b
ProjectionnoneETAnoneTarget Version3.0MP27
OSLinux 32 bitDatabaseOracleJava version1.5.0_15
OS VersionGentooDatabase version11gAnt version1.7.0
Product VersionpiSCM revision 
Review Assigned Tojonalegriaesarte
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0024385: Manual discounts are not properly applied in certain cases

DescriptionWhen a discount is applied manually in a Sales Order using the discount field the unit price is not properly calculated.
Steps To Reproduce1. Create a sales order.
2. Insert a line of product with a List Price of 0.75 (Cola de Cereza for example).
3. Ensure that there is not any Promotion or Discount applied. Unit Price remains 0.75.
4. Change the discount to 10%
5. See that calculated unit price is 0.67, when we expect 0.68

(0.75 - 10% = 0.675 rounded to 0.68)
Proposed SolutionSL_Order_Amt.java callout is not rounding properly the discounted base unit price. Line 288. It is rounding in the division prior de subtract.

Fix: Do not round the division and use setScale to the resulting BigDecimal.

Patch supplied.
TagsNo tags attached.
Attached Filespatch file icon discount-round.patch [^] (934 bytes) 2013-07-19 13:36 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00243783.0MP27 closedpramakrishnan Taxes are not correctly calculate in some cases 

-  Notes
(0060512)
hgbot (developer)
2013-08-06 13:37

 Repository: erp/devel/pi
Changeset: ee3b2cbc5d3b82f6979d9b8b23103380060f0e79
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Tue Aug 06 11:24:24 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ee3b2cbc5d3b82f6979d9b8b23103380060f0e79 [^]

Fixes Issue 24385: Manual discounts are not properly applied in certain cases

---
M src/org/openbravo/erpCommon/ad_callouts/SL_Order_Amt.java
---
(0060593)
pramakrishnan (developer)
2013-08-14 15:36

 Reopened to update review assigned to
(0060628)
hudsonbot (developer)
2013-08-16 20:31

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/59a1180e7f4f [^]

Maturity status: Test
(0060761)
jonalegriaesarte (reporter)
2013-08-26 10:04

 Patch is working fine

- Issue History
Date Modified Username Field Change
2013-07-19 13:36 gorkaion New Issue
2013-07-19 13:36 gorkaion Assigned To => dmiguelez
2013-07-19 13:36 gorkaion File Added: discount-round.patch
2013-07-19 13:36 gorkaion Modules => Core
2013-07-19 13:36 gorkaion Triggers an Emergency Pack => No
2013-07-19 13:36 gorkaion Relationship added related to 0024378
2013-08-05 14:01 jonalegriaesarte Assigned To dmiguelez => pramakrishnan
2013-08-05 14:02 jonalegriaesarte Target Version => 3.0MP27
2013-08-06 07:05 pramakrishnan Status new => scheduled
2013-08-06 07:05 pramakrishnan fix_in_branch => pi
2013-08-06 13:37 hgbot Checkin
2013-08-06 13:37 hgbot Note Added: 0060512
2013-08-06 13:37 hgbot Status scheduled => resolved
2013-08-06 13:37 hgbot Resolution open => fixed
2013-08-06 13:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ee3b2cbc5d3b82f6979d9b8b23103380060f0e79 [^]
2013-08-14 15:36 pramakrishnan Note Added: 0060593
2013-08-14 15:36 pramakrishnan Status resolved => new
2013-08-14 15:36 pramakrishnan Resolution fixed => open
2013-08-14 15:36 pramakrishnan Review Assigned To => jonalegriaesarte
2013-08-14 15:36 pramakrishnan fix_in_branch pi =>
2013-08-14 15:36 pramakrishnan Status new => scheduled
2013-08-14 15:36 pramakrishnan fix_in_branch => pi
2013-08-14 15:37 pramakrishnan Status scheduled => resolved
2013-08-14 15:37 pramakrishnan Resolution open => fixed
2013-08-16 20:31 hudsonbot Checkin
2013-08-16 20:31 hudsonbot Note Added: 0060628
2013-08-26 10:04 jonalegriaesarte Note Added: 0060761
2013-08-26 10:04 jonalegriaesarte Status resolved => closed
2013-08-26 10:04 jonalegriaesarte Fixed in Version => 3.0MP27

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker