Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0024385 | Openbravo ERP | 07. Sales management | public | 2013-07-19 13:36 | 2013-08-26 10:04 |
|
| Reporter | gorkaion | |
| Assigned To | pramakrishnan | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | Gentoo |
| Product Version | pi | |
| Target Version | 3.0MP27 | Fixed in Version | 3.0MP27 | |
| Merge Request Status | |
| Review Assigned To | jonalegriaesarte |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0024385: Manual discounts are not properly applied in certain cases |
| Description | When a discount is applied manually in a Sales Order using the discount field the unit price is not properly calculated. |
| Steps To Reproduce | 1. Create a sales order.
2. Insert a line of product with a List Price of 0.75 (Cola de Cereza for example).
3. Ensure that there is not any Promotion or Discount applied. Unit Price remains 0.75.
4. Change the discount to 10%
5. See that calculated unit price is 0.67, when we expect 0.68
(0.75 - 10% = 0.675 rounded to 0.68) |
| Proposed Solution | SL_Order_Amt.java callout is not rounding properly the discounted base unit price. Line 288. It is rounding in the division prior de subtract.
Fix: Do not round the division and use setScale to the resulting BigDecimal.
Patch supplied. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0024378 | 3.0MP27 | closed | pramakrishnan | Taxes are not correctly calculate in some cases |
|
| Attached Files |  discount-round.patch (934) 2013-07-19 13:36
https://issues.openbravo.com/file_download.php?file_id=6278&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2013-07-19 13:36 | gorkaion | New Issue | |
| 2013-07-19 13:36 | gorkaion | Assigned To | => dmiguelez |
| 2013-07-19 13:36 | gorkaion | File Added: discount-round.patch | |
| 2013-07-19 13:36 | gorkaion | Modules | => Core |
| 2013-07-19 13:36 | gorkaion | Triggers an Emergency Pack | => No |
| 2013-07-19 13:36 | gorkaion | Relationship added | related to 0024378 |
| 2013-08-05 14:01 | jonalegriaesarte | Assigned To | dmiguelez => pramakrishnan |
| 2013-08-05 14:02 | jonalegriaesarte | Target Version | => 3.0MP27 |
| 2013-08-06 07:05 | pramakrishnan | Status | new => scheduled |
| 2013-08-06 07:05 | pramakrishnan | fix_in_branch | => pi |
| 2013-08-06 13:37 | hgbot | Checkin | |
| 2013-08-06 13:37 | hgbot | Note Added: 0060512 | |
| 2013-08-06 13:37 | hgbot | Status | scheduled => resolved |
| 2013-08-06 13:37 | hgbot | Resolution | open => fixed |
| 2013-08-06 13:37 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/ee3b2cbc5d3b82f6979d9b8b23103380060f0e79 [^] |
| 2013-08-14 15:36 | pramakrishnan | Note Added: 0060593 | |
| 2013-08-14 15:36 | pramakrishnan | Status | resolved => new |
| 2013-08-14 15:36 | pramakrishnan | Resolution | fixed => open |
| 2013-08-14 15:36 | pramakrishnan | Review Assigned To | => jonalegriaesarte |
| 2013-08-14 15:36 | pramakrishnan | fix_in_branch | pi => |
| 2013-08-14 15:36 | pramakrishnan | Status | new => scheduled |
| 2013-08-14 15:36 | pramakrishnan | fix_in_branch | => pi |
| 2013-08-14 15:37 | pramakrishnan | Status | scheduled => resolved |
| 2013-08-14 15:37 | pramakrishnan | Resolution | open => fixed |
| 2013-08-16 20:31 | hudsonbot | Checkin | |
| 2013-08-16 20:31 | hudsonbot | Note Added: 0060628 | |
| 2013-08-26 10:04 | jonalegriaesarte | Note Added: 0060761 | |
| 2013-08-26 10:04 | jonalegriaesarte | Status | resolved => closed |
| 2013-08-26 10:04 | jonalegriaesarte | Fixed in Version | => 3.0MP27 |