Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0024353

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 07. Sales management

minor

always

2013-07-17 10:35

2013-07-30 13:38

Reporter

caristu

View Status

public

Assigned To

caristu

Priority

high

Resolution

fixed

Fixed in Version

3.0MP26

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0MP26

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

jonalegriaesarte

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0024353: Closing sales order does not adjust associated stock reservation when final quantity is zero

Description

When a sales order is closed, the ordered quantity in the line is set to zero if the line has not been invoiced neither delivered.

If that line have a reservation, the reservation quantity/status will never be updated because the C_ORDER_POST1 procedure only takes into account lines with quantity > 0.

Steps To Reproduce

1- Create a Sales Order with a line
2- Book it
3- Assign a reservation for the line
4- Close the Sales Order
5- Notice that the related reservation has not been updated

Proposed Solution

Modify the C_ORDER_POST1 to take into account those orders with ordered quantity = 0 and also that have an associated reservation

Tags

No tags attached.

order_close_reservation.patch [^] (1,110 bytes) 2013-07-17 10:35 [Show Content] [Hide Content]

diff --git a/src-db/database/model/functions/C_ORDER_POST1.xml b/src-db/database/model/functions/C_ORDER_POST1.xml
--- a/src-db/database/model/functions/C_ORDER_POST1.xml
+++ b/src-db/database/model/functions/C_ORDER_POST1.xml
@@ -1123,10 +1123,16 @@
                 SELECT ol.c_orderline_id, ol.create_reservation, ol.qtyordered
                 FROM c_orderline ol
                     JOIN m_product p ON ol.m_product_id = p.m_product_id
+                    LEFT JOIN m_reservation r ON ol.c_orderline_id = r.c_orderline_id
                 WHERE ol.c_order_id = v_record_id
-                  AND ol.qtyordered > 0
-                  AND p.isstocked = 'Y'
-                  AND p.producttype = 'I'
+                  AND ((
+                      ol.qtyordered > 0
+                      AND p.isstocked = 'Y'
+                      AND p.producttype = 'I'
+                    ) OR (
+                      r.m_reservation_id IS NOT NULL
+                    )
+                  )
             ) LOOP
               SELECT count(*), max(m_reservation_id)
                 INTO v_aux, v_reservation_id

Relationships [ Relation Graph ] [ Dependency Graph ]

related to	defect	0024856	3.0MP29	closed	caristu	Module script is needed for non updated m_reservation quantities
related to	defect	0035270		closed	collazoandy4	Wrong reservation when closing a sales order with a voided partial shipment

Notes
(0060136) hgbot (developer) 2013-07-22 09:47	Repository: erp/devel/pi Changeset: a64da00f56a5f4f14a98dbe0b2a13301de21319e Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Fri Jul 19 08:29:59 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/a64da00f56a5f4f14a98dbe0b2a13301de21319e [^] fixes issue 24353: Closing sales order does not adjust --- M src-db/database/model/functions/C_ORDER_POST1.xml ---

(0060159) hudsonbot (developer) 2013-07-23 05:33	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6a3af4b90642 [^] Maturity status: Test

(0060375) jonalegriaesarte (reporter) 2013-07-30 13:38	Code review done. Functional testing done, using the steps to reproduce.

Issue History
Date Modified	Username	Field	Change
2013-07-17 10:35	caristu	New Issue
2013-07-17 10:35	caristu	Assigned To	=> dmiguelez
2013-07-17 10:35	caristu	File Added: order_close_reservation.patch
2013-07-17 10:35	caristu	Modules	=> Core
2013-07-17 10:35	caristu	Resolution time	=> 1380492000
2013-07-17 10:35	caristu	Triggers an Emergency Pack	=> No
2013-07-17 10:35	caristu	Assigned To	dmiguelez => caristu
2013-07-17 10:35	caristu	Issue Monitored: networkb
2013-07-17 12:43	eintelau	Issue Monitored: eintelau
2013-07-22 09:47	hgbot	Checkin
2013-07-22 09:47	hgbot	Note Added: 0060136
2013-07-22 09:47	hgbot	Status	new => resolved
2013-07-22 09:47	hgbot	Resolution	open => fixed
2013-07-22 09:47	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/a64da00f56a5f4f14a98dbe0b2a13301de21319e [^]
2013-07-23 05:33	hudsonbot	Checkin
2013-07-23 05:33	hudsonbot	Note Added: 0060159
2013-07-30 13:38	jonalegriaesarte	Review Assigned To	=> jonalegriaesarte
2013-07-30 13:38	jonalegriaesarte	Note Added: 0060375
2013-07-30 13:38	jonalegriaesarte	Status	resolved => closed
2013-07-30 13:38	jonalegriaesarte	Fixed in Version	=> 3.0MP26
2013-10-01 10:02	caristu	Relationship added	related to 0024856
2017-03-23 09:30	aferraz	Relationship added	related to 0035270

Copyright © 2000 - 2009 MantisBT Group