Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0024353Openbravo ERP07. Sales managementpublic2013-07-17 10:352013-07-30 13:38
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP26Fixed in Version3.0MP26 
Merge Request Status
Review Assigned Tojonalegriaesarte
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket22406
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0024353: Closing sales order does not adjust associated stock reservation when final quantity is zero
DescriptionWhen a sales order is closed, the ordered quantity in the line is set to zero if the line has not been invoiced neither delivered.

If that line have a reservation, the reservation quantity/status will never be updated because the C_ORDER_POST1 procedure only takes into account lines with quantity > 0.
Steps To Reproduce1- Create a Sales Order with a line
2- Book it
3- Assign a reservation for the line
4- Close the Sales Order
5- Notice that the related reservation has not been updated
Proposed SolutionModify the C_ORDER_POST1 to take into account those orders with ordered quantity = 0 and also that have an associated reservation
Additional Information
TagsNo tags attached.
Relationships
related to defect 00248563.0MP29 closed caristu Module script is needed for non updated m_reservation quantities 
related to defect 0035270 closed collazoandy4 Wrong reservation when closing a sales order with a voided partial shipment 
Attached Filespatch order_close_reservation.patch (1,110) 2013-07-17 10:35
https://issues.openbravo.com/file_download.php?file_id=6266&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-07-17 10:35caristuNew Issue
2013-07-17 10:35caristuAssigned To => dmiguelez
2013-07-17 10:35caristuFile Added: order_close_reservation.patch
2013-07-17 10:35caristuModules => Core
2013-07-17 10:35caristuOBNetwork customer => Yes
2013-07-17 10:35caristuSupport ticket => 22406
2013-07-17 10:35caristuResolution time => 1380492000
2013-07-17 10:35caristuTriggers an Emergency Pack => No
2013-07-17 10:35caristuAssigned Todmiguelez => caristu
2013-07-17 10:35caristuIssue Monitored: networkb
2013-07-17 12:43eintelauIssue Monitored: eintelau
2013-07-22 09:47hgbotCheckin
2013-07-22 09:47hgbotNote Added: 0060136
2013-07-22 09:47hgbotStatusnew => resolved
2013-07-22 09:47hgbotResolutionopen => fixed
2013-07-22 09:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a64da00f56a5f4f14a98dbe0b2a13301de21319e [^]
2013-07-23 05:33hudsonbotCheckin
2013-07-23 05:33hudsonbotNote Added: 0060159
2013-07-30 13:38jonalegriaesarteReview Assigned To => jonalegriaesarte
2013-07-30 13:38jonalegriaesarteNote Added: 0060375
2013-07-30 13:38jonalegriaesarteStatusresolved => closed
2013-07-30 13:38jonalegriaesarteFixed in Version => 3.0MP26
2013-10-01 10:02caristuRelationship addedrelated to 0024856
2017-03-23 09:30aferrazRelationship addedrelated to 0035270

Notes
(0060136)
hgbot   
2013-07-22 09:47   
Repository: erp/devel/pi
Changeset: a64da00f56a5f4f14a98dbe0b2a13301de21319e
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Jul 19 08:29:59 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a64da00f56a5f4f14a98dbe0b2a13301de21319e [^]

fixes issue 24353: Closing sales order does not adjust

---
M src-db/database/model/functions/C_ORDER_POST1.xml
---
(0060159)
hudsonbot   
2013-07-23 05:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6a3af4b90642 [^]

Maturity status: Test
(0060375)
jonalegriaesarte   
2013-07-30 13:38   
Code review done.
Functional testing done, using the steps to reproduce.