Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0024197 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [Openbravo ERP] A. Platform | minor | always | 2013-06-26 13:45 | 2013-07-16 14:26 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0MP26 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 6b684b7d61d6 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP26 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | AugustoMauch | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0024197: Form is not refreshed after executing a business event handler for the Note entity | |||||||
| Description | If we develop a business event handler for the Notes entity, the form is not refreshed. After adding/removing the note, it is necessary to click on the refresh button manually to see the updated information. | |||||||
| Steps To Reproduce | 1) Create a business event handler(http://wiki.openbravo.com/wiki/How_to_implement_a_business_event_handler [^]) for the Note entity (see attached example) 2) After adding a event handler similar to the attached one, create a new note 3) Notice that the data is changed correctly but the form is not showing the changes. It is necessary to click on the refresh button to see the updated information. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  NoteEventHandler.java [^] (1,291 bytes) 2013-06-26 16:12 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0059850) dbaz (developer) 2013-07-03 23:46 |
Changed to 'design deffect', since event handler just manage the database information and is not its function update the UI |
|
(0059851) dbaz (developer) 2013-07-03 23:58 |
In the fix a new feature is going to be added that will add the capability to specify a particular entity for which window a full form refresh will be done once you add/remove any note. The mechanism to specify the entity uses javascript: Entities can be added to the list of 'entities to refresh' by third parties by doing: isc.OBNoteLayout.getPrototype().refreshFormWithEntities.push(theEntityName); Where 'theEntityName' is the string with the name of the entity. If the string 'all' is provided, it will refresh in all windows. Test case: 1) As 'Openbravo Admin' go to 'Business Partner' window: * Add a new note: nothing special happens, the note is added * Delete this created note: nothing special happens, the note is deleted * Change any form field value and then (WITHOUT SAVING): * Add a new note: nothing special happens, the note is added * Delete this created note: nothing special happens, the note is deleted 2) Ensure that the following code is present in the javascript (add a new module containing a file with this code, or use developer tools console to inject it or whatever you want) isc.OBNoteLayout.getPrototype().refreshFormWithEntities.push('BusinessPartner'); Then, as 'Openbravo Admin' go to 'Business Partner' window: * Add a new note: the note is added and then the form is refreshed * Delete this created note: the note is deleted and then the form is refreshed * Change any form field value and then (WITHOUT SAVING): * Add a new note: an error message is shown saying that it is impossible to continue adding the note * Save the form changes * Add a new note: the note is added and then the form is refreshed * Change any form field value and then (WITHOUT SAVING): * Delete this created note: an error message is shown saying that it is impossible to continue deleting the note |
|
(0059852) hgbot (developer) 2013-07-04 00:11 |
Repository: erp/devel/pi Changeset: 6b684b7d61d6c226822670b4b80db4a250019e1e Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Thu Jul 04 00:10:53 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/6b684b7d61d6c226822670b4b80db4a250019e1e [^] Fixed issue 24197: Added capabilities to refresh the form after add or remove a note --- M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-notes.js --- |
|
(0059894) AugustoMauch (administrator) 2013-07-05 13:35 |
Code reviewed and verified in pi@c708a98b9d60 |
|
(0060023) hudsonbot (developer) 2013-07-16 14:26 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a5d5983399f [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-06-26 13:45 | caristu | New Issue | |
| 2013-06-26 13:45 | caristu | Assigned To | => AugustoMauch |
| 2013-06-26 13:45 | caristu | Modules | => Core |
| 2013-06-26 13:45 | caristu | Resolution time | => 1378072800 |
| 2013-06-26 13:45 | caristu | Triggers an Emergency Pack | => No |
| 2013-06-26 13:46 | caristu | Issue Monitored: networkb | |
| 2013-06-26 16:09 | caristu | Summary | Chexbox fields are not updated from business event handler => Grid is not refreshed after executing a business event handler for the Note entity |
| 2013-06-26 16:09 | caristu | Description Updated | View Revisions |
| 2013-06-26 16:09 | caristu | Steps to Reproduce Updated | View Revisions |
| 2013-06-26 16:11 | caristu | Steps to Reproduce Updated | View Revisions |
| 2013-06-26 16:12 | caristu | Steps to Reproduce Updated | View Revisions |
| 2013-06-26 16:12 | caristu | File Added: NoteEventHandler.java | |
| 2013-07-02 17:49 | AugustoMauch | Assigned To | AugustoMauch => dbaz |
| 2013-07-03 18:32 | caristu | Summary | Grid is not refreshed after executing a business event handler for the Note entity => Form is not refreshed after executing a business event handler for the Note entity |
| 2013-07-03 18:32 | caristu | Description Updated | View Revisions |
| 2013-07-03 18:32 | caristu | Steps to Reproduce Updated | View Revisions |
| 2013-07-03 23:46 | dbaz | Note Added: 0059850 | |
| 2013-07-03 23:46 | dbaz | Type | defect => design defect |
| 2013-07-03 23:46 | dbaz | Review Assigned To | => AugustoMauch |
| 2013-07-03 23:58 | dbaz | Note Added: 0059851 | |
| 2013-07-04 00:11 | hgbot | Checkin | |
| 2013-07-04 00:11 | hgbot | Note Added: 0059852 | |
| 2013-07-04 00:11 | hgbot | Status | new => resolved |
| 2013-07-04 00:11 | hgbot | Resolution | open => fixed |
| 2013-07-04 00:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/6b684b7d61d6c226822670b4b80db4a250019e1e [^] |
| 2013-07-05 00:06 | dbaz | Issue Monitored: AugustoMauch | |
| 2013-07-05 13:35 | AugustoMauch | Note Added: 0059894 | |
| 2013-07-05 13:35 | AugustoMauch | Status | resolved => closed |
| 2013-07-05 13:35 | AugustoMauch | Fixed in Version | => 3.0MP26 |
| 2013-07-16 14:26 | hudsonbot | Checkin | |
| 2013-07-16 14:26 | hudsonbot | Note Added: 0060023 | |
| 2014-04-10 11:17 | caristu | Relationship added | related to 0026235 |
| 2015-01-19 09:58 | caristu | Relationship added | related to 0028670 |
| 2016-06-14 19:44 | caristu | Relationship added | related to 0033263 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |