Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0023948
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2013-05-30 17:062013-08-01 17:51
ReporterAugustoMauchView Statuspublic 
Assigned Toshankarb 
PriorityhighResolutionfixedFixed in Version3.0MP26
StatusclosedFix in branchFixed in SCM revision509129b9fd7a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023948: Add sever side security to avoid creating notes on read only tabs

DescriptionThis issue [1] introduced a new feature: Disabling adding notes to a read only tab based on a property.

This limitation was done only on the client side, it should also be done in the server side.

[1] https://issues.openbravo.com/view.php?id=23824 [^]
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0023824 closedshankarb Add the possibility to make the notes on the window read only if the tab is also readonly 

-  Notes
(0060227)
hgbot (developer)
2013-07-24 13:30

Repository: erp/devel/pi
Changeset: 509129b9fd7aaa9e0b297058a3e7db16fb192159
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jul 24 16:45:56 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/509129b9fd7aaa9e0b297058a3e7db16fb192159 [^]

Fixes Issue 0023948: Add sever side security to avoid creating notes on read only tabs

Added an event handler for Notes that will check if notes can be added to the current tab
 by the role based on the preference 'DisableNotesForReadOnlyTabs' value,tab UI pattern and tab access.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java
---
(0060305)
AugustoMauch (administrator)
2013-07-26 13:10

Code reviewed and verified in pi@bf208c0a3b49
(0060311)
hudsonbot (developer)
2013-07-26 20:32

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b9e43ea5aa1b [^]

Maturity status: Test
(0060428)
hgbot (developer)
2013-07-31 15:21

Repository: erp/devel/pi
Changeset: efebcff919ad425e4b320cef7af863b8643fe4dc
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 31 15:20:57 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/efebcff919ad425e4b320cef7af863b8643fe4dc [^]

Related to issue 23948: Method should be private, not be part of the API

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java
---
(0060461)
hudsonbot (developer)
2013-08-01 17:51

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/37aeae33b0c0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-05-30 17:06 AugustoMauch New Issue
2013-05-30 17:06 AugustoMauch Assigned To => shankarb
2013-05-30 17:06 AugustoMauch Modules => Core
2013-05-30 17:06 AugustoMauch Triggers an Emergency Pack => No
2013-05-30 17:06 AugustoMauch Relationship added related to 0023824
2013-07-24 13:10 shankarb Review Assigned To => AugustoMauch
2013-07-24 13:11 shankarb Issue Monitored: AugustoMauch
2013-07-24 13:30 hgbot Checkin
2013-07-24 13:30 hgbot Note Added: 0060227
2013-07-24 13:30 hgbot Status new => resolved
2013-07-24 13:30 hgbot Resolution open => fixed
2013-07-24 13:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/509129b9fd7aaa9e0b297058a3e7db16fb192159 [^]
2013-07-26 13:10 AugustoMauch Note Added: 0060305
2013-07-26 13:10 AugustoMauch Status resolved => closed
2013-07-26 13:10 AugustoMauch Fixed in Version => 3.0MP26
2013-07-26 20:32 hudsonbot Checkin
2013-07-26 20:32 hudsonbot Note Added: 0060311
2013-07-31 15:21 hgbot Checkin
2013-07-31 15:21 hgbot Note Added: 0060428
2013-08-01 17:51 hudsonbot Checkin
2013-08-01 17:51 hudsonbot Note Added: 0060461


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker