Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023948Openbravo ERPA. Platformpublic2013-05-30 17:062013-08-01 17:51
ReporterAugustoMauch 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP26 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023948: Add sever side security to avoid creating notes on read only tabs
DescriptionThis issue [1] introduced a new feature: Disabling adding notes to a read only tab based on a property.

This limitation was done only on the client side, it should also be done in the server side.

[1] https://issues.openbravo.com/view.php?id=23824 [^]
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0023824 closed shankarb Add the possibility to make the notes on the window read only if the tab is also readonly 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-05-30 17:06AugustoMauchNew Issue
2013-05-30 17:06AugustoMauchAssigned To => shankarb
2013-05-30 17:06AugustoMauchModules => Core
2013-05-30 17:06AugustoMauchTriggers an Emergency Pack => No
2013-05-30 17:06AugustoMauchRelationship addedrelated to 0023824
2013-07-24 13:10shankarbReview Assigned To => AugustoMauch
2013-07-24 13:11shankarbIssue Monitored: AugustoMauch
2013-07-24 13:30hgbotCheckin
2013-07-24 13:30hgbotNote Added: 0060227
2013-07-24 13:30hgbotStatusnew => resolved
2013-07-24 13:30hgbotResolutionopen => fixed
2013-07-24 13:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/509129b9fd7aaa9e0b297058a3e7db16fb192159 [^]
2013-07-26 13:10AugustoMauchNote Added: 0060305
2013-07-26 13:10AugustoMauchStatusresolved => closed
2013-07-26 13:10AugustoMauchFixed in Version => 3.0MP26
2013-07-26 20:32hudsonbotCheckin
2013-07-26 20:32hudsonbotNote Added: 0060311
2013-07-31 15:21hgbotCheckin
2013-07-31 15:21hgbotNote Added: 0060428
2013-08-01 17:51hudsonbotCheckin
2013-08-01 17:51hudsonbotNote Added: 0060461

Notes
(0060227)
hgbot   
2013-07-24 13:30   
Repository: erp/devel/pi
Changeset: 509129b9fd7aaa9e0b297058a3e7db16fb192159
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jul 24 16:45:56 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/509129b9fd7aaa9e0b297058a3e7db16fb192159 [^]

Fixes Issue 0023948: Add sever side security to avoid creating notes on read only tabs

Added an event handler for Notes that will check if notes can be added to the current tab
 by the role based on the preference 'DisableNotesForReadOnlyTabs' value,tab UI pattern and tab access.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
A modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java
---
(0060305)
AugustoMauch   
2013-07-26 13:10   
Code reviewed and verified in pi@bf208c0a3b49
(0060311)
hudsonbot   
2013-07-26 20:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b9e43ea5aa1b [^]

Maturity status: Test
(0060428)
hgbot   
2013-07-31 15:21   
Repository: erp/devel/pi
Changeset: efebcff919ad425e4b320cef7af863b8643fe4dc
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 31 15:20:57 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/efebcff919ad425e4b320cef7af863b8643fe4dc [^]

Related to issue 23948: Method should be private, not be part of the API

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/event/NoteEventHandler.java
---
(0060461)
hudsonbot   
2013-08-01 17:51   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/37aeae33b0c0 [^]

Maturity status: Test