Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0023331
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2013-03-18 15:312013-04-16 19:18
ReportereintelauView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version3.0MP23
StatusclosedFix in branchFixed in SCM revision34bd5703caa2
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023331: HttpsUtils sets invalid value with class Boolean into System.properties

Descriptionorg.openbravo.erpCommon.utility.HttpsUtils on line 226 does a call to

System.getProperties().put("proxySet", false);

This put a Boolean value in into the System.Properties which is invalid. Properties should only contain String values.

This can cause ClassCastException if other libraries access the properties expecting a String
Steps To ReproduceCall String test = System.getProperties.get("proxySet")
get ClassCastException
Proposed SolutionChange call to

System.getProperties().put("proxySet", "false");


TagsNo tags attached.
Attached Filesdiff file icon issue23331.diff [^] (650 bytes) 2013-04-03 18:04 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0057811)
hgbot (developer)
2013-04-09 16:31

Repository: erp/devel/pi
Changeset: 34bd5703caa2eb723274080faa5e05d170166b6a
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Apr 09 16:31:11 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/34bd5703caa2eb723274080faa5e05d170166b6a [^]

Fixes issue 23331: Proper value is stored into System.properties

Originally, all the properties of Openbravo.properties are stored as Strings, so when a property is retrieved using the System.getProperties.get(keyValue) method, the user can assume that a String is returned.

The problem described in this issue is that in the HttpsUtils class a boolean property is being stored as boolean (System.getProperties().put("proxySet"), false), when it should be stored as a string (System.getProperties().put("proxySet"), "false");

---
M src/org/openbravo/erpCommon/utility/HttpsUtils.java
---
(0057879)
shankarb (reporter)
2013-04-14 15:19

Code reviewed and tested in pi changest af8bd60362ce
(0057946)
hudsonbot (developer)
2013-04-16 19:18

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8df08bea850d [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-03-18 15:31 eintelau New Issue
2013-03-18 15:31 eintelau Assigned To => AugustoMauch
2013-03-18 15:31 eintelau Modules => Core
2013-03-18 15:31 eintelau Triggers an Emergency Pack => No
2013-04-03 18:04 AugustoMauch Issue Monitored: AugustoMauch
2013-04-03 18:04 AugustoMauch File Added: issue23331.diff
2013-04-03 18:05 AugustoMauch Status new => scheduled
2013-04-03 18:05 AugustoMauch fix_in_branch => pi
2013-04-09 16:20 AugustoMauch Issue Monitored: shankarb
2013-04-09 16:20 AugustoMauch Review Assigned To => shankarb
2013-04-09 16:20 AugustoMauch fix_in_branch pi =>
2013-04-09 16:31 hgbot Checkin
2013-04-09 16:31 hgbot Note Added: 0057811
2013-04-09 16:31 hgbot Status scheduled => resolved
2013-04-09 16:31 hgbot Resolution open => fixed
2013-04-09 16:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/34bd5703caa2eb723274080faa5e05d170166b6a [^]
2013-04-14 15:19 shankarb Note Added: 0057879
2013-04-14 15:19 shankarb Status resolved => closed
2013-04-14 15:19 shankarb Fixed in Version => 3.0MP23
2013-04-16 19:18 hudsonbot Checkin
2013-04-16 19:18 hudsonbot Note Added: 0057946


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker