Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0023331Openbravo ERPA. Platformpublic2013-03-18 15:312013-04-16 19:18
Reportereintelau 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Versionpi 
Target VersionFixed in Version3.0MP23 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0023331: HttpsUtils sets invalid value with class Boolean into System.properties
Descriptionorg.openbravo.erpCommon.utility.HttpsUtils on line 226 does a call to

System.getProperties().put("proxySet", false);

This put a Boolean value in into the System.Properties which is invalid. Properties should only contain String values.

This can cause ClassCastException if other libraries access the properties expecting a String
Steps To ReproduceCall String test = System.getProperties.get("proxySet")
get ClassCastException
Proposed SolutionChange call to

System.getProperties().put("proxySet", "false");


Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue23331.diff (650) 2013-04-03 18:04
https://issues.openbravo.com/file_download.php?file_id=6063&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-03-18 15:31eintelauNew Issue
2013-03-18 15:31eintelauAssigned To => AugustoMauch
2013-03-18 15:31eintelauModules => Core
2013-03-18 15:31eintelauTriggers an Emergency Pack => No
2013-04-03 18:04AugustoMauchIssue Monitored: AugustoMauch
2013-04-03 18:04AugustoMauchFile Added: issue23331.diff
2013-04-03 18:05AugustoMauchStatusnew => scheduled
2013-04-03 18:05AugustoMauchfix_in_branch => pi
2013-04-09 16:20AugustoMauchIssue Monitored: shankarb
2013-04-09 16:20AugustoMauchReview Assigned To => shankarb
2013-04-09 16:20AugustoMauchfix_in_branchpi =>
2013-04-09 16:31hgbotCheckin
2013-04-09 16:31hgbotNote Added: 0057811
2013-04-09 16:31hgbotStatusscheduled => resolved
2013-04-09 16:31hgbotResolutionopen => fixed
2013-04-09 16:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/34bd5703caa2eb723274080faa5e05d170166b6a [^]
2013-04-14 15:19shankarbNote Added: 0057879
2013-04-14 15:19shankarbStatusresolved => closed
2013-04-14 15:19shankarbFixed in Version => 3.0MP23
2013-04-16 19:18hudsonbotCheckin
2013-04-16 19:18hudsonbotNote Added: 0057946

Notes
(0057811)
hgbot   
2013-04-09 16:31   
Repository: erp/devel/pi
Changeset: 34bd5703caa2eb723274080faa5e05d170166b6a
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Apr 09 16:31:11 2013 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/34bd5703caa2eb723274080faa5e05d170166b6a [^]

Fixes issue 23331: Proper value is stored into System.properties

Originally, all the properties of Openbravo.properties are stored as Strings, so when a property is retrieved using the System.getProperties.get(keyValue) method, the user can assume that a String is returned.

The problem described in this issue is that in the HttpsUtils class a boolean property is being stored as boolean (System.getProperties().put("proxySet"), false), when it should be stored as a string (System.getProperties().put("proxySet"), "false");

---
M src/org/openbravo/erpCommon/utility/HttpsUtils.java
---
(0057879)
shankarb   
2013-04-14 15:19   
Code reviewed and tested in pi changest af8bd60362ce
(0057946)
hudsonbot   
2013-04-16 19:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8df08bea850d [^]

Maturity status: Test