Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023211
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformcriticalhave not tried2013-03-04 09:402013-03-17 09:24
ReportermtaalView Statuspublic 
Assigned ToAugustoMauch 
PriorityurgentResolutionfixedFixed in Version3.0MP22
StatusclosedFix in branchFixed in SCM revision47b25b3ec9ab
ProjectionnoneETAnoneTarget Version3.0MP22
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023211: Insert in grid does not work correctly when there are many existing rows

DescriptionWhen the db has more than a 100 records, i.e. when the grid has not loaded all of them at once then insert-in-grid does not show the new inserted line (to-edit) when clicking the insert button in the top.
Steps To ReproduceGoto reference window
Make sure that no record is selected
Click insert-in-grid
You can see the grid scrolling quickly to the new line, but then the grid loads the next batch
Proposed SolutionI think the solution is to not insert the new line at the end of the current loaded set (causing a new load of the next page).
It is better to insert the new line in the current viewport in the top, for example as the second line in the viewport.
TagsNo tags attached.
Attached Files? file icon issue23211.export [^] (1,411 bytes) 2013-03-06 13:42

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0022047 closedAugustoMauch [Reliability] when we have few hundred records, then i grid view when we create new record user not able to enter details 
has duplicate defect 0023429 closedAugustoMauch New record does not work correctly when there are more than 100 records in the grid 

-  Notes
(0057101)
rgoris (developer)
2013-03-06 14:56
edited on: 2013-03-06 16:06

 As discussed with Augusto, we will fix it as follows:
1) In grid view, Insert Row, when nothing is selected, will add a row at the bottom of the grid
2) In grid view, Insert Row, when a row is selected, will insert a row directly below the selected row.
3) In grid view, when not all rows are loaded/cached, Insert Row will add a row at the top of the grid
4) In grid view, in case of large grids that are not loaded/cached at once, but the user manages to scroll down till the bottom (so that all rows are eventually loaded), Insert Row will add a row at the bottom.

Note that this issue does not address situations where records are added via form view. The current behaviour is good(enough).
(0057125)
AugustoMauch (manager)
2013-03-07 12:19

 Test plan:
- Open the Unit of Measure window
- Do not select any record and click the Insert Row button. The record should be added in the last position of the grid.

- Open the Country and Region window
- Do not select any record and click the Insert Row button. The record should be added in the first position.

- Open the Country and Region window
- Select a record and click the Insert Row button. The record should be added below the selected record

- Open the Country and Region window
- Enter a filter in the name column: "island". Do not select any record and click the Insert Row button. The record should be added in the last position.
(0057126)
hgbot (developer)
2013-03-07 12:20

 Repository: erp/devel/pi
Changeset: 47b25b3ec9ab06d7c7eba76cbbcdb7e71be782a2
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Mar 06 13:41:48 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/47b25b3ec9ab06d7c7eba76cbbcdb7e71be782a2 [^]

Fixes issue 23211: Fixes adding rows in a grid with many existing rows

The behaviour of the addition of rows in the grid now mimics the behavior of the creation of records in the form view:
- If not all records are cached in the grid, the record is added in the first position
- If all records are cached in the grid, the record is added in the last position.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
---
(0057281)
shankarb (reporter)
2013-03-17 09:24

 Code reviewed and tested in pi changeset c1cf111b6a22

- Issue History
Date Modified Username Field Change
2013-03-04 09:40 mtaal New Issue
2013-03-04 09:40 mtaal Assigned To => AugustoMauch
2013-03-04 09:40 mtaal Modules => Core
2013-03-04 09:40 mtaal Triggers an Emergency Pack => No
2013-03-04 13:13 AugustoMauch Target Version 3.0MP21 => 3.0MP22
2013-03-05 17:40 AugustoMauch Relationship added has duplicate 0022047
2013-03-06 13:42 AugustoMauch File Added: issue23211.export
2013-03-06 13:42 AugustoMauch Status new => scheduled
2013-03-06 13:42 AugustoMauch fix_in_branch => pi
2013-03-06 14:56 rgoris Note Added: 0057101
2013-03-06 16:06 rgoris Note Edited: 0057101 View Revisions
2013-03-07 12:17 AugustoMauch Issue Monitored: shankarb
2013-03-07 12:17 AugustoMauch Review Assigned To => shankarb
2013-03-07 12:17 AugustoMauch fix_in_branch pi =>
2013-03-07 12:19 AugustoMauch Note Added: 0057125
2013-03-07 12:20 hgbot Checkin
2013-03-07 12:20 hgbot Note Added: 0057126
2013-03-07 12:20 hgbot Status scheduled => resolved
2013-03-07 12:20 hgbot Resolution open => fixed
2013-03-07 12:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/47b25b3ec9ab06d7c7eba76cbbcdb7e71be782a2 [^]
2013-03-17 09:24 shankarb Note Added: 0057281
2013-03-17 09:24 shankarb Status resolved => closed
2013-03-17 09:24 shankarb Fixed in Version => 3.0MP22
2013-03-28 23:26 AugustoMauch Relationship added has duplicate 0023429

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker