Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0022912 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] B. User interface | major | always | 2013-01-28 16:04 | 2013-03-20 17:11 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | shankarb | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | 3.0MP22 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 797f69e6a899 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP22 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | AugustoMauch | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0022912: Where clause is not applied into the tree view | |||||||
| Description | The SQL/HQL where clauses are not taken into account in the tree view. The results displayed in the tree view window are not filtered. | |||||||
| Steps To Reproduce | 1) As system admin role, go to the [Windows, Tabs and Fields] window 2) Select the Product Category record 3) In the Product Category Tab, add a filter clause in the HQL Where Clause field, for example id = 'productcategoryid' 4) Rebuild the system 5) Log in again as group admin role, and go to the [Product Category] window. Check that in grid view the filter has been applied successfully. 6) Click in the Tree View button of the toolbar. All product category are displayed. The filter hasn't been applied. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0056115) shankarb (reporter) 2013-02-04 04:34 |
Fix ready to be pushed in MP21 |
|
(0056320) shankarb (reporter) 2013-02-11 12:11 |
Suppose that the tree is filtered and it displays a node say A. But A is the child of B. If B is not displayed then A will not be displayed. Need clarification on whether this approach is correct or should we display the natural tree of the node. |
|
(0056789) caristu (developer) 2013-02-26 18:59 |
Moved to MP22 as a deeply analysis was required. The proposed solution is to show the hole tree (don't apply the filter), but avoid to navigate to those records that are filtered when we click on its corresponding node (or make that nodes non-clickable) |
|
(0057172) hgbot (developer) 2013-03-11 10:45 |
Repository: erp/devel/pi Changeset: 92b8154e3726764571c785d7ed319b66cb8b4d50 Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Mon Mar 11 15:14:04 2013 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/92b8154e3726764571c785d7ed319b66cb8b4d50 [^] Fixes Issue 0022912: Where clause is not applied into the tree view The tree shows all the data as before, but click action is disabled for the filtered records. --- M src/org/openbravo/erpCommon/utility/WindowTree.java M src/org/openbravo/erpCommon/utility/WindowTreeUtility.java --- |
|
(0057277) hgbot (developer) 2013-03-17 08:42 |
Repository: erp/devel/pi Changeset: c1cf111b6a221fbd5fd0b6113603d63b17d083dc Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Sun Mar 17 13:12:12 2013 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/c1cf111b6a221fbd5fd0b6113603d63b17d083dc [^] Related to Issue 22912 : Applying code review changes --- M src/org/openbravo/erpCommon/utility/WindowTree.java --- |
|
(0057291) AugustoMauch (manager) 2013-03-18 10:55 |
The same comparation is being done twice [1] [2], the latter is probably not needed. [1] https://code.openbravo.com/erp/devel/pi/rev/c1cf111b6a221fbd5fd0b6113603d63b17d083dc#l1.40 [^] [2] https://code.openbravo.com/erp/devel/pi/rev/c1cf111b6a221fbd5fd0b6113603d63b17d083dc#l1.41 [^] |
|
(0057298) hgbot (developer) 2013-03-18 12:50 |
Repository: erp/devel/pi Changeset: 797f69e6a899c12da183a16692453fc0bd1f7d7e Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Mon Mar 18 16:15:42 2013 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/797f69e6a899c12da183a16692453fc0bd1f7d7e [^] Fixes Issue 22912 : Where clause is not applied in tree view Code Refactoring and applying code review changes. --- M src/org/openbravo/erpCommon/utility/WindowTree.java --- |
|
(0057336) AugustoMauch (manager) 2013-03-20 17:11 |
Code reviewed and verified in pi@cc6111e9a6a9 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-01-28 16:04 | caristu | New Issue | |
| 2013-01-28 16:04 | caristu | Assigned To | => dbaz |
| 2013-01-28 16:04 | caristu | Modules | => Core |
| 2013-01-28 16:04 | caristu | Resolution time | => 1361919600 |
| 2013-01-28 16:04 | caristu | Triggers an Emergency Pack | => No |
| 2013-01-28 16:04 | caristu | Issue Monitored: networkb | |
| 2013-01-28 16:06 | dbaz | Assigned To | dbaz => AugustoMauch |
| 2013-01-28 16:06 | caristu | version | => pi |
| 2013-02-03 08:15 | shankarb | Assigned To | AugustoMauch => shankarb |
| 2013-02-04 04:34 | shankarb | Status | new => scheduled |
| 2013-02-04 04:34 | shankarb | Note Added: 0056115 | |
| 2013-02-04 04:34 | shankarb | fix_in_branch | => pi |
| 2013-02-06 07:50 | shankarb | File Added: Issue22912.diff | |
| 2013-02-11 12:11 | shankarb | Note Added: 0056320 | |
| 2013-02-11 12:11 | shankarb | Status | scheduled => feedback |
| 2013-02-26 18:40 | caristu | Target Version | 3.0MP21 => 3.0MP22 |
| 2013-02-26 18:40 | caristu | fix_in_branch | pi => |
| 2013-02-26 18:59 | caristu | Note Added: 0056789 | |
| 2013-03-11 10:10 | shankarb | Status | feedback => scheduled |
| 2013-03-11 10:10 | shankarb | fix_in_branch | => pi |
| 2013-03-11 10:34 | shankarb | File Deleted: Issue22912.diff | |
| 2013-03-11 10:44 | shankarb | Review Assigned To | => AugustoMauch |
| 2013-03-11 10:44 | shankarb | fix_in_branch | pi => |
| 2013-03-11 10:44 | shankarb | Issue Monitored: AugustoMauch | |
| 2013-03-11 10:45 | hgbot | Checkin | |
| 2013-03-11 10:45 | hgbot | Note Added: 0057172 | |
| 2013-03-11 10:45 | hgbot | Status | scheduled => resolved |
| 2013-03-11 10:45 | hgbot | Resolution | open => fixed |
| 2013-03-11 10:45 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/92b8154e3726764571c785d7ed319b66cb8b4d50 [^] |
| 2013-03-17 08:42 | hgbot | Checkin | |
| 2013-03-17 08:42 | hgbot | Note Added: 0057277 | |
| 2013-03-18 10:55 | AugustoMauch | Note Added: 0057291 | |
| 2013-03-18 10:55 | AugustoMauch | Status | resolved => new |
| 2013-03-18 10:55 | AugustoMauch | Resolution | fixed => open |
| 2013-03-18 12:50 | hgbot | Checkin | |
| 2013-03-18 12:50 | hgbot | Note Added: 0057298 | |
| 2013-03-18 12:50 | hgbot | Status | new => resolved |
| 2013-03-18 12:50 | hgbot | Resolution | open => fixed |
| 2013-03-18 12:50 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/92b8154e3726764571c785d7ed319b66cb8b4d50 [^] => http://code.openbravo.com/erp/devel/pi/rev/797f69e6a899c12da183a16692453fc0bd1f7d7e [^] |
| 2013-03-20 17:11 | AugustoMauch | Note Added: 0057336 | |
| 2013-03-20 17:11 | AugustoMauch | Status | resolved => closed |
| 2013-03-20 17:11 | AugustoMauch | Fixed in Version | => 3.0MP22 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |