Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022912Openbravo ERPB. User interfacepublic2013-01-28 16:042013-03-20 17:11
Reportercaristu 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP22Fixed in Version3.0MP22 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket19185
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022912: Where clause is not applied into the tree view
DescriptionThe SQL/HQL where clauses are not taken into account in the tree view. The results displayed in the tree view window are not filtered.
Steps To Reproduce1) As system admin role, go to the [Windows, Tabs and Fields] window
2) Select the Product Category record
3) In the Product Category Tab, add a filter clause in the HQL Where Clause field, for example id = 'productcategoryid'
4) Rebuild the system
5) Log in again as group admin role, and go to the [Product Category] window. Check that in grid view the filter has been applied successfully.
6) Click in the Tree View button of the toolbar. All product category are displayed. The filter hasn't been applied.
 
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2013-01-28 16:04caristuNew Issue
2013-01-28 16:04caristuAssigned To => dbaz
2013-01-28 16:04caristuModules => Core
2013-01-28 16:04caristuOBNetwork customer => Yes
2013-01-28 16:04caristuSupport ticket => 19185
2013-01-28 16:04caristuResolution time => 1361919600
2013-01-28 16:04caristuTriggers an Emergency Pack => No
2013-01-28 16:04caristuIssue Monitored: networkb
2013-01-28 16:06dbazAssigned Todbaz => AugustoMauch
2013-01-28 16:06caristuversion => pi
2013-02-03 08:15shankarbAssigned ToAugustoMauch => shankarb
2013-02-04 04:34shankarbStatusnew => scheduled
2013-02-04 04:34shankarbNote Added: 0056115
2013-02-04 04:34shankarbfix_in_branch => pi
2013-02-06 07:50shankarbFile Added: Issue22912.diff
2013-02-11 12:11shankarbNote Added: 0056320
2013-02-11 12:11shankarbStatusscheduled => feedback
2013-02-26 18:40caristuTarget Version3.0MP21 => 3.0MP22
2013-02-26 18:40caristufix_in_branchpi =>
2013-02-26 18:59caristuNote Added: 0056789
2013-03-11 10:10shankarbStatusfeedback => scheduled
2013-03-11 10:10shankarbfix_in_branch => pi
2013-03-11 10:34shankarbFile Deleted: Issue22912.diff
2013-03-11 10:44shankarbReview Assigned To => AugustoMauch
2013-03-11 10:44shankarbfix_in_branchpi =>
2013-03-11 10:44shankarbIssue Monitored: AugustoMauch
2013-03-11 10:45hgbotCheckin
2013-03-11 10:45hgbotNote Added: 0057172
2013-03-11 10:45hgbotStatusscheduled => resolved
2013-03-11 10:45hgbotResolutionopen => fixed
2013-03-11 10:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/92b8154e3726764571c785d7ed319b66cb8b4d50 [^]
2013-03-17 08:42hgbotCheckin
2013-03-17 08:42hgbotNote Added: 0057277
2013-03-18 10:55AugustoMauchNote Added: 0057291
2013-03-18 10:55AugustoMauchStatusresolved => new
2013-03-18 10:55AugustoMauchResolutionfixed => open
2013-03-18 12:50hgbotCheckin
2013-03-18 12:50hgbotNote Added: 0057298
2013-03-18 12:50hgbotStatusnew => resolved
2013-03-18 12:50hgbotResolutionopen => fixed
2013-03-18 12:50hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/92b8154e3726764571c785d7ed319b66cb8b4d50 [^] => http://code.openbravo.com/erp/devel/pi/rev/797f69e6a899c12da183a16692453fc0bd1f7d7e [^]
2013-03-20 17:11AugustoMauchNote Added: 0057336
2013-03-20 17:11AugustoMauchStatusresolved => closed
2013-03-20 17:11AugustoMauchFixed in Version => 3.0MP22

Notes
(0056115)
shankarb   
2013-02-04 04:34   
Fix ready to be pushed in MP21
(0056320)
shankarb   
2013-02-11 12:11   
Suppose that the tree is filtered and it displays a node say A. But A is the child of B. If B is not displayed then A will not be displayed. Need clarification on whether this approach is correct or should we display the natural tree of the node.
(0056789)
caristu   
2013-02-26 18:59   
Moved to MP22 as a deeply analysis was required. The proposed solution is to show the hole tree (don't apply the filter), but avoid to navigate to those records that are filtered when we click on its corresponding node (or make that nodes non-clickable)
(0057172)
hgbot   
2013-03-11 10:45   
Repository: erp/devel/pi
Changeset: 92b8154e3726764571c785d7ed319b66cb8b4d50
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Mar 11 15:14:04 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/92b8154e3726764571c785d7ed319b66cb8b4d50 [^]

Fixes Issue 0022912: Where clause is not applied into the tree view

The tree shows all the data as before, but click action is disabled for the filtered records.

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
M src/org/openbravo/erpCommon/utility/WindowTreeUtility.java
---
(0057277)
hgbot   
2013-03-17 08:42   
Repository: erp/devel/pi
Changeset: c1cf111b6a221fbd5fd0b6113603d63b17d083dc
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Sun Mar 17 13:12:12 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/c1cf111b6a221fbd5fd0b6113603d63b17d083dc [^]

Related to Issue 22912 : Applying code review changes

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
---
(0057291)
AugustoMauch   
2013-03-18 10:55   
The same comparation is being done twice [1] [2], the latter is probably not needed.

[1] https://code.openbravo.com/erp/devel/pi/rev/c1cf111b6a221fbd5fd0b6113603d63b17d083dc#l1.40 [^]
[2] https://code.openbravo.com/erp/devel/pi/rev/c1cf111b6a221fbd5fd0b6113603d63b17d083dc#l1.41 [^]
(0057298)
hgbot   
2013-03-18 12:50   
Repository: erp/devel/pi
Changeset: 797f69e6a899c12da183a16692453fc0bd1f7d7e
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Mar 18 16:15:42 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/797f69e6a899c12da183a16692453fc0bd1f7d7e [^]

Fixes Issue 22912 : Where clause is not applied in tree view

Code Refactoring and applying code review changes.

---
M src/org/openbravo/erpCommon/utility/WindowTree.java
---
(0057336)
AugustoMauch   
2013-03-20 17:11   
Code reviewed and verified in pi@cc6111e9a6a9