Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0022821
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2013-01-17 12:132013-02-26 12:59
ReporterngarciaView Statuspublic 
Assigned ToAugustoMauch 
PriorityhighResolutionfixedFixed in Version3.0MP21
StatusclosedFix in branchFixed in SCM revisionafe543a30c97
ProjectionnoneETAnoneTarget Version3.0MP21
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022821: Callout not executed when writing the whole name in a selector

DescriptionCallout not executed when writing the whole name in a selector
Steps To ReproduceAs group admin role:
   Create a Sales Order header
   When adding a line insert the whole name in the Product field and click on another field with the mouse (do not press TAB)
   Save the record
   Check that the value of the UOM, Net Unit Price, Tax... fields has not been changed
TagsNo tags attached.
Attached Filesdiff file icon issue22821.diff [^] (2,050 bytes) 2013-02-05 14:10 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0034200 closedalostale client side callouts are executed twice when picking a value in a selector drop down 

-  Notes
(0056167)
AugustoMauch (manager)
2013-02-05 14:10

A fix for this issue has been attached. It will be pushed to pi once it is unfrozen for MP21 issues.
(0056372)
hgbot (developer)
2013-02-12 12:40

Repository: erp/devel/pi
Changeset: 98421b2454605ceb4c47e1267a1787c74d82e169
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 12 12:38:29 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^]

Fixes issue 22821: Triggers executed after entering full identifier in selector

The problem was that if the full identifier of the selector option was entered and then another field was clicked, the pickValue() method of the selector was not called and the triggers were not executed. This has been fixed by detecting the case where the whole identifier has been entered and if the user blurs out of that field, the setValueFromRecord is executed and the callouts were executed accordingly.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0056373)
AugustoMauch (manager)
2013-02-12 12:46

Test plan:
- Test that the original issue is not reproducible
- Enter the whole identifier, presh tab, and check that only one call to the FormInitializationComponent is done.
(0056511)
AugustoMauch (manager)
2013-02-18 11:46

This issue has been reopened because it causes https://issues.openbravo.com/view.php?id=23081 [^]
(0056512)
hgbot (developer)
2013-02-18 11:48

Repository: erp/devel/pi
Changeset: 1debe4452f1800eb80cd1965aea869ac14e28fdd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 18 11:48:08 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1debe4452f1800eb80cd1965aea869ac14e28fdd [^]

Related to issue 22821, fixes issue 23081. Backouts 22821 fix, it causes 23081

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0056579)
hudsonbot (developer)
2013-02-20 04:50

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056616)
hudsonbot (developer)
2013-02-20 04:50

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056680)
hgbot (developer)
2013-02-21 13:30

Repository: erp/devel/pi
Changeset: afe543a30c9751b3d2dc6d125975aa607ccf36b9
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 21 13:29:49 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/afe543a30c9751b3d2dc6d125975aa607ccf36b9 [^]

Fixes issue 22821: Triggers executed after entering full identifier in selector

This changeset is the same as [1] with one exception, we don't want to set the fullIdentifierEntered property to true when the user selects an option using th
e selector window, because in that case setValueFromRecord has already been executed, so there is no need to do it again in the blur function. This has been f
ixed by not setting the fullIdentifierEntered property if the change event was originated from the setValueFromRecord function.

[1] https://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^]

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0056713)
hudsonbot (developer)
2013-02-22 07:57

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b99c43bfb674 [^]

Maturity status: Test
(0056775)
shankarb (reporter)
2013-02-26 12:59

Code reviewed and tested in pi changeset 059d60b862a4

- Issue History
Date Modified Username Field Change
2013-01-17 12:13 ngarcia New Issue
2013-01-17 12:13 ngarcia Assigned To => AugustoMauch
2013-01-17 12:13 ngarcia Modules => Core
2013-01-17 12:13 ngarcia Resolution time => 1364767200
2013-01-17 12:13 ngarcia Triggers an Emergency Pack => No
2013-01-17 12:14 ngarcia Issue Monitored: networkb
2013-02-05 14:10 AugustoMauch File Added: issue22821.diff
2013-02-05 14:10 AugustoMauch Status new => scheduled
2013-02-05 14:10 AugustoMauch fix_in_branch => pi
2013-02-05 14:10 AugustoMauch Note Added: 0056167
2013-02-12 12:38 AugustoMauch Issue Monitored: shankarb
2013-02-12 12:38 AugustoMauch Review Assigned To => shankarb
2013-02-12 12:38 AugustoMauch fix_in_branch pi =>
2013-02-12 12:40 hgbot Checkin
2013-02-12 12:40 hgbot Note Added: 0056372
2013-02-12 12:40 hgbot Status scheduled => resolved
2013-02-12 12:40 hgbot Resolution open => fixed
2013-02-12 12:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^]
2013-02-12 12:46 AugustoMauch Note Added: 0056373
2013-02-18 11:46 AugustoMauch Note Added: 0056511
2013-02-18 11:46 AugustoMauch Status resolved => new
2013-02-18 11:46 AugustoMauch Resolution fixed => open
2013-02-18 11:48 hgbot Checkin
2013-02-18 11:48 hgbot Note Added: 0056512
2013-02-20 04:50 hudsonbot Checkin
2013-02-20 04:50 hudsonbot Note Added: 0056579
2013-02-20 04:50 hudsonbot Checkin
2013-02-20 04:50 hudsonbot Note Added: 0056616
2013-02-21 13:30 hgbot Checkin
2013-02-21 13:30 hgbot Note Added: 0056680
2013-02-21 13:30 hgbot Status new => resolved
2013-02-21 13:30 hgbot Resolution open => fixed
2013-02-21 13:30 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^] => http://code.openbravo.com/erp/devel/pi/rev/afe543a30c9751b3d2dc6d125975aa607ccf36b9 [^]
2013-02-22 07:57 hudsonbot Checkin
2013-02-22 07:57 hudsonbot Note Added: 0056713
2013-02-26 12:59 shankarb Note Added: 0056775
2013-02-26 12:59 shankarb Status resolved => closed
2013-02-26 12:59 shankarb Fixed in Version => 3.0MP21
2016-10-13 14:50 alostale Relationship added related to 0034200


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker