Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022821Openbravo ERPA. Platformpublic2013-01-17 12:132013-02-26 12:59
Reporterngarcia 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP21Fixed in Version3.0MP21 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022821: Callout not executed when writing the whole name in a selector
DescriptionCallout not executed when writing the whole name in a selector
Steps To ReproduceAs group admin role:
   Create a Sales Order header
   When adding a line insert the whole name in the Product field and click on another field with the mouse (do not press TAB)
   Save the record
   Check that the value of the UOM, Net Unit Price, Tax... fields has not been changed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034200 closed alostale client side callouts are executed twice when picking a value in a selector drop down 
Attached Filesdiff issue22821.diff (2,050) 2013-02-05 14:10
https://issues.openbravo.com/file_download.php?file_id=5935&type=bug
Issue History
Date ModifiedUsernameFieldChange
2013-01-17 12:13ngarciaNew Issue
2013-01-17 12:13ngarciaAssigned To => AugustoMauch
2013-01-17 12:13ngarciaModules => Core
2013-01-17 12:13ngarciaResolution time => 1364767200
2013-01-17 12:13ngarciaTriggers an Emergency Pack => No
2013-01-17 12:14ngarciaIssue Monitored: networkb
2013-02-05 14:10AugustoMauchFile Added: issue22821.diff
2013-02-05 14:10AugustoMauchStatusnew => scheduled
2013-02-05 14:10AugustoMauchfix_in_branch => pi
2013-02-05 14:10AugustoMauchNote Added: 0056167
2013-02-12 12:38AugustoMauchIssue Monitored: shankarb
2013-02-12 12:38AugustoMauchReview Assigned To => shankarb
2013-02-12 12:38AugustoMauchfix_in_branchpi =>
2013-02-12 12:40hgbotCheckin
2013-02-12 12:40hgbotNote Added: 0056372
2013-02-12 12:40hgbotStatusscheduled => resolved
2013-02-12 12:40hgbotResolutionopen => fixed
2013-02-12 12:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^]
2013-02-12 12:46AugustoMauchNote Added: 0056373
2013-02-18 11:46AugustoMauchNote Added: 0056511
2013-02-18 11:46AugustoMauchStatusresolved => new
2013-02-18 11:46AugustoMauchResolutionfixed => open
2013-02-18 11:48hgbotCheckin
2013-02-18 11:48hgbotNote Added: 0056512
2013-02-20 04:50hudsonbotCheckin
2013-02-20 04:50hudsonbotNote Added: 0056579
2013-02-20 04:50hudsonbotCheckin
2013-02-20 04:50hudsonbotNote Added: 0056616
2013-02-21 13:30hgbotCheckin
2013-02-21 13:30hgbotNote Added: 0056680
2013-02-21 13:30hgbotStatusnew => resolved
2013-02-21 13:30hgbotResolutionopen => fixed
2013-02-21 13:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^] => http://code.openbravo.com/erp/devel/pi/rev/afe543a30c9751b3d2dc6d125975aa607ccf36b9 [^]
2013-02-22 07:57hudsonbotCheckin
2013-02-22 07:57hudsonbotNote Added: 0056713
2013-02-26 12:59shankarbNote Added: 0056775
2013-02-26 12:59shankarbStatusresolved => closed
2013-02-26 12:59shankarbFixed in Version => 3.0MP21
2016-10-13 14:50alostaleRelationship addedrelated to 0034200

Notes
(0056167)
AugustoMauch   
2013-02-05 14:10   
A fix for this issue has been attached. It will be pushed to pi once it is unfrozen for MP21 issues.
(0056372)
hgbot   
2013-02-12 12:40   
Repository: erp/devel/pi
Changeset: 98421b2454605ceb4c47e1267a1787c74d82e169
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 12 12:38:29 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^]

Fixes issue 22821: Triggers executed after entering full identifier in selector

The problem was that if the full identifier of the selector option was entered and then another field was clicked, the pickValue() method of the selector was not called and the triggers were not executed. This has been fixed by detecting the case where the whole identifier has been entered and if the user blurs out of that field, the setValueFromRecord is executed and the callouts were executed accordingly.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0056373)
AugustoMauch   
2013-02-12 12:46   
Test plan:
- Test that the original issue is not reproducible
- Enter the whole identifier, presh tab, and check that only one call to the FormInitializationComponent is done.
(0056511)
AugustoMauch   
2013-02-18 11:46   
This issue has been reopened because it causes https://issues.openbravo.com/view.php?id=23081 [^]
(0056512)
hgbot   
2013-02-18 11:48   
Repository: erp/devel/pi
Changeset: 1debe4452f1800eb80cd1965aea869ac14e28fdd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 18 11:48:08 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1debe4452f1800eb80cd1965aea869ac14e28fdd [^]

Related to issue 22821, fixes issue 23081. Backouts 22821 fix, it causes 23081

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0056579)
hudsonbot   
2013-02-20 04:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056616)
hudsonbot   
2013-02-20 04:50   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d828167a9e83 [^]

Maturity status: Test
(0056680)
hgbot   
2013-02-21 13:30   
Repository: erp/devel/pi
Changeset: afe543a30c9751b3d2dc6d125975aa607ccf36b9
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 21 13:29:49 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/afe543a30c9751b3d2dc6d125975aa607ccf36b9 [^]

Fixes issue 22821: Triggers executed after entering full identifier in selector

This changeset is the same as [1] with one exception, we don't want to set the fullIdentifierEntered property to true when the user selects an option using th
e selector window, because in that case setValueFromRecord has already been executed, so there is no need to do it again in the blur function. This has been f
ixed by not setting the fullIdentifierEntered property if the change event was originated from the setValueFromRecord function.

[1] https://code.openbravo.com/erp/devel/pi/rev/98421b2454605ceb4c47e1267a1787c74d82e169 [^]

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0056713)
hudsonbot   
2013-02-22 07:57   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b99c43bfb674 [^]

Maturity status: Test
(0056775)
shankarb   
2013-02-26 12:59   
Code reviewed and tested in pi changeset 059d60b862a4