Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0022775 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | minor | have not tried | 2013-01-11 09:47 | 2013-02-18 08:31 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0MP20 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d1f03c7e6e5e | ||||
| Projection | none | ETA | none | Target Version | 3.0MP20 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | alostale | |||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0022775: To strict check/failure on column field length | |||||||
| Description | When you accidentally enter string/list column with a length of 0 and restart the system, then an exception is thrown at startup. It is not possible to access the application anymore. I think this is too strict, a warning/error should be logged but not thrown. | |||||||
| Steps To Reproduce | Enter a column with field length 0 restart the system you get exceptions at startup in the console | |||||||
| Proposed Solution | Change these lines (line 61) in the StringPropertyValidator: Check.isTrue(getProperty().getFieldLength() > 0, "Fieldlength should be larger than 0 for validation"); to logging an error instead of throwing an exception | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Selection_010.png [^] (32,116 bytes) 2013-01-11 09:47
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0055617) hgbot (developer) 2013-01-18 17:18 |
Repository: erp/devel/pi Changeset: d1f03c7e6e5e7900c9c441452c8cc8646b33ed25 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Jan 18 17:17:13 2013 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/d1f03c7e6e5e7900c9c441452c8cc8646b33ed25 [^] Fixes issue 22775: Only log an error when a field length is 0 There is no need to throw an exception when the length of a field is 0, it is enough to log an error. --- M src/org/openbravo/base/validation/StringPropertyValidator.java --- |
|
(0055619) AugustoMauch (administrator) 2013-01-18 17:20 |
Test plan: - Set the length of the M_INOUT -> DeliveryRule to 0, and restart tomcat. - Check that an error is logged, but that it is possible to access the application |
|
(0055723) hudsonbot (viewer) 2013-01-22 15:33 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^] Maturity status: Test |
|
(0056504) alostale (viewer) 2013-02-18 08:31 |
code reviewed and tested on pi@5d1365a1b222 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-01-11 09:47 | mtaal | New Issue | |
| 2013-01-11 09:47 | mtaal | Assigned To | => AugustoMauch |
| 2013-01-11 09:47 | mtaal | File Added: Selection_010.png | |
| 2013-01-11 09:47 | mtaal | Modules | => Core |
| 2013-01-11 09:47 | mtaal | OBNetwork customer | => No |
| 2013-01-11 09:47 | mtaal | Triggers an Emergency Pack | => No |
| 2013-01-14 10:19 | AugustoMauch | Status | new => scheduled |
| 2013-01-14 10:19 | AugustoMauch | fix_in_branch | => pi |
| 2013-01-18 17:17 | AugustoMauch | Issue Monitored: mtaal | |
| 2013-01-18 17:17 | AugustoMauch | Review Assigned To | => mtaal |
| 2013-01-18 17:17 | AugustoMauch | fix_in_branch | pi => |
| 2013-01-18 17:18 | hgbot | Checkin | |
| 2013-01-18 17:18 | hgbot | Note Added: 0055617 | |
| 2013-01-18 17:18 | hgbot | Status | scheduled => resolved |
| 2013-01-18 17:18 | hgbot | Resolution | open => fixed |
| 2013-01-18 17:18 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d1f03c7e6e5e7900c9c441452c8cc8646b33ed25 [^] |
| 2013-01-18 17:20 | AugustoMauch | Note Added: 0055619 | |
| 2013-01-22 15:33 | hudsonbot | Checkin | |
| 2013-01-22 15:33 | hudsonbot | Note Added: 0055723 | |
| 2013-02-15 13:52 | AugustoMauch | Issue Monitored: alostale | |
| 2013-02-15 13:54 | AugustoMauch | Review Assigned To | mtaal => alostale |
| 2013-02-18 08:31 | alostale | Note Added: 0056504 | |
| 2013-02-18 08:31 | alostale | Status | resolved => closed |
| 2013-02-18 08:31 | alostale | Fixed in Version | => 3.0MP20 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |