Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022775Openbravo ERPA. Platformpublic2013-01-11 09:472013-02-18 08:31
Reportermtaal 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP20Fixed in Version3.0MP20 
Merge Request Status
Review Assigned Toalostale
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022775: To strict check/failure on column field length
DescriptionWhen you accidentally enter string/list column with a length of 0 and restart the system, then an exception is thrown at startup. It is not possible to access the application anymore.

I think this is too strict, a warning/error should be logged but not thrown.
Steps To ReproduceEnter a column with field length 0
restart the system
you get exceptions at startup in the console
Proposed SolutionChange these lines (line 61) in the StringPropertyValidator:
     Check.isTrue(getProperty().getFieldLength() > 0,
     "Fieldlength should be larger than 0 for validation");

to logging an error instead of throwing an exception

Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Selection_010.png (32,116) 2013-01-11 09:47
https://issues.openbravo.com/file_download.php?file_id=5886&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2013-01-11 09:47mtaalNew Issue
2013-01-11 09:47mtaalAssigned To => AugustoMauch
2013-01-11 09:47mtaalFile Added: Selection_010.png
2013-01-11 09:47mtaalModules => Core
2013-01-11 09:47mtaalTriggers an Emergency Pack => No
2013-01-14 10:19AugustoMauchStatusnew => scheduled
2013-01-14 10:19AugustoMauchfix_in_branch => pi
2013-01-18 17:17AugustoMauchIssue Monitored: mtaal
2013-01-18 17:17AugustoMauchReview Assigned To => mtaal
2013-01-18 17:17AugustoMauchfix_in_branchpi =>
2013-01-18 17:18hgbotCheckin
2013-01-18 17:18hgbotNote Added: 0055617
2013-01-18 17:18hgbotStatusscheduled => resolved
2013-01-18 17:18hgbotResolutionopen => fixed
2013-01-18 17:18hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d1f03c7e6e5e7900c9c441452c8cc8646b33ed25 [^]
2013-01-18 17:20AugustoMauchNote Added: 0055619
2013-01-22 15:33hudsonbotCheckin
2013-01-22 15:33hudsonbotNote Added: 0055723
2013-02-15 13:52AugustoMauchIssue Monitored: alostale
2013-02-15 13:54AugustoMauchReview Assigned Tomtaal => alostale
2013-02-18 08:31alostaleNote Added: 0056504
2013-02-18 08:31alostaleStatusresolved => closed
2013-02-18 08:31alostaleFixed in Version => 3.0MP20

Notes
(0055617)
hgbot   
2013-01-18 17:18   
Repository: erp/devel/pi
Changeset: d1f03c7e6e5e7900c9c441452c8cc8646b33ed25
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Jan 18 17:17:13 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d1f03c7e6e5e7900c9c441452c8cc8646b33ed25 [^]

Fixes issue 22775: Only log an error when a field length is 0

There is no need to throw an exception when the length of a field is 0, it is enough to log an error.

---
M src/org/openbravo/base/validation/StringPropertyValidator.java
---
(0055619)
AugustoMauch   
2013-01-18 17:20   
Test plan:
- Set the length of the M_INOUT -> DeliveryRule to 0, and restart tomcat.
- Check that an error is logged, but that it is possible to access the application
(0055723)
hudsonbot   
2013-01-22 15:33   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^]

Maturity status: Test
(0056504)
alostale   
2013-02-18 08:31   
code reviewed and tested on pi@5d1365a1b222