Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0022679
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2012-12-27 10:532013-03-20 16:43
ReporterpsarobeView Statuspublic 
Assigned Toshankarb 
PriorityurgentResolutionfixedFixed in Version3.0MP22
StatusclosedFix in branchpiFixed in SCM revision6cfd12f52b4f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022679: "Create fields" button. The way it creates fields by default (grid definition) is not correct

DescriptionThe way this process creates fields is not correct regarding grid definition. It creates by default the field as follows:
- Show in grid= Yes
- Grid position= 0

And it should be like this:
- Show in grid = No
- Grid position = null
Steps To Reproduce1. Login as system administrator role
2. Create a column
3. Move to windows&tabs&fields and create the field using the button "Create fields"

Notice that creates the field like this:
- Show in grid= Yes
- Grid position= 0

This is wrong. Should be:
- Show in grid = No
- Grid position = null
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0022680 closedshankarb Several fields are not properly defined regarding grid definition 
related to defect 0022681 closedshankarb When you create a field without using the button "Create field" the behaviour is different than when using the button 

-  Notes
(0057168)
hgbot (developer)
2013-03-11 04:41

 Repository: erp/devel/pi
Changeset: b2284204cbda4cd2d6e11f82d68e3f47780d2e22
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Mar 11 09:06:47 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/b2284204cbda4cd2d6e11f82d68e3f47780d2e22 [^]

Fixes Issue 0022679: "Create fields" does not show new fields in grid by default.

When a new field is added through "Create Fields", the grid values are following
- Show in grid = Yes
- Grid position = 0

As per the suggested fix in the issue, changed the procedure so that the result is
- Show in grid = No
- Grid position = null

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0057192)
hgbot (developer)
2013-03-12 09:56

 Repository: erp/devel/pi
Changeset: ba642e7ede51038d2739f38dde594a4c168c4ffc
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Mar 12 14:25:11 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ba642e7ede51038d2739f38dde594a4c168c4ffc [^]

Related to Issue 0022679 : Backout changeset b2284204cbda

Backed out the fix for the issue.
If new windows are created with default sequencing, the window cannot be opened because no field is visible in grid.

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0057193)
shankarb (reporter)
2013-03-12 09:56

 Reopening the issue because the issue requires feedback.
(0057194)
shankarb (reporter)
2013-03-12 10:10

 Hi Pablo,
If the "Create Fields" is changed as per the issue, new windows that are created with default sequencing cannot be opened because no field is visible in grid.Is this the expected behavior?
(0057196)
AugustoMauch (manager)
2013-03-12 10:26

 Maybe a good approach would be to show in the grid the columns that are identifiers of the table. That way we ensure that at least one field will be shown in the grid.
(0057314)
AugustoMauch (manager)
2013-03-19 16:43

 After talking to the person who reported the issue, it has been decided that when a field is created it will be shown in grid by default only if the field is based on an identifier column.

This way at least one field of every table will be shown by default.
(0057317)
hgbot (developer)
2013-03-20 08:27

 Repository: erp/devel/pi
Changeset: 6cfd12f52b4fdd42b63bda63843fc04030771404
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Mar 20 12:56:34 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6cfd12f52b4fdd42b63bda63843fc04030771404 [^]

Fixes Issue 22679, Fixes Issue 22681 : Modified behaviour of Create Fields Process

By default only the identifier fields will be shown in the grid when creating using the create fields process.

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0057334)
AugustoMauch (manager)
2013-03-20 16:43

 Code reviewed and verified in pi@cc6111e9a6a9

- Issue History
Date Modified Username Field Change
2012-12-27 10:53 psarobe New Issue
2012-12-27 10:53 psarobe Assigned To => AugustoMauch
2012-12-27 10:53 psarobe Modules => Core
2012-12-27 10:53 psarobe Triggers an Emergency Pack => No
2012-12-27 11:01 psarobe Relationship added related to 0022680
2012-12-27 11:06 psarobe Relationship added related to 0022681
2013-03-11 04:39 shankarb Assigned To AugustoMauch => shankarb
2013-03-11 04:40 shankarb Status new => scheduled
2013-03-11 04:40 shankarb fix_in_branch => pi
2013-03-11 04:40 shankarb Review Assigned To => AugustoMauch
2013-03-11 04:40 shankarb fix_in_branch pi =>
2013-03-11 04:40 shankarb Issue Monitored: AugustoMauch
2013-03-11 04:41 hgbot Checkin
2013-03-11 04:41 hgbot Note Added: 0057168
2013-03-11 04:41 hgbot Status scheduled => resolved
2013-03-11 04:41 hgbot Resolution open => fixed
2013-03-11 04:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b2284204cbda4cd2d6e11f82d68e3f47780d2e22 [^]
2013-03-12 09:56 hgbot Checkin
2013-03-12 09:56 hgbot Note Added: 0057192
2013-03-12 09:56 shankarb Note Added: 0057193
2013-03-12 09:56 shankarb Status resolved => new
2013-03-12 09:56 shankarb Resolution fixed => open
2013-03-12 10:10 shankarb Note Added: 0057194
2013-03-12 10:10 shankarb Assigned To shankarb => psarobe
2013-03-12 10:10 shankarb Status new => feedback
2013-03-12 10:26 AugustoMauch Note Added: 0057196
2013-03-19 16:42 AugustoMauch Assigned To psarobe => shankarb
2013-03-19 16:43 AugustoMauch Note Added: 0057314
2013-03-19 16:43 AugustoMauch Status feedback => new
2013-03-20 06:51 shankarb Status new => scheduled
2013-03-20 06:51 shankarb fix_in_branch => pi
2013-03-20 08:27 hgbot Checkin
2013-03-20 08:27 hgbot Note Added: 0057317
2013-03-20 08:27 hgbot Status scheduled => resolved
2013-03-20 08:27 hgbot Resolution open => fixed
2013-03-20 08:27 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/b2284204cbda4cd2d6e11f82d68e3f47780d2e22 [^] => http://code.openbravo.com/erp/devel/pi/rev/6cfd12f52b4fdd42b63bda63843fc04030771404 [^]
2013-03-20 16:43 AugustoMauch Note Added: 0057334
2013-03-20 16:43 AugustoMauch Status resolved => closed
2013-03-20 16:43 AugustoMauch Fixed in Version => 3.0MP22

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker