Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022679Openbravo ERPA. Platformpublic2012-12-27 10:532013-03-20 16:43
Reporterpsarobe 
Assigned Toshankarb 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP22 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022679: "Create fields" button. The way it creates fields by default (grid definition) is not correct
DescriptionThe way this process creates fields is not correct regarding grid definition. It creates by default the field as follows:
- Show in grid= Yes
- Grid position= 0

And it should be like this:
- Show in grid = No
- Grid position = null
Steps To Reproduce1. Login as system administrator role
2. Create a column
3. Move to windows&tabs&fields and create the field using the button "Create fields"

Notice that creates the field like this:
- Show in grid= Yes
- Grid position= 0

This is wrong. Should be:
- Show in grid = No
- Grid position = null
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0022680 closed shankarb Several fields are not properly defined regarding grid definition 
related to defect 0022681 closed shankarb When you create a field without using the button "Create field" the behaviour is different than when using the button 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-12-27 10:53psarobeNew Issue
2012-12-27 10:53psarobeAssigned To => AugustoMauch
2012-12-27 10:53psarobeModules => Core
2012-12-27 10:53psarobeTriggers an Emergency Pack => No
2012-12-27 11:01psarobeRelationship addedrelated to 0022680
2012-12-27 11:06psarobeRelationship addedrelated to 0022681
2013-03-11 04:39shankarbAssigned ToAugustoMauch => shankarb
2013-03-11 04:40shankarbStatusnew => scheduled
2013-03-11 04:40shankarbfix_in_branch => pi
2013-03-11 04:40shankarbReview Assigned To => AugustoMauch
2013-03-11 04:40shankarbfix_in_branchpi =>
2013-03-11 04:40shankarbIssue Monitored: AugustoMauch
2013-03-11 04:41hgbotCheckin
2013-03-11 04:41hgbotNote Added: 0057168
2013-03-11 04:41hgbotStatusscheduled => resolved
2013-03-11 04:41hgbotResolutionopen => fixed
2013-03-11 04:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b2284204cbda4cd2d6e11f82d68e3f47780d2e22 [^]
2013-03-12 09:56hgbotCheckin
2013-03-12 09:56hgbotNote Added: 0057192
2013-03-12 09:56shankarbNote Added: 0057193
2013-03-12 09:56shankarbStatusresolved => new
2013-03-12 09:56shankarbResolutionfixed => open
2013-03-12 10:10shankarbNote Added: 0057194
2013-03-12 10:10shankarbAssigned Toshankarb => psarobe
2013-03-12 10:10shankarbStatusnew => feedback
2013-03-12 10:26AugustoMauchNote Added: 0057196
2013-03-19 16:42AugustoMauchAssigned Topsarobe => shankarb
2013-03-19 16:43AugustoMauchNote Added: 0057314
2013-03-19 16:43AugustoMauchStatusfeedback => new
2013-03-20 06:51shankarbStatusnew => scheduled
2013-03-20 06:51shankarbfix_in_branch => pi
2013-03-20 08:27hgbotCheckin
2013-03-20 08:27hgbotNote Added: 0057317
2013-03-20 08:27hgbotStatusscheduled => resolved
2013-03-20 08:27hgbotResolutionopen => fixed
2013-03-20 08:27hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b2284204cbda4cd2d6e11f82d68e3f47780d2e22 [^] => http://code.openbravo.com/erp/devel/pi/rev/6cfd12f52b4fdd42b63bda63843fc04030771404 [^]
2013-03-20 16:43AugustoMauchNote Added: 0057334
2013-03-20 16:43AugustoMauchStatusresolved => closed
2013-03-20 16:43AugustoMauchFixed in Version => 3.0MP22

Notes
(0057168)
hgbot   
2013-03-11 04:41   
Repository: erp/devel/pi
Changeset: b2284204cbda4cd2d6e11f82d68e3f47780d2e22
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Mon Mar 11 09:06:47 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/b2284204cbda4cd2d6e11f82d68e3f47780d2e22 [^]

Fixes Issue 0022679: "Create fields" does not show new fields in grid by default.

When a new field is added through "Create Fields", the grid values are following
- Show in grid = Yes
- Grid position = 0

As per the suggested fix in the issue, changed the procedure so that the result is
- Show in grid = No
- Grid position = null

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0057192)
hgbot   
2013-03-12 09:56   
Repository: erp/devel/pi
Changeset: ba642e7ede51038d2739f38dde594a4c168c4ffc
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Tue Mar 12 14:25:11 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/ba642e7ede51038d2739f38dde594a4c168c4ffc [^]

Related to Issue 0022679 : Backout changeset b2284204cbda

Backed out the fix for the issue.
If new windows are created with default sequencing, the window cannot be opened because no field is visible in grid.

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0057193)
shankarb   
2013-03-12 09:56   
Reopening the issue because the issue requires feedback.
(0057194)
shankarb   
2013-03-12 10:10   
Hi Pablo,
If the "Create Fields" is changed as per the issue, new windows that are created with default sequencing cannot be opened because no field is visible in grid.Is this the expected behavior?
(0057196)
AugustoMauch   
2013-03-12 10:26   
Maybe a good approach would be to show in the grid the columns that are identifiers of the table. That way we ensure that at least one field will be shown in the grid.
(0057314)
AugustoMauch   
2013-03-19 16:43   
After talking to the person who reported the issue, it has been decided that when a field is created it will be shown in grid by default only if the field is based on an identifier column.

This way at least one field of every table will be shown by default.
(0057317)
hgbot   
2013-03-20 08:27   
Repository: erp/devel/pi
Changeset: 6cfd12f52b4fdd42b63bda63843fc04030771404
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Mar 20 12:56:34 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/6cfd12f52b4fdd42b63bda63843fc04030771404 [^]

Fixes Issue 22679, Fixes Issue 22681 : Modified behaviour of Create Fields Process

By default only the identifier fields will be shown in the grid when creating using the create fields process.

---
M src-db/database/model/functions/AD_TAB_IMPORT.xml
---
(0057334)
AugustoMauch   
2013-03-20 16:43   
Code reviewed and verified in pi@cc6111e9a6a9