Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0022423
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2012-11-28 18:212013-01-22 15:32
ReporterVictorVillarView Statuspublic 
Assigned Toshankarb 
PriorityhighResolutionfixedFixed in Version3.0MP20
StatusclosedFix in branchFixed in SCM revisionf7418ea442bd
ProjectionnoneETAnoneTarget Version3.0MP20
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket18180
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022423: Wrong focus after CTRL+D keyboard shortcut

DescriptionWrong focus after CTRL+D keyboard shortcut
Steps To ReproduceGo to user window:

create a new register in form view

fill the name
 tab key + tab key...till the password
Fill it and CTRL + S to save the record
CTRL + D

Second register:
fill the name
 tab key + tab key...till the password
CTRL + D. Realise that the new register opened, the focus is in the password field
TagsNo tags attached.
Attached Filesdiff file icon FixIssue22423.diff [^] (1,362 bytes) 2013-01-16 08:11 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0055533)
hgbot (developer)
2013-01-16 10:41

 Repository: erp/devel/pi
Changeset: 6eadb3e8bd45f9177a7fd1feae399193d399d277
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jan 16 07:10:53 2013 +0000
URL: http://code.openbravo.com/erp/devel/pi/rev/6eadb3e8bd45f9177a7fd1feae399193d399d277 [^]

Fixes Issue 0022423: Wrong focus after CTRL+D keyboard shortcut

When navigating across records, the last selected field needs to be focussed.
But this case need not apply for new records. Added additional constraint to achieve the same.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0055573)
AugustoMauch (administrator)
2013-01-17 16:34

 I agree, when a new record is created the record should go to the first focused field, that is more useful than leaving the focus in the field that was focused before creating the new record.
(0055574)
AugustoMauch (administrator)
2013-01-17 16:54

 Replace this.view.viewForm.isNewRecord() with this.isNewRecord()
(0055587)
hgbot (developer)
2013-01-18 04:17

 Repository: erp/devel/pi
Changeset: f7418ea442bd20925edea2c935c30d04c21a8829
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Fri Jan 18 08:40:09 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f7418ea442bd20925edea2c935c30d04c21a8829 [^]

Fixes Issue 0022423: Wrong focus after CTRL+D keyboard shortcut

Code refactoring

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0055595)
AugustoMauch (administrator)
2013-01-18 09:47

 Code reviewed and verified in pi@79162c26cf1a
(0055629)
hudsonbot (viewer)
2013-01-18 20:26

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cd4a6cc38e0 [^]

Maturity status: Test
(0055711)
hudsonbot (viewer)
2013-01-22 15:32

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-11-28 18:21 VictorVillar New Issue
2012-11-28 18:21 VictorVillar Assigned To => dmiguelez
2012-11-28 18:21 VictorVillar Modules => Core
2012-11-28 18:21 VictorVillar OBNetwork customer => Yes
2012-11-28 18:21 VictorVillar Support ticket => 18180
2012-11-28 18:21 VictorVillar Resolution time => 1328914800
2012-11-28 18:21 VictorVillar Issue Monitored: networkb
2012-12-10 09:51 dmiguelez Assigned To dmiguelez => dbaz
2012-12-10 13:27 dbaz Assigned To dbaz => AugustoMauch
2013-01-16 08:09 shankarb Assigned To AugustoMauch => shankarb
2013-01-16 08:11 shankarb File Added: FixIssue22423.diff
2013-01-16 10:39 shankarb Status new => scheduled
2013-01-16 10:39 shankarb fix_in_branch => pi
2013-01-16 10:40 shankarb Review Assigned To => AugustoMauch
2013-01-16 10:40 shankarb Triggers an Emergency Pack => No
2013-01-16 10:40 shankarb fix_in_branch pi =>
2013-01-16 10:40 shankarb Issue Monitored: AugustoMauch
2013-01-16 10:41 hgbot Checkin
2013-01-16 10:41 hgbot Note Added: 0055533
2013-01-16 10:41 hgbot Status scheduled => resolved
2013-01-16 10:41 hgbot Resolution open => fixed
2013-01-16 10:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6eadb3e8bd45f9177a7fd1feae399193d399d277 [^]
2013-01-17 16:34 AugustoMauch Note Added: 0055573
2013-01-17 16:54 AugustoMauch Note Added: 0055574
2013-01-17 16:54 AugustoMauch Status resolved => new
2013-01-17 16:54 AugustoMauch Resolution fixed => open
2013-01-18 04:17 hgbot Checkin
2013-01-18 04:17 hgbot Note Added: 0055587
2013-01-18 04:17 hgbot Status new => resolved
2013-01-18 04:17 hgbot Resolution open => fixed
2013-01-18 04:17 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/6eadb3e8bd45f9177a7fd1feae399193d399d277 [^] => http://code.openbravo.com/erp/devel/pi/rev/f7418ea442bd20925edea2c935c30d04c21a8829 [^]
2013-01-18 09:47 AugustoMauch Note Added: 0055595
2013-01-18 09:47 AugustoMauch Status resolved => closed
2013-01-18 09:47 AugustoMauch Fixed in Version => 3.0MP20
2013-01-18 20:26 hudsonbot Checkin
2013-01-18 20:26 hudsonbot Note Added: 0055629
2013-01-22 15:32 hudsonbot Checkin
2013-01-22 15:32 hudsonbot Note Added: 0055711

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker