Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022423Openbravo ERPZ. Otherspublic2012-11-28 18:212013-01-22 15:32
ReporterVictorVillar 
Assigned Toshankarb 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP20Fixed in Version3.0MP20 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket18180
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022423: Wrong focus after CTRL+D keyboard shortcut
DescriptionWrong focus after CTRL+D keyboard shortcut
Steps To ReproduceGo to user window:

create a new register in form view

fill the name
 tab key + tab key...till the password
Fill it and CTRL + S to save the record
CTRL + D

Second register:
fill the name
 tab key + tab key...till the password
CTRL + D. Realise that the new register opened, the focus is in the password field
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff FixIssue22423.diff (1,362) 2013-01-16 08:11
https://issues.openbravo.com/file_download.php?file_id=5893&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-11-28 18:21VictorVillarNew Issue
2012-11-28 18:21VictorVillarAssigned To => dmiguelez
2012-11-28 18:21VictorVillarModules => Core
2012-11-28 18:21VictorVillarOBNetwork customer => Yes
2012-11-28 18:21VictorVillarSupport ticket => 18180
2012-11-28 18:21VictorVillarResolution time => 1328914800
2012-11-28 18:21VictorVillarIssue Monitored: networkb
2012-12-10 09:51dmiguelezAssigned Todmiguelez => dbaz
2012-12-10 13:27dbazAssigned Todbaz => AugustoMauch
2013-01-16 08:09shankarbAssigned ToAugustoMauch => shankarb
2013-01-16 08:11shankarbFile Added: FixIssue22423.diff
2013-01-16 10:39shankarbStatusnew => scheduled
2013-01-16 10:39shankarbfix_in_branch => pi
2013-01-16 10:40shankarbReview Assigned To => AugustoMauch
2013-01-16 10:40shankarbTriggers an Emergency Pack => No
2013-01-16 10:40shankarbfix_in_branchpi =>
2013-01-16 10:40shankarbIssue Monitored: AugustoMauch
2013-01-16 10:41hgbotCheckin
2013-01-16 10:41hgbotNote Added: 0055533
2013-01-16 10:41hgbotStatusscheduled => resolved
2013-01-16 10:41hgbotResolutionopen => fixed
2013-01-16 10:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6eadb3e8bd45f9177a7fd1feae399193d399d277 [^]
2013-01-17 16:34AugustoMauchNote Added: 0055573
2013-01-17 16:54AugustoMauchNote Added: 0055574
2013-01-17 16:54AugustoMauchStatusresolved => new
2013-01-17 16:54AugustoMauchResolutionfixed => open
2013-01-18 04:17hgbotCheckin
2013-01-18 04:17hgbotNote Added: 0055587
2013-01-18 04:17hgbotStatusnew => resolved
2013-01-18 04:17hgbotResolutionopen => fixed
2013-01-18 04:17hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/6eadb3e8bd45f9177a7fd1feae399193d399d277 [^] => http://code.openbravo.com/erp/devel/pi/rev/f7418ea442bd20925edea2c935c30d04c21a8829 [^]
2013-01-18 09:47AugustoMauchNote Added: 0055595
2013-01-18 09:47AugustoMauchStatusresolved => closed
2013-01-18 09:47AugustoMauchFixed in Version => 3.0MP20
2013-01-18 20:26hudsonbotCheckin
2013-01-18 20:26hudsonbotNote Added: 0055629
2013-01-22 15:32hudsonbotCheckin
2013-01-22 15:32hudsonbotNote Added: 0055711

Notes
(0055533)
hgbot   
2013-01-16 10:41   
Repository: erp/devel/pi
Changeset: 6eadb3e8bd45f9177a7fd1feae399193d399d277
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Jan 16 07:10:53 2013 +0000
URL: http://code.openbravo.com/erp/devel/pi/rev/6eadb3e8bd45f9177a7fd1feae399193d399d277 [^]

Fixes Issue 0022423: Wrong focus after CTRL+D keyboard shortcut

When navigating across records, the last selected field needs to be focussed.
But this case need not apply for new records. Added additional constraint to achieve the same.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0055573)
AugustoMauch   
2013-01-17 16:34   
I agree, when a new record is created the record should go to the first focused field, that is more useful than leaving the focus in the field that was focused before creating the new record.
(0055574)
AugustoMauch   
2013-01-17 16:54   
Replace this.view.viewForm.isNewRecord() with this.isNewRecord()
(0055587)
hgbot   
2013-01-18 04:17   
Repository: erp/devel/pi
Changeset: f7418ea442bd20925edea2c935c30d04c21a8829
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Fri Jan 18 08:40:09 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/f7418ea442bd20925edea2c935c30d04c21a8829 [^]

Fixes Issue 0022423: Wrong focus after CTRL+D keyboard shortcut

Code refactoring

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0055595)
AugustoMauch   
2013-01-18 09:47   
Code reviewed and verified in pi@79162c26cf1a
(0055629)
hudsonbot   
2013-01-18 20:26   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cd4a6cc38e0 [^]

Maturity status: Test
(0055711)
hudsonbot   
2013-01-22 15:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/449aae8be624 [^]

Maturity status: Test