Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0022293
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2012-11-14 11:192013-02-04 18:20
ReporterVictorVillarView Statuspublic 
Assigned Tojecharri 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionf0be705eaf76
ProjectionnoneETAnoneTarget Version3.0MP20
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned ToVictorVillar
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket17873
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0022293: Wrong checking in c_period_trg3 trigger

DescriptionIn some instances, the old F&B data was wrong in Fiscal Calendar || Year || periods.

The calendar is created for one ORg (example: ESpaña) and the Year associated or the Periods are for * Org. Year 2012 is open
because the c_period_trg3 trigger is not filtering by ad_client_id, when you try to create periods for other client year: 2012, this trigger shows that there is an overlap of periods, something not true because is another client.

Steps To ReproduceIn some instances, the old F&B data was wrong in Fiscal Calendar || Year || periods.

The calendar is created for one ORg (example: ESpaña) and the Year associated or the Periods are for * Org. Year 2012 is open
because the c_period_trg3 trigger is not filtering by ad_client_id, when you try to create periods for other client year: 2012, this trigger shows that there is an overlap of periods, something not true because is another client.
Proposed Solutionremove the c_period_trg3 trigger
Add this trigger to the c_yearperiods function before the insert.
For the cases that the period will be inserted or modified manually, it would be necessary to create an eventhandler, with the currently verification of the trigger.
TagsNo tags attached.
Attached Filespng file icon Screenshot-Openbravo - Fiscal Calendar - General - Google Chrome.png [^] (169,447 bytes) 2013-01-03 23:01

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0022919 closedjecharri Automated test regression 
causes defect 0028787 closedvmromanos Impossible to create several calendars for the same organization 

-  Notes
(0055345)
ikedagus (viewer)
2013-01-03 23:03

 I'm pretty sure this is preventing me from creating 2013 periods, this is what I get:
----------------
Error:
Saving failed. The dates period defined is overlapped with another period of an existing year.
----------------

But I don't have any 2013 related periods created anywhere.
I'm running Openbravo 3 Community edition MP17.1
(0055496)
ikedagus (viewer)
2013-01-13 00:23

 Nevermind, the error was fixed after I upgraded from MP17.1 to MP18.2
Thanks.
(0055900)
hgbot (developer)
2013-01-28 11:45

 Repository: erp/devel/pi
Changeset: c915c82a2e1dd73eff7b46e0fd54fa16543b20c0
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 28 11:44:47 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c915c82a2e1dd73eff7b46e0fd54fa16543b20c0 [^]

Fixes issue 22293: Wrong checking in c_period_trg3 trigger

---
M src-db/database/model/functions/C_YEARPERIODS.xml
A src/org/openbravo/Event/PeriodEnventHandler.java
R src-db/database/model/triggers/C_PERIOD_TRG3.xml
---
(0055909)
hgbot (developer)
2013-01-28 13:56

 Repository: erp/devel/pi
Changeset: f0be705eaf76cb5372990d78979be27acbdd1e68
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 28 13:55:25 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f0be705eaf76cb5372990d78979be27acbdd1e68 [^]

Fixes issue 22293: Wrong checking in c_period_trg3 trigger

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/Event/PeriodEnventHandler.java
---
(0055936)
hgbot (developer)
2013-01-29 10:30

 Repository: erp/devel/pi
Changeset: 4326aacab306173f19708dca6e3da8b4540cd260
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Jan 29 10:29:47 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4326aacab306173f19708dca6e3da8b4540cd260 [^]

Fixes issue 22919: Automated test regression, issue 22293

---
M src-db/database/model/functions/C_YEARPERIODS.xml
---
(0055990)
jecharri (viewer)
2013-01-31 09:53

 Test cases:
-steps to reproduce. Verify in an old instance that you can create now periods.
-Create period for different years.
-verify that you you can create periods for different organizations but the same year.

-modify one period and see that you can do if you do not overlap with others periods.
-modify one period and see that you can not do if you overlap another period.
Verify the above conditions when you create or modify a period
(0056067)
hudsonbot (viewer)
2013-02-01 22:28

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056070)
hudsonbot (viewer)
2013-02-01 22:28

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056077)
hudsonbot (viewer)
2013-02-01 22:28

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056139)
VictorVillar (viewer)
2013-02-04 18:20

 Verified

- Issue History
Date Modified Username Field Change
2012-11-14 11:19 VictorVillar New Issue
2012-11-14 11:19 VictorVillar Assigned To => dmiguelez
2012-11-14 11:19 VictorVillar Modules => Core
2012-11-14 11:19 VictorVillar OBNetwork customer => Yes
2012-11-14 11:19 VictorVillar Support ticket => 17873
2012-11-14 11:19 VictorVillar Issue Monitored: networkb
2012-11-14 11:37 dmiguelez Assigned To dmiguelez => jonalegriaesarte
2012-12-04 11:50 jonalegriaesarte Target Version 3.0MP18 => 3.0MP20
2012-12-10 13:56 jonalegriaesarte Triggers an Emergency Pack => No
2012-12-10 13:56 jonalegriaesarte Severity major => minor
2013-01-03 23:02 ikedagus File Added: Screenshot-Openbravo - Fiscal Calendar - General - Google Chrome.png
2013-01-03 23:03 ikedagus Note Added: 0055345
2013-01-03 23:04 ikedagus Issue Monitored: ikedagus
2013-01-13 00:23 ikedagus Note Added: 0055496
2013-01-13 00:24 ikedagus Issue End Monitor: ikedagus
2013-01-24 13:00 jonalegriaesarte Assigned To jonalegriaesarte => jecharri
2013-01-28 11:45 hgbot Checkin
2013-01-28 11:45 hgbot Note Added: 0055900
2013-01-28 11:45 hgbot Status new => resolved
2013-01-28 11:45 hgbot Resolution open => fixed
2013-01-28 11:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c915c82a2e1dd73eff7b46e0fd54fa16543b20c0 [^]
2013-01-28 13:56 hgbot Checkin
2013-01-28 13:56 hgbot Note Added: 0055909
2013-01-28 13:56 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/c915c82a2e1dd73eff7b46e0fd54fa16543b20c0 [^] => http://code.openbravo.com/erp/devel/pi/rev/f0be705eaf76cb5372990d78979be27acbdd1e68 [^]
2013-01-29 10:28 jecharri Relationship added related to 0022919
2013-01-29 10:30 hgbot Checkin
2013-01-29 10:30 hgbot Note Added: 0055936
2013-01-31 09:53 jecharri Note Added: 0055990
2013-02-01 22:28 hudsonbot Checkin
2013-02-01 22:28 hudsonbot Note Added: 0056067
2013-02-01 22:28 hudsonbot Checkin
2013-02-01 22:28 hudsonbot Note Added: 0056070
2013-02-01 22:28 hudsonbot Checkin
2013-02-01 22:28 hudsonbot Note Added: 0056077
2013-02-04 18:20 VictorVillar Review Assigned To => VictorVillar
2013-02-04 18:20 VictorVillar Note Added: 0056139
2013-02-04 18:20 VictorVillar Status resolved => closed
2015-05-07 10:18 vmromanos Relationship added causes 0028787

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker