Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0022293Openbravo ERP09. Financial managementpublic2012-11-14 11:192013-02-04 18:20
ReporterVictorVillar 
Assigned Tojecharri 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP20Fixed in Version 
Merge Request Status
Review Assigned ToVictorVillar
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0022293: Wrong checking in c_period_trg3 trigger
DescriptionIn some instances, the old F&B data was wrong in Fiscal Calendar || Year || periods.

The calendar is created for one ORg (example: ESpaña) and the Year associated or the Periods are for * Org. Year 2012 is open
because the c_period_trg3 trigger is not filtering by ad_client_id, when you try to create periods for other client year: 2012, this trigger shows that there is an overlap of periods, something not true because is another client.

Steps To ReproduceIn some instances, the old F&B data was wrong in Fiscal Calendar || Year || periods.

The calendar is created for one ORg (example: ESpaña) and the Year associated or the Periods are for * Org. Year 2012 is open
because the c_period_trg3 trigger is not filtering by ad_client_id, when you try to create periods for other client year: 2012, this trigger shows that there is an overlap of periods, something not true because is another client.
Proposed Solutionremove the c_period_trg3 trigger
Add this trigger to the c_yearperiods function before the insert.
For the cases that the period will be inserted or modified manually, it would be necessary to create an eventhandler, with the currently verification of the trigger.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0022919 closed jecharri Automated test regression 
causes defect 0028787 closed vmromanos Impossible to create several calendars for the same organization 
Attached Filespng Screenshot-Openbravo - Fiscal Calendar - General - Google Chrome.png (169,447) 2013-01-03 23:01
https://issues.openbravo.com/file_download.php?file_id=5871&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-11-14 11:19VictorVillarNew Issue
2012-11-14 11:19VictorVillarAssigned To => dmiguelez
2012-11-14 11:19VictorVillarModules => Core
2012-11-14 11:19VictorVillarIssue Monitored: networkb
2012-11-14 11:37dmiguelezAssigned Todmiguelez => jonalegriaesarte
2012-12-04 11:50jonalegriaesarteTarget Version3.0MP18 => 3.0MP20
2012-12-10 13:56jonalegriaesarteTriggers an Emergency Pack => No
2012-12-10 13:56jonalegriaesarteSeveritymajor => minor
2013-01-03 23:02ikedagusFile Added: Screenshot-Openbravo - Fiscal Calendar - General - Google Chrome.png
2013-01-03 23:03ikedagusNote Added: 0055345
2013-01-03 23:04ikedagusIssue Monitored: ikedagus
2013-01-13 00:23ikedagusNote Added: 0055496
2013-01-13 00:24ikedagusIssue End Monitor: ikedagus
2013-01-24 13:00jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2013-01-28 11:45hgbotCheckin
2013-01-28 11:45hgbotNote Added: 0055900
2013-01-28 11:45hgbotStatusnew => resolved
2013-01-28 11:45hgbotResolutionopen => fixed
2013-01-28 11:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c915c82a2e1dd73eff7b46e0fd54fa16543b20c0 [^]
2013-01-28 13:56hgbotCheckin
2013-01-28 13:56hgbotNote Added: 0055909
2013-01-28 13:56hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/c915c82a2e1dd73eff7b46e0fd54fa16543b20c0 [^] => http://code.openbravo.com/erp/devel/pi/rev/f0be705eaf76cb5372990d78979be27acbdd1e68 [^]
2013-01-29 10:28jecharriRelationship addedrelated to 0022919
2013-01-29 10:30hgbotCheckin
2013-01-29 10:30hgbotNote Added: 0055936
2013-01-31 09:53jecharriNote Added: 0055990
2013-02-01 22:28hudsonbotCheckin
2013-02-01 22:28hudsonbotNote Added: 0056067
2013-02-01 22:28hudsonbotCheckin
2013-02-01 22:28hudsonbotNote Added: 0056070
2013-02-01 22:28hudsonbotCheckin
2013-02-01 22:28hudsonbotNote Added: 0056077
2013-02-04 18:20VictorVillarReview Assigned To => VictorVillar
2013-02-04 18:20VictorVillarNote Added: 0056139
2013-02-04 18:20VictorVillarStatusresolved => closed
2015-05-07 10:18vmromanosRelationship addedcauses 0028787

Notes
(0055345)
ikedagus   
2013-01-03 23:03   
I'm pretty sure this is preventing me from creating 2013 periods, this is what I get:
----------------
Error:
Saving failed. The dates period defined is overlapped with another period of an existing year.
----------------

But I don't have any 2013 related periods created anywhere.
I'm running Openbravo 3 Community edition MP17.1
(0055496)
ikedagus   
2013-01-13 00:23   
Nevermind, the error was fixed after I upgraded from MP17.1 to MP18.2
Thanks.
(0055900)
hgbot   
2013-01-28 11:45   
Repository: erp/devel/pi
Changeset: c915c82a2e1dd73eff7b46e0fd54fa16543b20c0
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 28 11:44:47 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c915c82a2e1dd73eff7b46e0fd54fa16543b20c0 [^]

Fixes issue 22293: Wrong checking in c_period_trg3 trigger

---
M src-db/database/model/functions/C_YEARPERIODS.xml
A src/org/openbravo/Event/PeriodEnventHandler.java
R src-db/database/model/triggers/C_PERIOD_TRG3.xml
---
(0055909)
hgbot   
2013-01-28 13:56   
Repository: erp/devel/pi
Changeset: f0be705eaf76cb5372990d78979be27acbdd1e68
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 28 13:55:25 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f0be705eaf76cb5372990d78979be27acbdd1e68 [^]

Fixes issue 22293: Wrong checking in c_period_trg3 trigger

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M src/org/openbravo/Event/PeriodEnventHandler.java
---
(0055936)
hgbot   
2013-01-29 10:30   
Repository: erp/devel/pi
Changeset: 4326aacab306173f19708dca6e3da8b4540cd260
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Jan 29 10:29:47 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4326aacab306173f19708dca6e3da8b4540cd260 [^]

Fixes issue 22919: Automated test regression, issue 22293

---
M src-db/database/model/functions/C_YEARPERIODS.xml
---
(0055990)
jecharri   
2013-01-31 09:53   
Test cases:
-steps to reproduce. Verify in an old instance that you can create now periods.
-Create period for different years.
-verify that you you can create periods for different organizations but the same year.

-modify one period and see that you can do if you do not overlap with others periods.
-modify one period and see that you can not do if you overlap another period.
Verify the above conditions when you create or modify a period
(0056067)
hudsonbot   
2013-02-01 22:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056070)
hudsonbot   
2013-02-01 22:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056077)
hudsonbot   
2013-02-01 22:28   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b070aa80fc76 [^]

Maturity status: Test
(0056139)
VictorVillar   
2013-02-04 18:20   
Verified