Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021785
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2012-09-28 10:562012-12-19 10:42
ReporteriperdomoView Statuspublic 
Assigned Tomarvintm 
PriorityurgentResolutionfixedFixed in VersionRMP18
StatusclosedFix in branchpiFixed in SCM revisiona87fe74e4af4
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava versionOpenJDK 1.6.0_24
OS Version3.5.4-1-ARCHDatabase version9.2.1Ant version1.8.2
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021785: Remove entity ProductPrice and add the required princing information to the Product

DescriptionCurrently we have 2 entities: Product and ProductPrice
When showing the information to the user, we need product *with* prices, therefore we need to query 2 tables.

Based on the Web POS design configuration, there is no way to sell to a particular customer with a different "Price List", therefore there is no need to have a different ProductPrice entity. When requesting the Product to the server, the server can include the price based on the Terminal's price list.
Steps To Reproduce* Browse and read the code (product-browser.js) and see that we query 2 different entities (asynchronously) to be able to attach a price to a product, and then we set the collection
* The is meaningless since we could have the products *with* prices already
Proposed Solution* Remove the ProductPrice entity
* Append the princing information to the Product entity
* Modify the required UI components to use only the Product entity
TagsPerformance
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 0022428RMP18 closedadrianromero Performance problem when there is a large number of products 

-  Notes
(0054955)
hgbot (developer)
2012-12-17 10:49

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a87fe74e4af48f1a5d168e1ea35815da50673aa2
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Dec 17 10:49:02 2012 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a87fe74e4af48f1a5d168e1ea35815da50673aa2 [^]

Fixed issue 21785. Refactored M_Product/M_ProductPrice

---
M src/org/openbravo/retail/posterminal/master/Product.java
M web/org.openbravo.retail.posterminal/js/components/product-browser.js
M web/org.openbravo.retail.posterminal/js/components/renderproduct.js
M web/org.openbravo.retail.posterminal/js/components/searchproducts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/model/product.js
M web/org.openbravo.retail.posterminal/js/model/terminal.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ps-productdetailsview.js
---
(0055066)
guilleaer (manager)
2012-12-19 10:42

Reviewed and tested

- Issue History
Date Modified Username Field Change
2012-09-28 10:56 iperdomo New Issue
2012-09-28 10:56 iperdomo Assigned To => adrianromero
2012-11-09 13:37 alostale Tag Attached: Performance
2012-11-09 13:37 alostale Status new => scheduled
2012-11-09 13:37 alostale Assigned To adrianromero => marvintm
2012-11-09 13:37 alostale fix_in_branch => pi
2012-12-17 10:49 hgbot Checkin
2012-12-17 10:49 hgbot Note Added: 0054955
2012-12-17 10:49 hgbot Status scheduled => resolved
2012-12-17 10:49 hgbot Resolution open => fixed
2012-12-17 10:49 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a87fe74e4af48f1a5d168e1ea35815da50673aa2 [^]
2012-12-19 10:42 guilleaer Note Added: 0055066
2012-12-19 10:42 guilleaer Status resolved => closed
2012-12-19 10:42 guilleaer Fixed in Version => RMP18
2012-12-20 13:58 adrianromero Relationship added has duplicate 0022428


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker