Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021785Retail ModulesWeb POSpublic2012-09-28 10:562012-12-19 10:42
Reporteriperdomo 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version3.5.4-1-ARCH
Product Version 
Target VersionFixed in VersionRMP18 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021785: Remove entity ProductPrice and add the required princing information to the Product
DescriptionCurrently we have 2 entities: Product and ProductPrice
When showing the information to the user, we need product *with* prices, therefore we need to query 2 tables.

Based on the Web POS design configuration, there is no way to sell to a particular customer with a different "Price List", therefore there is no need to have a different ProductPrice entity. When requesting the Product to the server, the server can include the price based on the Terminal's price list.
Steps To Reproduce* Browse and read the code (product-browser.js) and see that we query 2 different entities (asynchronously) to be able to attach a price to a product, and then we set the collection
* The is meaningless since we could have the products *with* prices already
Proposed Solution* Remove the ProductPrice entity
* Append the princing information to the Product entity
* Modify the required UI components to use only the Product entity
Additional Information
TagsPerformance
Relationships
has duplicate defect 0022428RMP18 closed adrianromero Performance problem when there is a large number of products 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-09-28 10:56iperdomoNew Issue
2012-09-28 10:56iperdomoAssigned To => adrianromero
2012-11-09 13:37alostaleTag Attached: Performance
2012-11-09 13:37alostaleStatusnew => scheduled
2012-11-09 13:37alostaleAssigned Toadrianromero => marvintm
2012-11-09 13:37alostalefix_in_branch => pi
2012-12-17 10:49hgbotCheckin
2012-12-17 10:49hgbotNote Added: 0054955
2012-12-17 10:49hgbotStatusscheduled => resolved
2012-12-17 10:49hgbotResolutionopen => fixed
2012-12-17 10:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a87fe74e4af48f1a5d168e1ea35815da50673aa2 [^]
2012-12-19 10:42guilleaerNote Added: 0055066
2012-12-19 10:42guilleaerStatusresolved => closed
2012-12-19 10:42guilleaerFixed in Version => RMP18
2012-12-20 13:58adrianromeroRelationship addedhas duplicate 0022428

Notes
(0054955)
hgbot   
2012-12-17 10:49   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: a87fe74e4af48f1a5d168e1ea35815da50673aa2
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Dec 17 10:49:02 2012 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a87fe74e4af48f1a5d168e1ea35815da50673aa2 [^]

Fixed issue 21785. Refactored M_Product/M_ProductPrice

---
M src/org/openbravo/retail/posterminal/master/Product.java
M web/org.openbravo.retail.posterminal/js/components/product-browser.js
M web/org.openbravo.retail.posterminal/js/components/renderproduct.js
M web/org.openbravo.retail.posterminal/js/components/searchproducts.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/model/product.js
M web/org.openbravo.retail.posterminal/js/model/terminal.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboardorder.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/ps-productdetailsview.js
---
(0055066)
guilleaer   
2012-12-19 10:42   
Reviewed and tested