Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021620
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2012-09-12 12:142012-10-01 13:25
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PriorityimmediateResolutionfixedFixed in Version3.0MP16
StatusclosedFix in branchpiFixed in SCM revision8fdf08cdb63e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021620: There has been an API change in the Ad_Ref_Data_Loaded table

DescriptionA change in the Ad_Ref_Data_Loaded has changed the API. This change was intended. The Ad_Module_Id column incorrectly had tabledir reference, and has been changed to String.

This table stores the correspondence between generic ids and specific ids when importing reference data using DAL.

The previous reference for ad_module_id was incorrect because there could be cases in which the ad_ref_data_loaded records pointed to a non-existant module (for example, in case somebody installed a module with reference data, applied the reference data, and then uninstalled it). Maintaining referencial integrity in this case doesn't make sense.

However, due to this reference, DAL checks when importing a client if the referenced modules exist, and fails if they don't. This is very very unlikely to happen in a customer environment, but it's a very inconvenient problem when managing our demo data, both the standard included in Core and the retail demo data.

As this is a very internal table, the chances that somebody is using the DAL-generated class is very low, and moreover, it's important to remark that the api was broken anyway (the previously generated getModule() method would fail if the referenced module didn't exist), so we think the risk of this change affecting any real customer is extremely low.
Steps To Reproduce...
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0052022)
iciordia (viewer)
2012-09-12 15:43

Approved.

Ismael
(0052023)
marvintm (viewer)
2012-09-12 15:46

The change has been accepted
(0052025)
hgbot (developer)
2012-09-12 16:16

Repository: erp/devel/api-checks
Changeset: 8fdf08cdb63e14dae6605a07139e3e36e1404c3c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 12 16:15:41 2012 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/8fdf08cdb63e14dae6605a07139e3e36e1404c3c [^]

Fixed issue 21620. API change accepted

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0052956)
alostale (viewer)
2012-10-01 13:25

API changes should be closed on push

- Issue History
Date Modified Username Field Change
2012-09-12 12:14 marvintm New Issue
2012-09-12 12:14 marvintm Assigned To => iciordia
2012-09-12 12:14 marvintm Modules => Core
2012-09-12 12:14 marvintm OBNetwork customer => No
2012-09-12 15:43 iciordia Note Added: 0052022
2012-09-12 15:43 iciordia Assigned To iciordia => marvintm
2012-09-12 15:45 marvintm Status new => scheduled
2012-09-12 15:45 marvintm fix_in_branch => pi
2012-09-12 15:46 marvintm Note Added: 0052023
2012-09-12 15:46 marvintm Status scheduled => resolved
2012-09-12 15:46 marvintm Fixed in SCM revision => ...
2012-09-12 15:46 marvintm Resolution open => fixed
2012-09-12 16:16 hgbot Checkin
2012-09-12 16:16 hgbot Note Added: 0052025
2012-09-12 16:16 hgbot Fixed in SCM revision ... => http://code.openbravo.com/erp/devel/api-checks/rev/8fdf08cdb63e14dae6605a07139e3e36e1404c3c [^]
2012-10-01 13:25 alostale Note Added: 0052956
2012-10-01 13:25 alostale Status resolved => closed
2012-10-01 13:25 alostale Fixed in Version => 3.0MP16


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker