Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0021620Openbravo ERPA. Platformpublic2012-09-12 12:142012-10-01 13:25
marvintm 
marvintm 
immediatemajorhave not tried
closedfixed 
5
 
3.0MP16 
No
Core
No
0021620: There has been an API change in the Ad_Ref_Data_Loaded table
A change in the Ad_Ref_Data_Loaded has changed the API. This change was intended. The Ad_Module_Id column incorrectly had tabledir reference, and has been changed to String.

This table stores the correspondence between generic ids and specific ids when importing reference data using DAL.

The previous reference for ad_module_id was incorrect because there could be cases in which the ad_ref_data_loaded records pointed to a non-existant module (for example, in case somebody installed a module with reference data, applied the reference data, and then uninstalled it). Maintaining referencial integrity in this case doesn't make sense.

However, due to this reference, DAL checks when importing a client if the referenced modules exist, and fails if they don't. This is very very unlikely to happen in a customer environment, but it's a very inconvenient problem when managing our demo data, both the standard included in Core and the retail demo data.

As this is a very internal table, the chances that somebody is using the DAL-generated class is very low, and moreover, it's important to remark that the api was broken anyway (the previously generated getModule() method would fail if the referenced module didn't exist), so we think the risk of this change affecting any real customer is extremely low.
...
No tags attached.
Issue History
2012-09-12 12:14marvintmNew Issue
2012-09-12 12:14marvintmAssigned To => iciordia
2012-09-12 12:14marvintmModules => Core
2012-09-12 12:14marvintmOBNetwork customer => No
2012-09-12 15:43iciordiaNote Added: 0052022
2012-09-12 15:43iciordiaAssigned Toiciordia => marvintm
2012-09-12 15:45marvintmStatusnew => scheduled
2012-09-12 15:45marvintmfix_in_branch => pi
2012-09-12 15:46marvintmNote Added: 0052023
2012-09-12 15:46marvintmStatusscheduled => resolved
2012-09-12 15:46marvintmFixed in SCM revision => ...
2012-09-12 15:46marvintmResolutionopen => fixed
2012-09-12 16:16hgbotCheckin
2012-09-12 16:16hgbotNote Added: 0052025
2012-09-12 16:16hgbotFixed in SCM revision... => http://code.openbravo.com/erp/devel/api-checks/rev/8fdf08cdb63e14dae6605a07139e3e36e1404c3c [^]
2012-10-01 13:25alostaleNote Added: 0052956
2012-10-01 13:25alostaleStatusresolved => closed
2012-10-01 13:25alostaleFixed in Version => 3.0MP16

Notes
(0052022)
iciordia   
2012-09-12 15:43   
Approved.

Ismael
(0052023)
marvintm   
2012-09-12 15:46   
The change has been accepted
(0052025)
hgbot   
2012-09-12 16:16   
Repository: erp/devel/api-checks
Changeset: 8fdf08cdb63e14dae6605a07139e3e36e1404c3c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 12 16:15:41 2012 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/8fdf08cdb63e14dae6605a07139e3e36e1404c3c [^]

Fixed issue 21620. API change accepted

---
M java/reference/java.japi.gz
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0052956)
alostale   
2012-10-01 13:25   
API changes should be closed on push