Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021584
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2012-09-10 09:442012-09-26 17:18
ReporteriperdomoView Statuspublic 
Assigned ToAugustoMauch 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revision44b875f62465
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava versionOpenJDK 1.6.0_24
OS Version3.5.3-1-ARCHDatabase version9.1.4Ant version1.8.2
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021584: NPE when trying to login with a Google Account and has not been associated with any user

DescriptionWhen a user is already login in Google and tries to login using the 'G' button in the login page without associating the account to an Openbravo user, you get a NPE
Steps To Reproduce* Login into Google
* Don't associated your google account to any Openbravo user
* Click the 'G' login button in the login page
Proposed SolutionLog an error stating that the user has not been associated to any Openbravo user
TagsNo tags attached.
Attached Filesdiff file icon issue21584.diff [^] (2,334 bytes) 2012-09-10 09:56 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0051954)
iperdomo (reporter)
2012-09-10 11:09

To be able to test this configuration, some configuration is required in Tomcat:
http://wiki.openbravo.com/wiki/Configuration_Manual/Google_Integration#Server_Configuration [^]
(0051961)
hgbot (developer)
2012-09-10 13:48

Repository: erp/devel/pi
Changeset: 44b875f6246558064fa663a4b3d6ad18ef011b09
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 10 13:46:20 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/44b875f6246558064fa663a4b3d6ad18ef011b09 [^]

Fixes bug 21584: NPE not thrown when login with an unassociated google account

Now the NPE does not happen, and a warning message is shown to the user.

---
M modules/org.openbravo.service.integration.google/src/org/openbravo/service/integration/google/GoogleAuthServlet.java
M modules/org.openbravo.service.integration.openid/src/org/openbravo/service/integration/openid/OpenIDManager.java
---
(0052532)
migueldejuana (developer)
2012-09-25 09:35

Tested and reviewed in pi@6e892b588e49
(0052723)
hudsonbot (developer)
2012-09-26 17:18

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-09-10 09:44 iperdomo New Issue
2012-09-10 09:44 iperdomo Assigned To => iperdomo
2012-09-10 09:44 iperdomo Web browser => Google Chrome
2012-09-10 09:44 iperdomo Modules => Core
2012-09-10 09:56 iperdomo File Added: issue21584.diff
2012-09-10 09:57 iperdomo Status new => scheduled
2012-09-10 09:57 iperdomo Assigned To iperdomo => AugustoMauch
2012-09-10 09:57 iperdomo fix_in_branch => pi
2012-09-10 11:09 iperdomo Note Added: 0051954
2012-09-10 13:47 AugustoMauch Closed by => migueldejuana
2012-09-10 13:47 AugustoMauch Web browser Google Chrome => Google Chrome
2012-09-10 13:47 AugustoMauch fix_in_branch pi =>
2012-09-10 13:48 hgbot Checkin
2012-09-10 13:48 hgbot Note Added: 0051961
2012-09-10 13:48 hgbot Status scheduled => resolved
2012-09-10 13:48 hgbot Resolution open => fixed
2012-09-10 13:48 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/44b875f6246558064fa663a4b3d6ad18ef011b09 [^]
2012-09-25 09:35 migueldejuana Note Added: 0052532
2012-09-25 09:35 migueldejuana Status resolved => closed
2012-09-25 09:35 migueldejuana Fixed in Version => pi
2012-09-26 17:18 hudsonbot Checkin
2012-09-26 17:18 hudsonbot Note Added: 0052723


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker