Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021584Openbravo ERPA. Platformpublic2012-09-10 09:442012-09-26 17:18
Reporteriperdomo 
Assigned ToAugustoMauch 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version3.5.3-1-ARCH
Product Version 
Target VersionFixed in Versionpi 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021584: NPE when trying to login with a Google Account and has not been associated with any user
DescriptionWhen a user is already login in Google and tries to login using the 'G' button in the login page without associating the account to an Openbravo user, you get a NPE
Steps To Reproduce* Login into Google
* Don't associated your google account to any Openbravo user
* Click the 'G' login button in the login page
Proposed SolutionLog an error stating that the user has not been associated to any Openbravo user
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue21584.diff (2,334) 2012-09-10 09:56
https://issues.openbravo.com/file_download.php?file_id=5559&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-09-10 09:44iperdomoNew Issue
2012-09-10 09:44iperdomoAssigned To => iperdomo
2012-09-10 09:44iperdomoWeb browser => Google Chrome
2012-09-10 09:44iperdomoModules => Core
2012-09-10 09:44iperdomoOBNetwork customer => No
2012-09-10 09:56iperdomoFile Added: issue21584.diff
2012-09-10 09:57iperdomoStatusnew => scheduled
2012-09-10 09:57iperdomoAssigned Toiperdomo => AugustoMauch
2012-09-10 09:57iperdomofix_in_branch => pi
2012-09-10 11:09iperdomoNote Added: 0051954
2012-09-10 13:47AugustoMauchClosed by => migueldejuana
2012-09-10 13:47AugustoMauchWeb browserGoogle Chrome => Google Chrome
2012-09-10 13:47AugustoMauchfix_in_branchpi =>
2012-09-10 13:48hgbotCheckin
2012-09-10 13:48hgbotNote Added: 0051961
2012-09-10 13:48hgbotStatusscheduled => resolved
2012-09-10 13:48hgbotResolutionopen => fixed
2012-09-10 13:48hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/44b875f6246558064fa663a4b3d6ad18ef011b09 [^]
2012-09-25 09:35migueldejuanaNote Added: 0052532
2012-09-25 09:35migueldejuanaStatusresolved => closed
2012-09-25 09:35migueldejuanaFixed in Version => pi
2012-09-26 17:18hudsonbotCheckin
2012-09-26 17:18hudsonbotNote Added: 0052723

Notes
(0051954)
iperdomo   
2012-09-10 11:09   
To be able to test this configuration, some configuration is required in Tomcat:
http://wiki.openbravo.com/wiki/Configuration_Manual/Google_Integration#Server_Configuration [^]
(0051961)
hgbot   
2012-09-10 13:48   
Repository: erp/devel/pi
Changeset: 44b875f6246558064fa663a4b3d6ad18ef011b09
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Sep 10 13:46:20 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/44b875f6246558064fa663a4b3d6ad18ef011b09 [^]

Fixes bug 21584: NPE not thrown when login with an unassociated google account

Now the NPE does not happen, and a warning message is shown to the user.

---
M modules/org.openbravo.service.integration.google/src/org/openbravo/service/integration/google/GoogleAuthServlet.java
M modules/org.openbravo.service.integration.openid/src/org/openbravo/service/integration/openid/OpenIDManager.java
---
(0052532)
migueldejuana   
2012-09-25 09:35   
Tested and reviewed in pi@6e892b588e49
(0052723)
hudsonbot   
2012-09-26 17:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b780e90c6452 [^]

Maturity status: Test