Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0021544 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2012-09-04 12:47 | 2012-12-21 13:30 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | guilleaer | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RMP18 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | 7a28b7fc1023 | |||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0021544: duplicated js resources | |||||||
| Description | Some resources are duplicated because they are included in "UID.js" and in separated files. This files are loaded using script tags in index.html js/components/terminal.js js/model/terminal.js js/components/commonbuttons.js js/components/clock.js And also included using component provider | |||||||
| Steps To Reproduce | Using web developers tools see that the model Terminal appears in a separated file and also in UID.js | |||||||
| Proposed Solution | Remove them from component provider. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  diffCompProvDuplicated.diff [^] (1,297 bytes) 2012-12-13 09:45 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0054907) guilleaer (manager) 2012-12-13 09:48 |
I've attached a file removing from the component provider the files which are duplicated. I will test that all works without issues and then it will be pushed to be included in RMP18 |
|
(0054947) guilleaer (manager) 2012-12-14 13:28 |
This script loader also can be removed: model/terminal.js -> line 132 - $LAB.script('js/i18n.js').wait(function () { +// $LAB.script('js/i18n.js').wait(function () { . . . - }); +// }); |
|
(0054972) hgbot (developer) 2012-12-17 11:55 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 7a28b7fc102368747337b299132ad3516b1b6bc6 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Mon Dec 17 11:54:40 2012 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a28b7fc102368747337b299132ad3516b1b6bc6 [^] fixed issue 21544 -> remove duplicated js files --- M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java M web/org.openbravo.retail.posterminal/js/model/terminal.js --- |
|
(0055050) hgbot (developer) 2012-12-18 13:03 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d864c2f6898fd1e8ba1a24772134d3c294020f21 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Dec 18 13:02:35 2012 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d864c2f6898fd1e8ba1a24772134d3c294020f21 [^] related to issue 21544: Because labels are loaded after commonbuttons, getLabel actions must be done into initComponents --- M web/org.openbravo.retail.posterminal/js/components/commonbuttons.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-09-04 12:47 | guilleaer | New Issue | |
| 2012-09-04 12:47 | guilleaer | Assigned To | => adrianromero |
| 2012-09-04 12:54 | guilleaer | File Added: diffDuplicatedJs.diff | |
| 2012-09-13 17:25 | adrianromero | Relationship added | related to 0021453 |
| 2012-11-09 13:19 | alostale | Status | new => scheduled |
| 2012-11-09 13:19 | alostale | Assigned To | adrianromero => guilleaer |
| 2012-11-09 13:19 | alostale | fix_in_branch | => pi |
| 2012-12-13 09:45 | guilleaer | File Added: diffCompProvDuplicated.diff | |
| 2012-12-13 09:48 | guilleaer | Note Added: 0054907 | |
| 2012-12-13 10:33 | guilleaer | File Deleted: diffDuplicatedJs.diff | |
| 2012-12-14 13:28 | guilleaer | Note Added: 0054947 | |
| 2012-12-17 11:55 | hgbot | Checkin | |
| 2012-12-17 11:55 | hgbot | Note Added: 0054972 | |
| 2012-12-17 11:55 | hgbot | Status | scheduled => resolved |
| 2012-12-17 11:55 | hgbot | Resolution | open => fixed |
| 2012-12-17 11:55 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a28b7fc102368747337b299132ad3516b1b6bc6 [^] |
| 2012-12-18 13:03 | hgbot | Checkin | |
| 2012-12-18 13:03 | hgbot | Note Added: 0055050 | |
| 2012-12-21 13:30 | marvintm | Status | resolved => closed |
| 2012-12-21 13:30 | marvintm | Fixed in Version | => RMP18 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |