Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0021544 | Retail Modules | Web POS | public | 2012-09-04 12:47 | 2012-12-21 13:30 |
|
| Reporter | guilleaer | |
| Assigned To | guilleaer | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RMP18 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0021544: duplicated js resources |
| Description | Some resources are duplicated because they are included in "UID.js" and in separated files.
This files are loaded using script tags in index.html
js/components/terminal.js
js/model/terminal.js
js/components/commonbuttons.js
js/components/clock.js
And also included using component provider |
| Steps To Reproduce | Using web developers tools see that the model Terminal appears in a separated file and also in UID.js |
| Proposed Solution | Remove them from component provider. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0021453 | | closed | guilleaer | js resources are loaded, but they are still present in the webpage |
|
| Attached Files |  diffCompProvDuplicated.diff (1,297) 2012-12-13 09:45
https://issues.openbravo.com/file_download.php?file_id=5828&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-09-04 12:47 | guilleaer | New Issue | |
| 2012-09-04 12:47 | guilleaer | Assigned To | => adrianromero |
| 2012-09-04 12:54 | guilleaer | File Added: diffDuplicatedJs.diff | |
| 2012-09-13 17:25 | adrianromero | Relationship added | related to 0021453 |
| 2012-11-09 13:19 | alostale | Status | new => scheduled |
| 2012-11-09 13:19 | alostale | Assigned To | adrianromero => guilleaer |
| 2012-11-09 13:19 | alostale | fix_in_branch | => pi |
| 2012-12-13 09:45 | guilleaer | File Added: diffCompProvDuplicated.diff | |
| 2012-12-13 09:48 | guilleaer | Note Added: 0054907 | |
| 2012-12-13 10:33 | guilleaer | File Deleted: diffDuplicatedJs.diff | |
| 2012-12-14 13:28 | guilleaer | Note Added: 0054947 | |
| 2012-12-17 11:55 | hgbot | Checkin | |
| 2012-12-17 11:55 | hgbot | Note Added: 0054972 | |
| 2012-12-17 11:55 | hgbot | Status | scheduled => resolved |
| 2012-12-17 11:55 | hgbot | Resolution | open => fixed |
| 2012-12-17 11:55 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a28b7fc102368747337b299132ad3516b1b6bc6 [^] |
| 2012-12-18 13:03 | hgbot | Checkin | |
| 2012-12-18 13:03 | hgbot | Note Added: 0055050 | |
| 2012-12-21 13:30 | marvintm | Status | resolved => closed |
| 2012-12-21 13:30 | marvintm | Fixed in Version | => RMP18 |
|
Notes |
|
|
|
I've attached a file removing from the component provider the files which are duplicated.
I will test that all works without issues and then it will be pushed to be included in RMP18 |
|
|
|
|
This script loader also can be removed:
model/terminal.js -> line 132
- $LAB.script('js/i18n.js').wait(function () {
+// $LAB.script('js/i18n.js').wait(function () {
.
.
.
- });
+// }); |
|
|
|
(0054972)
|
|
hgbot
|
|
2012-12-17 11:55
|
|
|
|
|
(0055050)
|
|
hgbot
|
|
2012-12-18 13:03
|
|
|