Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021332
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2012-08-08 18:232012-08-23 15:22
ReporterdbazView Statuspublic 
Assigned Tomtaal 
PriorityhighResolutionfixedFixed in Version3.0MP15
StatusclosedFix in branchpiFixed in SCM revisiond7b435781ed2
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todbaz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021332: openDirectTab doesn't show process buttons if the opened tab is a child one

DescriptionopenDirectTab doesn't show process buttons if the opened tab is a child one
Steps To ReproduceLogin into the application
Open a developer console
Enter this:

OB.Utilities.openDirectTab('187', '029FD997C4E14F9E98FBA8549D5884A6');

Sometimes it adds the "Close" right-button to the toolbar and sometimes it doesn't
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00208253.0MP14 closedmigueldejuana Buttons of the G/L Journal disappear 
related to defect 00214543.0MP15 closedmtaal Click in an empty child results in an inconsistent toolbar behavior 

-  Notes
(0051180)
dbaz (developer)
2012-08-08 18:24

Once the issue be fixed, this one should be reverted:
https://issues.openbravo.com/view.php?id=20825 [^]

The test case (to close it) should be done in Firefox + Internet Explorer + Chrome
(0051404)
hgbot (developer)
2012-08-20 22:06

Repository: erp/devel/pi
Changeset: d7b435781ed2e137a195e2300b4b99398ff3ddaa
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 20 22:05:02 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d7b435781ed2e137a195e2300b4b99398ff3ddaa [^]

Fixes issue 21332: openDirectTab doesn't show process buttons if the opened tab is a child one
Call updatebuttonstate also for child windows if the parent record gets selected in case
of open direct on tab
Prevent excessive calls to updatebuttonstate

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0051405)
mtaal (manager)
2012-08-20 22:07

The part that prevents excessive calls to updatebuttonstate (ob-toolbar.js) is a risky change.
Also 20825 needs to be retested.
(0051406)
mtaal (manager)
2012-08-20 22:11

To test the risky change try windows with buttons in parent and child tabs and see what happens if you change the active tab or select and deselect records.
(0051408)
mtaal (manager)
2012-08-20 22:21

Setting closed by
(0051412)
mtaal (manager)
2012-08-20 22:25

Scheduled
(0051413)
mtaal (manager)
2012-08-20 22:25

Resolved
(0051511)
dbaz (developer)
2012-08-23 15:22

Reviewed @ changeset: 17752 - f1c506df75cd

- Issue History
Date Modified Username Field Change
2012-08-08 18:23 dbaz New Issue
2012-08-08 18:23 dbaz Assigned To => mtaal
2012-08-08 18:23 dbaz Modules => Core
2012-08-08 18:24 dbaz Note Added: 0051180
2012-08-08 18:24 dbaz Relationship added related to 0020825
2012-08-20 22:06 hgbot Checkin
2012-08-20 22:06 hgbot Note Added: 0051404
2012-08-20 22:06 hgbot Status new => resolved
2012-08-20 22:06 hgbot Resolution open => fixed
2012-08-20 22:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d7b435781ed2e137a195e2300b4b99398ff3ddaa [^]
2012-08-20 22:07 mtaal Note Added: 0051405
2012-08-20 22:11 mtaal Note Added: 0051406
2012-08-20 22:21 mtaal Note Added: 0051408
2012-08-20 22:21 mtaal Status resolved => new
2012-08-20 22:21 mtaal Resolution fixed => open
2012-08-20 22:23 mtaal Closed by => dbaz
2012-08-20 22:25 mtaal Status new => scheduled
2012-08-20 22:25 mtaal Note Added: 0051412
2012-08-20 22:25 mtaal fix_in_branch => pi
2012-08-20 22:25 mtaal Note Added: 0051413
2012-08-20 22:25 mtaal Status scheduled => resolved
2012-08-20 22:25 mtaal Fixed in Version => 3.0MP15
2012-08-20 22:25 mtaal Resolution open => fixed
2012-08-23 15:22 dbaz Note Added: 0051511
2012-08-23 15:22 dbaz Status resolved => closed
2012-08-24 18:52 dbaz Relationship added related to 0021454


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker