Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021332Openbravo ERPA. Platformpublic2012-08-08 18:232012-08-23 15:22
Reporterdbaz 
Assigned Tomtaal 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned Todbaz
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021332: openDirectTab doesn't show process buttons if the opened tab is a child one
DescriptionopenDirectTab doesn't show process buttons if the opened tab is a child one
Steps To ReproduceLogin into the application
Open a developer console
Enter this:

OB.Utilities.openDirectTab('187', '029FD997C4E14F9E98FBA8549D5884A6');

Sometimes it adds the "Close" right-button to the toolbar and sometimes it doesn't
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00208253.0MP14 closed migueldejuana Buttons of the G/L Journal disappear 
related to defect 00214543.0MP15 closed mtaal Click in an empty child results in an inconsistent toolbar behavior 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-08 18:23dbazNew Issue
2012-08-08 18:23dbazAssigned To => mtaal
2012-08-08 18:23dbazModules => Core
2012-08-08 18:24dbazNote Added: 0051180
2012-08-08 18:24dbazRelationship addedrelated to 0020825
2012-08-20 22:06hgbotCheckin
2012-08-20 22:06hgbotNote Added: 0051404
2012-08-20 22:06hgbotStatusnew => resolved
2012-08-20 22:06hgbotResolutionopen => fixed
2012-08-20 22:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d7b435781ed2e137a195e2300b4b99398ff3ddaa [^]
2012-08-20 22:07mtaalNote Added: 0051405
2012-08-20 22:11mtaalNote Added: 0051406
2012-08-20 22:21mtaalNote Added: 0051408
2012-08-20 22:21mtaalStatusresolved => new
2012-08-20 22:21mtaalResolutionfixed => open
2012-08-20 22:23mtaalClosed by => dbaz
2012-08-20 22:25mtaalStatusnew => scheduled
2012-08-20 22:25mtaalNote Added: 0051412
2012-08-20 22:25mtaalfix_in_branch => pi
2012-08-20 22:25mtaalNote Added: 0051413
2012-08-20 22:25mtaalStatusscheduled => resolved
2012-08-20 22:25mtaalFixed in Version => 3.0MP15
2012-08-20 22:25mtaalResolutionopen => fixed
2012-08-23 15:22dbazNote Added: 0051511
2012-08-23 15:22dbazStatusresolved => closed
2012-08-24 18:52dbazRelationship addedrelated to 0021454

Notes
(0051180)
dbaz   
2012-08-08 18:24   
Once the issue be fixed, this one should be reverted:
https://issues.openbravo.com/view.php?id=20825 [^]

The test case (to close it) should be done in Firefox + Internet Explorer + Chrome
(0051404)
hgbot   
2012-08-20 22:06   
Repository: erp/devel/pi
Changeset: d7b435781ed2e137a195e2300b4b99398ff3ddaa
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 20 22:05:02 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d7b435781ed2e137a195e2300b4b99398ff3ddaa [^]

Fixes issue 21332: openDirectTab doesn't show process buttons if the opened tab is a child one
Call updatebuttonstate also for child windows if the parent record gets selected in case
of open direct on tab
Prevent excessive calls to updatebuttonstate

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0051405)
mtaal   
2012-08-20 22:07   
The part that prevents excessive calls to updatebuttonstate (ob-toolbar.js) is a risky change.
Also 20825 needs to be retested.
(0051406)
mtaal   
2012-08-20 22:11   
To test the risky change try windows with buttons in parent and child tabs and see what happens if you change the active tab or select and deselect records.
(0051408)
mtaal   
2012-08-20 22:21   
Setting closed by
(0051412)
mtaal   
2012-08-20 22:25   
Scheduled
(0051413)
mtaal   
2012-08-20 22:25   
Resolved
(0051511)
dbaz   
2012-08-23 15:22   
Reviewed @ changeset: 17752 - f1c506df75cd