Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0021328 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
design defect | [Openbravo ERP] B. User interface | minor | always | 2012-08-08 13:03 | 2012-09-01 01:02 | |||
Reporter | ngarcia | View Status | public | |||||
Assigned To | dbaz | |||||||
Priority | high | Resolution | fixed | Fixed in Version | 3.0MP15 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 7239d60307b4 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | pi | SCM revision | ||||||
Merge Request Status | ||||||||
Review Assigned To | guilleaer | |||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | 16478 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0021328: Modal pop-ups opened by process button cannot be maximized | |||||||
Description | Modal pop-ups opened by process button cannot be maximized, while some pop-up can be maximized. | |||||||
Steps To Reproduce | As group admin role: Go to Financial Account window, select a record and click the "Add Transaction" button Notice that the pop-up does not have the maximize button Click on the "Add Payment In/Out" button Notice that this pop-us has the maximize button | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0051225) dbaz (viewer) 2012-08-09 21:27 |
To do modal pop-ups opened by process button have maximize/minimize buttons, change in file: org.openbravo.client.application/js/toolbar/ob-action-button.js line 112 var popup = OB.Layout.ClassicOBCompatibility.Popup.open('process', 900, 600, OB.Utilities.applicationUrl(me.obManualURL), '', null, false, false, true, allProperties); by var popup = OB.Layout.ClassicOBCompatibility.Popup.open('process', 900, 600, OB.Utilities.applicationUrl(me.obManualURL), '', null, true, true, true, allProperties); so, change two "false" arguments to "true" |
(0051616) iciordia (viewer) 2012-08-29 10:23 |
After conversations with all stakeholders, the conclusion is that we should add the maximize buttons to those pop-up windows. Later we will refactor those windows to be 3.0, but till then the ability to maximize them is not harmful and in some cases helps. Please go ahead with it. Thanks, Ismael |
(0051617) hgbot (developer) 2012-08-29 10:36 |
Repository: erp/devel/pi Changeset: 7239d60307b430dd67226463f7982bb61f63874e Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Wed Aug 29 10:35:38 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/7239d60307b430dd67226463f7982bb61f63874e [^] Fixed issue 21328: Added maximize and minimize buttons to process popups --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js --- |
(0051641) guilleaer (viewer) 2012-08-29 17:21 |
code reviewed and tested in pi@19952d22eb0a |
(0051729) hudsonbot (viewer) 2012-09-01 01:02 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05b3ea484705 [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2012-08-08 13:03 | ngarcia | New Issue | |
2012-08-08 13:03 | ngarcia | Assigned To | => dbaz |
2012-08-08 13:03 | ngarcia | Modules | => Core |
2012-08-08 13:03 | ngarcia | OBNetwork customer | => Yes |
2012-08-08 13:03 | ngarcia | Support ticket | => 16478 |
2012-08-08 13:03 | ngarcia | Resolution time | => 1350856800 |
2012-08-08 13:04 | ngarcia | Issue Monitored: networkb | |
2012-08-09 21:27 | dbaz | Note Added: 0051225 | |
2012-08-28 10:58 | ngarcia | Target Version | 3.0MP16 => |
2012-08-29 10:23 | iciordia | Note Added: 0051616 | |
2012-08-29 10:34 | dbaz | Closed by | => guilleaer |
2012-08-29 10:36 | hgbot | Checkin | |
2012-08-29 10:36 | hgbot | Note Added: 0051617 | |
2012-08-29 10:36 | hgbot | Status | new => resolved |
2012-08-29 10:36 | hgbot | Resolution | open => fixed |
2012-08-29 10:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/7239d60307b430dd67226463f7982bb61f63874e [^] |
2012-08-29 17:21 | guilleaer | Note Added: 0051641 | |
2012-08-29 17:21 | guilleaer | Status | resolved => closed |
2012-08-29 17:21 | guilleaer | Fixed in Version | => 3.0MP15 |
2012-09-01 01:02 | hudsonbot | Checkin | |
2012-09-01 01:02 | hudsonbot | Note Added: 0051729 |
Copyright © 2000 - 2009 MantisBT Group |