Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021328Openbravo ERPB. User interfacepublic2012-08-08 13:032012-09-01 01:02
Reporterngarcia 
Assigned Todbaz 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021328: Modal pop-ups opened by process button cannot be maximized
DescriptionModal pop-ups opened by process button cannot be maximized, while some pop-up can be maximized.
Steps To ReproduceAs group admin role:
   Go to Financial Account window, select a record and click the "Add Transaction" button
   Notice that the pop-up does not have the maximize button
   Click on the "Add Payment In/Out" button
   Notice that this pop-us has the maximize button
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-08-08 13:03ngarciaNew Issue
2012-08-08 13:03ngarciaAssigned To => dbaz
2012-08-08 13:03ngarciaModules => Core
2012-08-08 13:03ngarciaResolution time => 1350856800
2012-08-08 13:04ngarciaIssue Monitored: networkb
2012-08-09 21:27dbazNote Added: 0051225
2012-08-28 10:58ngarciaTarget Version3.0MP16 =>
2012-08-29 10:23iciordiaNote Added: 0051616
2012-08-29 10:34dbazClosed by => guilleaer
2012-08-29 10:36hgbotCheckin
2012-08-29 10:36hgbotNote Added: 0051617
2012-08-29 10:36hgbotStatusnew => resolved
2012-08-29 10:36hgbotResolutionopen => fixed
2012-08-29 10:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7239d60307b430dd67226463f7982bb61f63874e [^]
2012-08-29 17:21guilleaerNote Added: 0051641
2012-08-29 17:21guilleaerStatusresolved => closed
2012-08-29 17:21guilleaerFixed in Version => 3.0MP15
2012-09-01 01:02hudsonbotCheckin
2012-09-01 01:02hudsonbotNote Added: 0051729

Notes
(0051225)
dbaz   
2012-08-09 21:27   
To do modal pop-ups opened by process button have maximize/minimize buttons, change in file:

org.openbravo.client.application/js/toolbar/ob-action-button.js

line 112

var popup = OB.Layout.ClassicOBCompatibility.Popup.open('process', 900, 600, OB.Utilities.applicationUrl(me.obManualURL), '', null, false, false, true, allProperties);

by

var popup = OB.Layout.ClassicOBCompatibility.Popup.open('process', 900, 600, OB.Utilities.applicationUrl(me.obManualURL), '', null, true, true, true, allProperties);

so, change two "false" arguments to "true"
(0051616)
iciordia   
2012-08-29 10:23   
After conversations with all stakeholders, the conclusion is that we should add the maximize buttons to those pop-up windows. Later we will refactor those windows to be 3.0, but till then the ability to maximize them is not harmful and in some cases helps. Please go ahead with it.

Thanks,

Ismael
(0051617)
hgbot   
2012-08-29 10:36   
Repository: erp/devel/pi
Changeset: 7239d60307b430dd67226463f7982bb61f63874e
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Aug 29 10:35:38 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/7239d60307b430dd67226463f7982bb61f63874e [^]

Fixed issue 21328: Added maximize and minimize buttons to process popups

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0051641)
guilleaer   
2012-08-29 17:21   
code reviewed and tested in pi@19952d22eb0a
(0051729)
hudsonbot   
2012-09-01 01:02   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/05b3ea484705 [^]

Maturity status: Test