Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0021307 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2012-08-03 13:55 | 2016-10-24 09:52 | |||
| Reporter | egoitz | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0MP15 | |||
| Status | closed | Fix in branch | pi | Fixed in SCM revision | fb014b417c71 | |||
| Projection | none | ETA | none | Target Version | 3.0MP15 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | 3.0MP13 | SCM revision | ||||||
| Review Assigned To | AugustoMauch | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2012-05-26 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://code.openbravo.com/erp/devel/pi/rev/f060d41ab218 [^] | |||||||
| Triggers an Emergency Pack | yes | |||||||
| Summary | 0021307: The focus oes not move for the following field from a field using a column with text reference | |||||||
| Description | When creating or editing rows on grid view, using the tab key to navigate from the fields does not work properly. When clicking tab on a field using reference text the focus does not go to the next field. | |||||||
| Steps To Reproduce | -Login as system administrator -Go to textinterfaces window -edit a row -Use tab key to go to the next fields. *see that when pressing tab key having the focus on text field the focus does not go to the next field. The focus is lost | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0051423) AugustoMauch (manager) 2012-08-21 12:32 |
This issue is only reproducible using the obfuscated sources of smartclient (SNAPSHOT_v8.3d_2012-05-26/LGPL Deployment). Using the unobfuscated sources (SNAPSHOT_v8.3d_2012-05-26/LGPL Development Only ), the issue is not reproducible. |
|
(0051440) dbaz (developer) 2012-08-22 01:22 edited on: 2012-08-22 01:29 |
Initial clue provided by migueldejuana: the execution flow doesn't go through "cellEditEnd" of "ob-view-grid.js" when using obfuscated sources After some research from this clue (comparing in each moment unobfuscated ListGrid.js vs ISC_Combined.js): "cellEditEnd" function of "ob-view-grid.js" is called by "cellEditEnd" function of "isomotphic\client\widgets\ListGrid.js" on the tab key press, this "cellEditEnd" function is called from "editorKeyPress" function (this doesn't happen in ISC_Combined.js) this "editorKeyPress" function is called from "_popUpTextAreaItemKeyPress" function (this doesn't happen in ISC_Combined.js) this "_popUpTextAreaItemKeyPress" function is set in "item.textAreaKeyDown = this._popUpTextAreaItemKeyDown;" inside "getEditItem" function (this "getEditItem" function is called also in ISC_Combined.js) Debugging inside "getEditItem" function in parallel in both environments (obfuscated and unobfuscated), the problem is in the "this._popUpTextAreaEditorTypes" object definition: in the unobfuscated sources it has the "OBPopUpTextAreaItem: true" attribute but it is not present in the obfuscated sources. This fact, later in the same "getEditItem" function, is translated in that "item.textAreaKeyDown = this._popUpTextAreaItemKeyDown;" is never set due to an -if- statement including that. Searching for "OBPopUpTextAreaItem" and/or "_popUpTextAreaItemKeyDown" in sources, it moves you directly here: https://code.openbravo.com/erp/devel/pi/file/9c6fb1606fa2/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-textarea.js#l86 [^] There is the problem source: an obfuscated variable set in a hardcoded way. This variable should have been changed when Smartclient code gets updated, and of course, it should be taked into account for future upgrades. The explanation of why this hardcoded variable is set there, is there too as a code comment. |
|
(0051441) hgbot (developer) 2012-08-22 01:38 |
Repository: erp/devel/pi Changeset: fb014b417c71367592af08d2257990f613bcbeb2 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Wed Aug 22 01:38:15 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/fb014b417c71367592af08d2257990f613bcbeb2 [^] Fixed issue 21307: Now the focus moves ok on tab key press while editing a grid item with text reference (textarea) --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-textarea.js --- |
|
(0051443) AugustoMauch (manager) 2012-08-22 09:27 |
Code reviewed and verified in pi@fb014b417c71 |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-08-03 13:55 | egoitz | New Issue | |
| 2012-08-03 13:55 | egoitz | Assigned To | => alostale |
| 2012-08-03 13:55 | egoitz | Modules | => Core |
| 2012-08-03 13:55 | egoitz | Resolution time | => 1344290400 |
| 2012-08-03 14:11 | extra | Issue Monitored: extra | |
| 2012-08-03 14:11 | alostale | Assigned To | alostale => AugustoMauch |
| 2012-08-13 10:14 | heccam | Issue Monitored: heccam | |
| 2012-08-21 12:32 | AugustoMauch | Note Added: 0051423 | |
| 2012-08-22 01:03 | dbaz | Assigned To | AugustoMauch => dbaz |
| 2012-08-22 01:05 | dbaz | Regression level | => Production - QA Approved |
| 2012-08-22 01:05 | dbaz | Regression date | => 2012-05-26 |
| 2012-08-22 01:05 | dbaz | Regression introduced by commit | => https://code.openbravo.com/erp/devel/pi/rev/f060d41ab218 [^] |
| 2012-08-22 01:05 | dbaz | Steps to Reproduce Updated | View Revisions |
| 2012-08-22 01:22 | dbaz | Note Added: 0051440 | |
| 2012-08-22 01:29 | dbaz | Note Edited: 0051440 | View Revisions |
| 2012-08-22 01:35 | dbaz | Closed by | => AugustoMauch |
| 2012-08-22 01:38 | hgbot | Checkin | |
| 2012-08-22 01:38 | hgbot | Note Added: 0051441 | |
| 2012-08-22 01:38 | hgbot | Status | new => resolved |
| 2012-08-22 01:38 | hgbot | Resolution | open => fixed |
| 2012-08-22 01:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/fb014b417c71367592af08d2257990f613bcbeb2 [^] |
| 2012-08-22 01:43 | dbaz | Status | resolved => new |
| 2012-08-22 01:43 | dbaz | Resolution | fixed => open |
| 2012-08-22 01:43 | dbaz | Relationship added | related to 0016327 |
| 2012-08-22 01:44 | dbaz | Status | new => scheduled |
| 2012-08-22 01:44 | dbaz | fix_in_branch | => pi |
| 2012-08-22 01:44 | dbaz | Status | scheduled => resolved |
| 2012-08-22 01:44 | dbaz | Resolution | open => fixed |
| 2012-08-22 09:27 | AugustoMauch | Note Added: 0051443 | |
| 2012-08-22 09:27 | AugustoMauch | Status | resolved => closed |
| 2012-08-22 09:27 | AugustoMauch | Fixed in Version | => 3.0MP15 |
| 2016-10-24 09:52 | NaroaIriarte | Relationship added | related to 0034057 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |