Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021187
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionaryminoralways2012-07-24 01:222012-08-20 08:43
ReporterpjuvaraView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version3.0MP15
StatusclosedFix in branchFixed in SCM revision7a91d0fef87d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version3.0MP12.1SCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021187: Data set export should ignore inactive tables

DescriptionIn the Data Set window you can define data sets that export from multiple tables.

Each table has an Active flag and developers should be able to use that flag to exclude tables that are no longer active.

Checking / unchecking that flag makes no difference
Steps To Reproduce1) Define a data set with two records for two tables
2) Mark one as inactive
3) Press Export
4) Examine the XML file: it still contains the data from the inactive table.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 00213673.0MP15 closedAugustoMauch Automated tests: DatasetExportTest has failed 

-  Notes
(0051253)
AugustoMauch (manager)
2012-08-13 10:14

Hi Paolo,

This change implies an API change, so we have to make sure that we really need it. Maybe another option would be not to include the table in the dataset, if the user does not want to export it.

Anyway, if you prefer to control this using the active flag, please confirm it and we will handle the API change.

Regards
(0051265)
pjuvara (reporter)
2012-08-13 15:24

Augusto: what is the nature of the API change?
(0051271)
AugustoMauch (manager)
2012-08-14 08:41

Paolo: We would be changing the way datasets are exported. Somewhere there may be a developer that had defined a dataset with tables flagged as inactive, and right now when he exports the dataset, all the tables are exported. If we implement the change, then only the tables flagged as active will be exported, and that developer might be affected by the change.

Anyway, I don't this case is very common, so if you give us the green light, we can avoid considering this issue an API change (the fix is already done).
(0051297)
pjuvara (reporter)
2012-08-14 14:53

I would not consider that an API change.

Please go ahead and implement the change.

Thanks.
(0051314)
hgbot (developer)
2012-08-16 09:54

Repository: erp/devel/pi
Changeset: 5816fb3ef563bdd6cc955994a0c80519447b3ee7
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Wed Aug 15 15:07:41 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5816fb3ef563bdd6cc955994a0c80519447b3ee7 [^]

Fixes Issue 21187 : Ignore inactive tables when exporting dataset

---
M src/org/openbravo/service/db/DataExportService.java
---
(0051316)
hgbot (developer)
2012-08-16 11:30

Repository: erp/devel/pi
Changeset: cd2593599d457a380adc7b07a4233ebfa218b2d1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 16 11:29:14 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cd2593599d457a380adc7b07a4233ebfa218b2d1 [^]

Fixes issue 21367: Backout of fix of issue 21187

The fix of issue 21187 has been reverted. That issue will be reopened and its fix reimplemented.

---
M src/org/openbravo/service/db/DataExportService.java
---
(0051318)
AugustoMauch (manager)
2012-08-16 11:32

The fix has been reverted because it caused [1]

[1] https://issues.openbravo.com/view.php?id=21367 [^]
(0051352)
hgbot (developer)
2012-08-20 08:42

Repository: erp/devel/pi
Changeset: 7a91d0fef87d40bf97a10c1e919e09e6f28b8d08
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Thu Aug 16 21:02:26 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7a91d0fef87d40bf97a10c1e919e09e6f28b8d08 [^]

Fixes Issue 21187 : Ignore inactive tables when exporting dataset

---
M src/org/openbravo/service/db/DataExportService.java
---
(0051353)
AugustoMauch (manager)
2012-08-20 08:43

Code reviewed and verified in pi@7a91d0fef87d

- Issue History
Date Modified Username Field Change
2012-07-24 01:22 pjuvara New Issue
2012-07-24 01:22 pjuvara Assigned To => alostale
2012-07-24 01:22 pjuvara Modules => Core
2012-08-09 13:47 AugustoMauch Assigned To alostale => AugustoMauch
2012-08-13 10:14 AugustoMauch Note Added: 0051253
2012-08-13 15:24 pjuvara Note Added: 0051265
2012-08-14 08:41 AugustoMauch Note Added: 0051271
2012-08-14 14:53 pjuvara Note Added: 0051297
2012-08-16 09:54 hgbot Checkin
2012-08-16 09:54 hgbot Note Added: 0051314
2012-08-16 09:54 hgbot Status new => resolved
2012-08-16 09:54 hgbot Resolution open => fixed
2012-08-16 09:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5816fb3ef563bdd6cc955994a0c80519447b3ee7 [^]
2012-08-16 11:27 AugustoMauch Relationship added related to 0021367
2012-08-16 11:30 hgbot Checkin
2012-08-16 11:30 hgbot Note Added: 0051316
2012-08-16 11:32 AugustoMauch Note Added: 0051318
2012-08-16 11:32 AugustoMauch Status resolved => new
2012-08-16 11:32 AugustoMauch Resolution fixed => open
2012-08-20 08:42 hgbot Checkin
2012-08-20 08:42 hgbot Note Added: 0051352
2012-08-20 08:42 hgbot Status new => resolved
2012-08-20 08:42 hgbot Resolution open => fixed
2012-08-20 08:42 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/5816fb3ef563bdd6cc955994a0c80519447b3ee7 [^] => http://code.openbravo.com/erp/devel/pi/rev/7a91d0fef87d40bf97a10c1e919e09e6f28b8d08 [^]
2012-08-20 08:43 AugustoMauch Closed by => AugustoMauch
2012-08-20 08:43 AugustoMauch Note Added: 0051353
2012-08-20 08:43 AugustoMauch Status resolved => closed
2012-08-20 08:43 AugustoMauch Fixed in Version => 3.0MP15


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker