Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0021187Openbravo ERP00. Application dictionarypublic2012-07-24 01:222012-08-20 08:43
Reporterpjuvara 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP12.1 
Target VersionFixed in Version3.0MP15 
Merge Request Status
Review Assigned ToAugustoMauch
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0021187: Data set export should ignore inactive tables
DescriptionIn the Data Set window you can define data sets that export from multiple tables.

Each table has an Active flag and developers should be able to use that flag to exclude tables that are no longer active.

Checking / unchecking that flag makes no difference
Steps To Reproduce1) Define a data set with two records for two tables
2) Mark one as inactive
3) Press Export
4) Examine the XML file: it still contains the data from the inactive table.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00213673.0MP15 closed AugustoMauch Automated tests: DatasetExportTest has failed 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-07-24 01:22pjuvaraNew Issue
2012-07-24 01:22pjuvaraAssigned To => alostale
2012-07-24 01:22pjuvaraModules => Core
2012-07-24 01:22pjuvaraOBNetwork customer => No
2012-08-09 13:47AugustoMauchAssigned Toalostale => AugustoMauch
2012-08-13 10:14AugustoMauchNote Added: 0051253
2012-08-13 15:24pjuvaraNote Added: 0051265
2012-08-14 08:41AugustoMauchNote Added: 0051271
2012-08-14 14:53pjuvaraNote Added: 0051297
2012-08-16 09:54hgbotCheckin
2012-08-16 09:54hgbotNote Added: 0051314
2012-08-16 09:54hgbotStatusnew => resolved
2012-08-16 09:54hgbotResolutionopen => fixed
2012-08-16 09:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5816fb3ef563bdd6cc955994a0c80519447b3ee7 [^]
2012-08-16 11:27AugustoMauchRelationship addedrelated to 0021367
2012-08-16 11:30hgbotCheckin
2012-08-16 11:30hgbotNote Added: 0051316
2012-08-16 11:32AugustoMauchNote Added: 0051318
2012-08-16 11:32AugustoMauchStatusresolved => new
2012-08-16 11:32AugustoMauchResolutionfixed => open
2012-08-20 08:42hgbotCheckin
2012-08-20 08:42hgbotNote Added: 0051352
2012-08-20 08:42hgbotStatusnew => resolved
2012-08-20 08:42hgbotResolutionopen => fixed
2012-08-20 08:42hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/5816fb3ef563bdd6cc955994a0c80519447b3ee7 [^] => http://code.openbravo.com/erp/devel/pi/rev/7a91d0fef87d40bf97a10c1e919e09e6f28b8d08 [^]
2012-08-20 08:43AugustoMauchClosed by => AugustoMauch
2012-08-20 08:43AugustoMauchNote Added: 0051353
2012-08-20 08:43AugustoMauchStatusresolved => closed
2012-08-20 08:43AugustoMauchFixed in Version => 3.0MP15

Notes
(0051253)
AugustoMauch   
2012-08-13 10:14   
Hi Paolo,

This change implies an API change, so we have to make sure that we really need it. Maybe another option would be not to include the table in the dataset, if the user does not want to export it.

Anyway, if you prefer to control this using the active flag, please confirm it and we will handle the API change.

Regards
(0051265)
pjuvara   
2012-08-13 15:24   
Augusto: what is the nature of the API change?
(0051271)
AugustoMauch   
2012-08-14 08:41   
Paolo: We would be changing the way datasets are exported. Somewhere there may be a developer that had defined a dataset with tables flagged as inactive, and right now when he exports the dataset, all the tables are exported. If we implement the change, then only the tables flagged as active will be exported, and that developer might be affected by the change.

Anyway, I don't this case is very common, so if you give us the green light, we can avoid considering this issue an API change (the fix is already done).
(0051297)
pjuvara   
2012-08-14 14:53   
I would not consider that an API change.

Please go ahead and implement the change.

Thanks.
(0051314)
hgbot   
2012-08-16 09:54   
Repository: erp/devel/pi
Changeset: 5816fb3ef563bdd6cc955994a0c80519447b3ee7
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Wed Aug 15 15:07:41 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/5816fb3ef563bdd6cc955994a0c80519447b3ee7 [^]

Fixes Issue 21187 : Ignore inactive tables when exporting dataset

---
M src/org/openbravo/service/db/DataExportService.java
---
(0051316)
hgbot   
2012-08-16 11:30   
Repository: erp/devel/pi
Changeset: cd2593599d457a380adc7b07a4233ebfa218b2d1
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Aug 16 11:29:14 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/cd2593599d457a380adc7b07a4233ebfa218b2d1 [^]

Fixes issue 21367: Backout of fix of issue 21187

The fix of issue 21187 has been reverted. That issue will be reopened and its fix reimplemented.

---
M src/org/openbravo/service/db/DataExportService.java
---
(0051318)
AugustoMauch   
2012-08-16 11:32   
The fix has been reverted because it caused [1]

[1] https://issues.openbravo.com/view.php?id=21367 [^]
(0051352)
hgbot   
2012-08-20 08:42   
Repository: erp/devel/pi
Changeset: 7a91d0fef87d40bf97a10c1e919e09e6f28b8d08
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Thu Aug 16 21:02:26 2012 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/7a91d0fef87d40bf97a10c1e919e09e6f28b8d08 [^]

Fixes Issue 21187 : Ignore inactive tables when exporting dataset

---
M src/org/openbravo/service/db/DataExportService.java
---
(0051353)
AugustoMauch   
2012-08-20 08:43   
Code reviewed and verified in pi@7a91d0fef87d