Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0021071

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

major

always

2012-07-13 13:56

2012-07-27 12:57

Reporter

guilleaer

View Status

public

Assigned To

AugustoMauch

Priority

high

Resolution

fixed

Fixed in Version

3.0MP14

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

OBNetwork customer

No

Web browser

Modules

Core

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2012-05-24

Regression introduced in release

Regression introduced by commit

4a4ad33e5e27 -> 16636

Triggers an Emergency Pack

yes

Summary

0021071: Admin others widget is broken.

Description

When the option "Admin Others" of the workspace doesn't work. The confirmation/close dialog has dissapeared and is not possible to go back to the user workspace.

Steps To Reproduce

1. Log in as F&B Group admin
2. In the left column of the workspace (bellow) click "Admin others"
3. select role or org
4. select a role (E.g. System)
5. click edit button

The attached dialog doesn't appear and the workspace doesn't show the rol widgets.
You cannot go back to your workspace.

Proposed Solution

It seems that this regression was introduced by a smartclient upgrade.
I can say that the origin of this error was in this changeset which is a merge.

4a4ad33e5e27 -> 16636

I was researching and I think that a change in behavior of method destroy of smartclient can be the cause of this regression.

I've attached a possible fix for this problem.

Tags

No tags attached.

diffIssueWidgets.diff [^] (1,564 bytes) 2012-07-13 14:01 [Show Content] [Hide Content]

diff --git a/modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js b/modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
--- a/modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
+++ b/modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
@@ -825,7 +825,7 @@
   },
 
   setAdminMode: function (level, levelValue) {
-    var leftColumn = this.leftColumnLayout;
+    var leftColumn = this.leftColumnLayout, levelLabel, levelValueLabel;
 
     this.adminMode = true;
     this.portalLayout.sendEvents = false;
@@ -835,14 +835,17 @@
     leftColumn.recentViewsLayout.hide();
     leftColumn.refreshLayout.hide();
     leftColumn.recentDocumentsLayout.hide();
+    //set this values before destroy because after that there will be undefined
+    levelLabel = level.getDisplayValue();
+    levelValueLabel = levelValue.getDisplayValue ? levelValue.getDisplayValue() : '';
     leftColumn.adminOtherMyOBLayout.getMembers()[1].destroy(); // remove DynamicForm
     leftColumn.adminOtherMyOBLayout.hide();
     if (!leftColumn.addWidgetLayout.getMember(0).isOpened()) {
       leftColumn.addWidgetLayout.getMember(0).doOpen();
     }
     leftColumn.addMember(isc.OBMyOBPublishChangesDialog.create({
-      levelLabel: level.getDisplayValue(),
-      levelValueLabel: levelValue.getDisplayValue ? levelValue.getDisplayValue() : ''
+      levelLabel: levelLabel,
+      levelValueLabel: levelValueLabel
     }));
     this.reloadWidgets();
   },

DisappearDialog.png [^] (11,981 bytes) 2012-07-13 14:01

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0050911) hgbot (developer) 2012-07-26 17:19	Repository: erp/devel/pi Changeset: a73133e6a7286c7c6b00aa9164b5a8b40b4d2178 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Thu Jul 26 17:18:03 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/a73133e6a7286c7c6b00aa9164b5a8b40b4d2178 [^] Fixed issue 21071: In Admin Others, Publish dialog is shown again --- M modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js ---

(0050924) hudsonbot (viewer) 2012-07-27 02:18	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cfe6f4cd84a [^] Maturity status: Test

(0050937) AugustoMauch (administrator) 2012-07-27 12:57	Code reviewed and verified in pi@f119181062af

Issue History
Date Modified	Username	Field	Change
2012-07-13 13:56	guilleaer	New Issue
2012-07-13 13:56	guilleaer	Assigned To	=> AugustoMauch
2012-07-13 13:56	guilleaer	Web browser	=> Google Chrome
2012-07-13 13:56	guilleaer	Modules	=> Core
2012-07-13 13:56	guilleaer	OBNetwork customer	=> No
2012-07-13 14:00	guilleaer	Web browser	Google Chrome => Google Chrome
2012-07-13 14:00	guilleaer	Regression level	=> Production - Confirmed Stable
2012-07-13 14:00	guilleaer	Regression date	=> 2012-05-24
2012-07-13 14:00	guilleaer	Regression introduced by commit	=> 4a4ad33e5e27 -> 16636
2012-07-13 14:00	guilleaer	Proposed Solution updated
2012-07-13 14:01	guilleaer	File Added: diffIssueWidgets.diff
2012-07-13 14:01	guilleaer	File Added: DisappearDialog.png
2012-07-26 17:19	hgbot	Checkin
2012-07-26 17:19	hgbot	Note Added: 0050911
2012-07-26 17:19	hgbot	Status	new => resolved
2012-07-26 17:19	hgbot	Resolution	open => fixed
2012-07-26 17:19	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/a73133e6a7286c7c6b00aa9164b5a8b40b4d2178 [^]
2012-07-27 02:18	hudsonbot	Checkin
2012-07-27 02:18	hudsonbot	Note Added: 0050924
2012-07-27 12:57	AugustoMauch	Note Added: 0050937
2012-07-27 12:57	AugustoMauch	Status	resolved => closed
2012-07-27 12:57	AugustoMauch	Fixed in Version	=> 3.0MP14

Copyright © 2000 - 2009 MantisBT Group